2021-05-04 09:07:35

by Geert Uytterhoeven

Subject: [PATCH] dt-bindings: net: renesas,etheravb: Fix optional second clock name

If the optional "clock-names" property is present, but the optional TXC
reference clock is not, "make dtbs_check" complains:

ethernet@e6800000: clock-names: ['fck'] is too short

Fix this by declaring that a single clock name is valid.
While at it, drop the superfluous upper limit on the number of clocks,
as it is implied by the list of descriptions.

Fixes: 6f43735b6da64bd4 ("dt-bindings: net: renesas,etheravb: Add additional clocks")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
index fe72a5598addf89c..005868f703a6e2cd 100644
--- a/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
+++ b/Documentation/devicetree/bindings/net/renesas,etheravb.yaml
@@ -51,12 +51,12 @@ properties:

clocks:
minItems: 1
- maxItems: 2
items:
- description: AVB functional clock
- description: Optional TXC reference clock

clock-names:
+ minItems: 1
items:
- const: fck
- const: refclk
--
2.25.1

2021-05-04 14:06:49

by Rob Herring

Subject: Re: [PATCH] dt-bindings: net: renesas,etheravb: Fix optional second clock name

On Tue, 04 May 2021 11:03:00 +0200, Geert Uytterhoeven wrote:
> If the optional "clock-names" property is present, but the optional TXC
> reference clock is not, "make dtbs_check" complains:
>
> ethernet@e6800000: clock-names: ['fck'] is too short
>
> Fix this by declaring that a single clock name is valid.
> While at it, drop the superfluous upper limit on the number of clocks,
> as it is implied by the list of descriptions.
>
> Fixes: 6f43735b6da64bd4 ("dt-bindings: net: renesas,etheravb: Add additional clocks")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!