2024-02-20 08:28:52

by Krzysztof Kozlowski

Subject: Re: [PATCH v5 4/4] pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver

On 20/02/2024 01:41, Jacky Huang wrote:
> From: Jacky Huang <[email protected]>
>
> Add common pinctrl and GPIO driver for Nuvoton MA35 series SoC, and
> add support for ma35d1 pinctrl.
>
> Signed-off-by: Jacky Huang <[email protected]>
> ---
> drivers/pinctrl/nuvoton/Kconfig | 19 +
> drivers/pinctrl/nuvoton/Makefile | 2 +
> drivers/pinctrl/nuvoton/pinctrl-ma35.c | 1211 +++++++++++++++
> drivers/pinctrl/nuvoton/pinctrl-ma35.h | 51 +
> drivers/pinctrl/nuvoton/pinctrl-ma35d1.c | 1797 ++++++++++++++++++++++
> 5 files changed, 3080 insertions(+)
> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35.c
> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35.h
> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35d1.c

Driver cannot depend on DTS, so please reorganize patchset so DTS is not
in the middle or even split the DTS to separate patchset.

Best regards,
Krzysztof

2024-02-21 00:52:39

by Jacky Huang

Subject: Re: [PATCH v5 4/4] pinctrl: nuvoton: Add ma35d1 pinctrl and GPIO driver

Dear Krzysztof,


On 2024/2/20 下午 04:28, Krzysztof Kozlowski wrote:
> On 20/02/2024 01:41, Jacky Huang wrote:
>> From: Jacky Huang <[email protected]>
>>
>> Add common pinctrl and GPIO driver for Nuvoton MA35 series SoC, and
>> add support for ma35d1 pinctrl.
>>
>> Signed-off-by: Jacky Huang <[email protected]>
>> ---
>> drivers/pinctrl/nuvoton/Kconfig | 19 +
>> drivers/pinctrl/nuvoton/Makefile | 2 +
>> drivers/pinctrl/nuvoton/pinctrl-ma35.c | 1211 +++++++++++++++
>> drivers/pinctrl/nuvoton/pinctrl-ma35.h | 51 +
>> drivers/pinctrl/nuvoton/pinctrl-ma35d1.c | 1797 ++++++++++++++++++++++
>> 5 files changed, 3080 insertions(+)
>> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35.c
>> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35.h
>> create mode 100644 drivers/pinctrl/nuvoton/pinctrl-ma35d1.c
> Driver cannot depend on DTS, so please reorganize patchset so DTS is not
> in the middle or even split the DTS to separate patchset.
>
> Best regards,
> Krzysztof
>

Thank you for your explanation. In the next version, I will adjust the
order and move the DTS to the end of this patchset. Best Regards, Jacky
Huang