2019-01-24 02:15:59

by Zhaolong Zhang

Subject: [PATCH] tipc: remove dead code in struct tipc_topsrv

max_rcvbuf_size is no longer used since commit "414574a0af36".

Signed-off-by: Zhaolong Zhang <[email protected]>
---
net/tipc/topsrv.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c
index efb16f6..4b1c083 100644
--- a/net/tipc/topsrv.c
+++ b/net/tipc/topsrv.c
@@ -60,7 +60,6 @@
* @awork: accept work item
* @rcv_wq: receive workqueue
* @send_wq: send workqueue
- * @max_rcvbuf_size: maximum permitted receive message length
* @listener: topsrv listener socket
* @name: server name
*/
@@ -72,7 +71,6 @@ struct tipc_topsrv {
struct work_struct awork;
struct workqueue_struct *rcv_wq;
struct workqueue_struct *send_wq;
- int max_rcvbuf_size;
struct socket *listener;
char name[TIPC_SERVER_NAME_LEN];
};
@@ -648,7 +646,6 @@ int tipc_topsrv_start(struct net *net)
return -ENOMEM;

srv->net = net;
- srv->max_rcvbuf_size = sizeof(struct tipc_subscr);
INIT_WORK(&srv->awork, tipc_topsrv_accept);

strscpy(srv->name, name, sizeof(srv->name));
--
1.9.1

2019-01-24 02:51:56

by Ying Xue

Subject: Re: [PATCH] tipc: remove dead code in struct tipc_topsrv

On 1/24/19 10:06 AM, Zhaolong Zhang wrote:
> max_rcvbuf_size is no longer used since commit "414574a0af36".
>
> Signed-off-by: Zhaolong Zhang <[email protected]>

Acked-by: Ying Xue <[email protected]>

> ---
> net/tipc/topsrv.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c
> index efb16f6..4b1c083 100644
> --- a/net/tipc/topsrv.c
> +++ b/net/tipc/topsrv.c
> @@ -60,7 +60,6 @@
> * @awork: accept work item
> * @rcv_wq: receive workqueue
> * @send_wq: send workqueue
> - * @max_rcvbuf_size: maximum permitted receive message length
> * @listener: topsrv listener socket
> * @name: server name
> */
> @@ -72,7 +71,6 @@ struct tipc_topsrv {
> struct work_struct awork;
> struct workqueue_struct *rcv_wq;
> struct workqueue_struct *send_wq;
> - int max_rcvbuf_size;
> struct socket *listener;
> char name[TIPC_SERVER_NAME_LEN];
> };
> @@ -648,7 +646,6 @@ int tipc_topsrv_start(struct net *net)
> return -ENOMEM;
>
> srv->net = net;
> - srv->max_rcvbuf_size = sizeof(struct tipc_subscr);
> INIT_WORK(&srv->awork, tipc_topsrv_accept);
>
> strscpy(srv->name, name, sizeof(srv->name));
>

2019-01-25 06:33:45

by David Miller

Subject: Re: [PATCH] tipc: remove dead code in struct tipc_topsrv

From: Zhaolong Zhang <[email protected]>
Date: Thu, 24 Jan 2019 10:06:41 +0800

> max_rcvbuf_size is no longer used since commit "414574a0af36".
>
> Signed-off-by: Zhaolong Zhang <[email protected]>

Applied.