2024-03-27 17:56:03

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

Core in spi_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/tiny/ili9225.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/ili9225.c b/drivers/gpu/drm/tiny/ili9225.c
index dd8b0a181be9..eb1213352bce 100644
--- a/drivers/gpu/drm/tiny/ili9225.c
+++ b/drivers/gpu/drm/tiny/ili9225.c
@@ -447,7 +447,6 @@ static void ili9225_shutdown(struct spi_device *spi)
static struct spi_driver ili9225_spi_driver = {
.driver = {
.name = "ili9225",
- .owner = THIS_MODULE,
.of_match_table = ili9225_of_match,
},
.id_table = ili9225_id,
--
2.34.1



2024-03-27 17:56:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/4] drm/tiny: mi0283qt: drop driver owner assignment

Core in spi_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/tiny/mi0283qt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/mi0283qt.c b/drivers/gpu/drm/tiny/mi0283qt.c
index 01ff43c8ac3f..05509e519518 100644
--- a/drivers/gpu/drm/tiny/mi0283qt.c
+++ b/drivers/gpu/drm/tiny/mi0283qt.c
@@ -263,7 +263,6 @@ static const struct dev_pm_ops mi0283qt_pm_ops = {
static struct spi_driver mi0283qt_spi_driver = {
.driver = {
.name = "mi0283qt",
- .owner = THIS_MODULE,
.of_match_table = mi0283qt_of_match,
.pm = &mi0283qt_pm_ops,
},
--
2.34.1


2024-03-27 18:04:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 4/4] drm/tiny: st7586: drop driver owner assignment

Core in spi_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/tiny/st7586.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/st7586.c b/drivers/gpu/drm/tiny/st7586.c
index 7336fa1ddaed..c4ad8340180e 100644
--- a/drivers/gpu/drm/tiny/st7586.c
+++ b/drivers/gpu/drm/tiny/st7586.c
@@ -392,7 +392,6 @@ static void st7586_shutdown(struct spi_device *spi)
static struct spi_driver st7586_spi_driver = {
.driver = {
.name = "st7586",
- .owner = THIS_MODULE,
.of_match_table = st7586_of_match,
},
.id_table = st7586_id,
--
2.34.1


2024-03-27 18:27:53

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 3/4] drm/tiny: panel-mipi-dbi: drop driver owner assignment

Core in spi_register_driver() already sets the .owner, so driver
does not need to.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpu/drm/tiny/panel-mipi-dbi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/panel-mipi-dbi.c b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
index f80a141fcf36..a3cc09c578c5 100644
--- a/drivers/gpu/drm/tiny/panel-mipi-dbi.c
+++ b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
@@ -384,7 +384,6 @@ MODULE_DEVICE_TABLE(spi, panel_mipi_dbi_spi_id);
static struct spi_driver panel_mipi_dbi_spi_driver = {
.driver = {
.name = "panel-mipi-dbi-spi",
- .owner = THIS_MODULE,
.of_match_table = panel_mipi_dbi_spi_of_match,
.pm = &panel_mipi_dbi_pm_ops,
},
--
2.34.1


2024-03-27 23:15:46

by David Lechner

[permalink] [raw]
Subject: Re: [PATCH 4/4] drm/tiny: st7586: drop driver owner assignment

On 3/27/24 12:48 PM, Krzysztof Kozlowski wrote:
> Core in spi_register_driver() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---


Acked-by: David Lechner <[email protected]>





2024-03-27 23:22:27

by David Lechner

[permalink] [raw]
Subject: Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

On 3/27/24 12:48 PM, Krzysztof Kozlowski wrote:
> Core in spi_register_driver() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Acked-by: David Lechner <[email protected]>



2024-04-24 06:45:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/4] drm/tiny: ili9225: drop driver owner assignment

On 27/03/2024 18:48, Krzysztof Kozlowski wrote:
> Core in spi_register_driver() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpu/drm/tiny/ili9225.c | 1 -
> 1 file changed, 1 deletion(-)

It has been almost a month. Any comments on this patchset? Can this be
picked up?

Best regards,
Krzysztof