2017-09-23 20:13:17

by Pavel Machek

[permalink] [raw]
Subject: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h

C++ comments look wrong in kernel tree. Fix one.

Signed-off-by: Pavel Machek <[email protected]>

diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 6cd0f6b..849543f1 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -267,7 +267,7 @@ struct mtd_info {
*/
unsigned int bitflip_threshold;

- // Kernel-only stuff starts here.
+ /* Kernel-only stuff starts here. */
const char *name;
int index;


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments:
(No filename) (575.00 B)
 signature.asc (181.00 B)
Digital signature Download all attachments

2017-09-23 21:10:30

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h

On 09/23/2017 10:13 PM, Pavel Machek wrote:
> C++ comments look wrong in kernel tree. Fix one.

AFAIR they are now (sadly) accepted, but this patch works for me.
Would be nice if trivial could pick it.

> Signed-off-by: Pavel Machek <[email protected]>
>
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 6cd0f6b..849543f1 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -267,7 +267,7 @@ struct mtd_info {
> */
> unsigned int bitflip_threshold;
>
> - // Kernel-only stuff starts here.
> + /* Kernel-only stuff starts here. */
> const char *name;
> int index;
>
>


--
Best regards,
Marek Vasut

2017-09-24 08:20:10

by Boris Brezillon

[permalink] [raw]
Subject: Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h

On Sat, 23 Sep 2017 23:10:26 +0200
Marek Vasut <[email protected]> wrote:

> On 09/23/2017 10:13 PM, Pavel Machek wrote:
> > C++ comments look wrong in kernel tree. Fix one.
>
> AFAIR they are now (sadly) accepted, but this patch works for me.

Works for me too. Here is my

Acked-by: Boris Brezillon <[email protected]>

> Would be nice if trivial could pick it.

Hm, I'd recommend not doing that, otherwise we might end up with a
conflict if a patch modify something in this area.

>
> > Signed-off-by: Pavel Machek <[email protected]>
> >
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 6cd0f6b..849543f1 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -267,7 +267,7 @@ struct mtd_info {
> > */
> > unsigned int bitflip_threshold;
> >
> > - // Kernel-only stuff starts here.
> > + /* Kernel-only stuff starts here. */
> > const char *name;
> > int index;
> >
> >
>
>

2017-09-24 08:23:04

by Richard Weinberger

[permalink] [raw]
Subject: Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h

Am Sonntag, 24. September 2017, 10:20:06 CEST schrieb Boris Brezillon:
> On Sat, 23 Sep 2017 23:10:26 +0200
>
> Marek Vasut <[email protected]> wrote:
> > On 09/23/2017 10:13 PM, Pavel Machek wrote:
> > > C++ comments look wrong in kernel tree. Fix one.
> >
> > AFAIR they are now (sadly) accepted, but this patch works for me.
>
> Works for me too. Here is my
>
> Acked-by: Boris Brezillon <[email protected]>
>
> > Would be nice if trivial could pick it.
>
> Hm, I'd recommend not doing that, otherwise we might end up with a
> conflict if a patch modify something in this area.

Let's carry it via MTD.
BTW: Shouldn't it be s/kernel/comment/ in the subject line?

Thanks,
//richard