2020-04-02 06:53:20

by Li Zhijian

Subject: [PATCH] selftests:mptcp: fix empty optstring

From: Li Zhijian <[email protected]>

Signed-off-by: Li Zhijian <[email protected]>
---
tools/testing/selftests/net/mptcp/pm_netlink.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index 9172746b6cf0..8c7998c64d9e 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -8,8 +8,7 @@ usage() {
echo "Usage: $0 [ -h ]"
}

-
-while getopts "$optstring" option;do
+while getopts "h" option;do
case "$option" in
"h")
usage $0
--
2.17.1

2020-04-02 07:22:25

by Matthieu Baerts

Subject: Re: [PATCH] selftests:mptcp: fix empty optstring

On 02/04/2020 08:52, Li Zhijian wrote:
> From: Li Zhijian <[email protected]>
>
> Signed-off-by: Li Zhijian <[email protected]>

LGTM, thanks Li!

Reviewed-by: Matthieu Baerts <[email protected]>

2020-05-11 04:53:21

by Li Zhijian

Subject: Re: [PATCH] selftests:mptcp: fix empty optstring

ping


On 4/2/20 2:52 PM, Li Zhijian wrote:
> From: Li Zhijian <[email protected]>
>
> Signed-off-by: Li Zhijian <[email protected]>
> ---
> tools/testing/selftests/net/mptcp/pm_netlink.sh | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
> index 9172746b6cf0..8c7998c64d9e 100755
> --- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
> +++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
> @@ -8,8 +8,7 @@ usage() {
> echo "Usage: $0 [ -h ]"
> }
>
> -
> -while getopts "$optstring" option;do
> +while getopts "h" option;do
> case "$option" in
> "h")
> usage $0

2020-05-22 15:02:55

by Shuah Khan

Subject: Re: [PATCH] selftests:mptcp: fix empty optstring

On 5/10/20 10:47 PM, Li Zhijian wrote:
> ping
>
>
> On 4/2/20 2:52 PM, Li Zhijian wrote:
>> From: Li Zhijian <[email protected]>
>>
>> Signed-off-by: Li Zhijian <[email protected]>
>> ---
>>   tools/testing/selftests/net/mptcp/pm_netlink.sh | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh
>> b/tools/testing/selftests/net/mptcp/pm_netlink.sh
>> index 9172746b6cf0..8c7998c64d9e 100755
>> --- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
>> +++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
>> @@ -8,8 +8,7 @@ usage() {
>>       echo "Usage: $0 [ -h ]"
>>   }
>> -
>> -while getopts "$optstring" option;do
>> +while getopts "h" option;do
>>       case "$option" in
>>       "h")
>>           usage $0
>
>
>
>

Li Zhijian,

You are missing netdev and net maintainer.
Adding netdev and Dave M.

net tests go through net tree and need review/Ack from Dave M.

Dave! Please review and let me know if you want me to take this through
kselftest tree.

thanks,
-- Shuah