2021-12-14 10:17:04

by Shaik Sajida Bhanu

[permalink] [raw]
Subject: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

Add support for winbond W25Q512NW-IM chip.

Signed-off-by: Shaik Sajida Bhanu <[email protected]>
Reviewed-by: Doug Anderson <[email protected]>
---
Changes since V1:
Added space before name of the flash part as suggested by Doug.

Changes since V2:
Updated chip name as w25q512nwm as suggested by Doug.
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 96573f6..42d5800 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation



2021-12-14 11:16:30

by Tudor Ambarus

[permalink] [raw]
Subject: Re: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

On 12/14/21 12:16 PM, Shaik Sajida Bhanu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> Reviewed-by: Doug Anderson <[email protected]>
> ---
> Changes since V1:
> Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
> Updated chip name as w25q512nwm as suggested by Doug.
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 96573f6..42d5800 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },

This does not apply on current spi-nor/next. We've changed how the
flash_info flags are handled. We also require to dump the SPI NOR
sysfs entries under the comment section ---. I'll update the
documentation to add some guidelines on how new flash additions or
flash updates should be proposed. Sometime this week, or maybe
next.

Cheers,
ta

2022-01-21 16:55:45

by Sajida Bhanu (Temp)

[permalink] [raw]
Subject: RE: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

Hi,

Gentle Reminder.

Thanks,
Sajida
-----Original Message-----
From: [email protected] <[email protected]>
Sent: Tuesday, December 14, 2021 4:46 PM
To: Sajida Bhanu (Temp) (QUIC) <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]; Ram Prakash Gupta (QUIC) <[email protected]>; Pradeep Pragallapati (QUIC) <[email protected]>; [email protected]
Subject: Re: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

On 12/14/21 12:16 PM, Shaik Sajida Bhanu wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> Reviewed-by: Doug Anderson <[email protected]>
> ---
> Changes since V1:
> Added space before name of the flash part as suggested by Doug.
>
> Changes since V2:
> Updated chip name as w25q512nwm as suggested by Doug.
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 96573f6..42d5800 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },

This does not apply on current spi-nor/next. We've changed how the flash_info flags are handled. We also require to dump the SPI NOR sysfs entries under the comment section ---. I'll update the documentation to add some guidelines on how new flash additions or flash updates should be proposed. Sometime this week, or maybe next.

Cheers,
ta

2022-01-21 19:40:50

by Michael Walle

[permalink] [raw]
Subject: Re: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

Hi,

Am 2022-01-19 06:34, schrieb Sajida Bhanu (Temp):
> Gentle Reminder.

As Tudor mentioned, you'd need to rebase your patch to the
latest next.

Thanks,
-michael

2022-01-21 21:08:17

by Shaik Sajida Bhanu

[permalink] [raw]
Subject: RE: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

Sure thanks , will rebase on latest and post next patch series.

Thanks,
Sajida
-----Original Message-----
From: Michael Walle <[email protected]>
Sent: Wednesday, January 19, 2022 9:22 PM
To: Sajida Bhanu (Temp) <[email protected]>
Cc: [email protected]; Sajida Bhanu (Temp) (QUIC) <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Ram Prakash Gupta (QUIC) <[email protected]>; Pradeep Pragallapati (QUIC) <[email protected]>; [email protected]
Subject: Re: [PATCH V3] mtd: spi-nor: winbond: Add support for winbond chip

Hi,

Am 2022-01-19 06:34, schrieb Sajida Bhanu (Temp):
> Gentle Reminder.

As Tudor mentioned, you'd need to rebase your patch to the latest next.

Thanks,
-michael