> This patch fixes commit -
> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before sending")'
>
> Above commit adds the query to the request list before ib_nl_snd_msg.
I suggest to improve also this change description.
The query to the request list was added before ib_nl_snd_msg()
by the commit 3ebd2fd0d011 ("…").
> This flag Indicates …
… indicates …
> To handle the case where a response is received before we could set this
> flag, the response handler waits for the flag to be
> set before proceeding with the query.
Please reconsider the word wrapping.
To handle the case where a response is received before we could set
this flag, the response handler waits for the flag to be set
before proceeding with the query.
Would you like to add the tag “Fixes” to the commit message?
Regards,
Markus
Hi Markus,
Thanks for taking the time to review.
On 5/15/20 9:25 AM, Markus Elfring wrote:
>> This patch fixes commit -
>> commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before sending")'
>>
>> Above commit adds the query to the request list before ib_nl_snd_msg.
> I suggest to improve also this change description.
>
> The query to the request list was added before ib_nl_snd_msg()
> by the commit 3ebd2fd0d011 ("…").
Noted, will make this change.
>
>> This flag Indicates …
> … indicates …
Noted.
>
>> To handle the case where a response is received before we could set this
>> flag, the response handler waits for the flag to be
>> set before proceeding with the query.
> Please reconsider the word wrapping.
>
> To handle the case where a response is received before we could set
> this flag, the response handler waits for the flag to be set
> before proceeding with the query.
>
>
> Would you like to add the tag “Fixes” to the commit message?
Noted!
Thanks,
Divya
>
> Regards,
> Markus