2020-03-30 10:01:34

by Ding Xiang

Subject: [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning

Fix a static code checker warning:
drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
warn: passing zero to 'PTR_ERR'

Signed-off-by: Ding Xiang <[email protected]>
---
drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
index 4be49c1..3741420 100644
--- a/drivers/gpu/drm/xen/xen_drm_front.c
+++ b/drivers/gpu/drm/xen/xen_drm_front.c
@@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,

obj = xen_drm_front_gem_create(dev, args->size);
if (IS_ERR_OR_NULL(obj)) {
- ret = PTR_ERR(obj);
+ ret = PTR_ERR_OR_ZERO(obj);
goto fail;
}

--
1.9.1

2020-03-31 14:52:29

by Oleksandr Andrushchenko

Subject: Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning

On 3/30/20 12:59, Ding Xiang wrote:
> Fix a static code checker warning:
> drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
> warn: passing zero to 'PTR_ERR'
>
> Signed-off-by: Ding Xiang <[email protected]>
Reviewed-by: Oleksandr Andrushchenko <[email protected]>
> ---
> drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 4be49c1..3741420 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
>
> obj = xen_drm_front_gem_create(dev, args->size);
> if (IS_ERR_OR_NULL(obj)) {
> - ret = PTR_ERR(obj);
> + ret = PTR_ERR_OR_ZERO(obj);
> goto fail;
> }
>

2020-03-31 15:16:24

by Daniel Vetter

Subject: Re: [Xen-devel] [PATCH] drm/xen: fix passing zero to 'PTR_ERR' warning

On Tue, Mar 31, 2020 at 05:50:10PM +0300, Oleksandr Andrushchenko wrote:
> On 3/30/20 12:59, Ding Xiang wrote:
> > Fix a static code checker warning:
> > drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create()
> > warn: passing zero to 'PTR_ERR'
> >
> > Signed-off-by: Ding Xiang <[email protected]>
> Reviewed-by: Oleksandr Andrushchenko <[email protected]>

merged to drm-misc-next-fixese.
-Daniel

> > ---
> > drivers/gpu/drm/xen/xen_drm_front.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> > index 4be49c1..3741420 100644
> > --- a/drivers/gpu/drm/xen/xen_drm_front.c
> > +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> > @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp,
> > obj = xen_drm_front_gem_create(dev, args->size);
> > if (IS_ERR_OR_NULL(obj)) {
> > - ret = PTR_ERR(obj);
> > + ret = PTR_ERR_OR_ZERO(obj);
> > goto fail;
> > }

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch