2022-09-22 13:47:11

by Liu Shixin

Subject: [PATCH v3 1/8] cgroup/cpuset: use hotplug_memory_notifier() directly

Since patch 316346243be6 has already updated the minimum gcc version to 5.1.
The previous problem mentioned in patch f02c69680088 is not existed. So we
can now revert to use hotplug_memory_notifier() directly rather than
register_hotmemory_notifier().

Signed-off-by: Liu Shixin <[email protected]>
---
kernel/cgroup/cpuset.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index b474289c15b8..0c6db6a4f427 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -3630,11 +3630,6 @@ static int cpuset_track_online_nodes(struct notifier_block *self,
return NOTIFY_OK;
}

-static struct notifier_block cpuset_track_online_nodes_nb = {
- .notifier_call = cpuset_track_online_nodes,
- .priority = 10, /* ??! */
-};
-
/**
* cpuset_init_smp - initialize cpus_allowed
*
@@ -3652,7 +3647,7 @@ void __init cpuset_init_smp(void)
cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask);
top_cpuset.effective_mems = node_states[N_MEMORY];

- register_hotmemory_notifier(&cpuset_track_online_nodes_nb);
+ hotplug_memory_notifier(cpuset_track_online_nodes, 10);

cpuset_migrate_mm_wq = alloc_ordered_workqueue("cpuset_migrate_mm", 0);
BUG_ON(!cpuset_migrate_mm_wq);
--
2.25.1

2022-09-22 18:00:17

by David Hildenbrand

Subject: Re: [PATCH v3 1/8] cgroup/cpuset: use hotplug_memory_notifier() directly

On 22.09.22 16:18, Liu Shixin wrote:
> Since patch 316346243be6 has already updated the minimum gcc version to 5.1.
> The previous problem mentioned in patch f02c69680088 is not existed. So we
> can now revert to use hotplug_memory_notifier() directly rather than
> register_hotmemory_notifier().
>
> Signed-off-by: Liu Shixin <[email protected]>
> ---
> kernel/cgroup/cpuset.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index b474289c15b8..0c6db6a4f427 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3630,11 +3630,6 @@ static int cpuset_track_online_nodes(struct notifier_block *self,
> return NOTIFY_OK;
> }
>
> -static struct notifier_block cpuset_track_online_nodes_nb = {
> - .notifier_call = cpuset_track_online_nodes,
> - .priority = 10, /* ??! */
> -};
> -
> /**
> * cpuset_init_smp - initialize cpus_allowed
> *
> @@ -3652,7 +3647,7 @@ void __init cpuset_init_smp(void)
> cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask);
> top_cpuset.effective_mems = node_states[N_MEMORY];
>
> - register_hotmemory_notifier(&cpuset_track_online_nodes_nb);
> + hotplug_memory_notifier(cpuset_track_online_nodes, 10);
>
> cpuset_migrate_mm_wq = alloc_ordered_workqueue("cpuset_migrate_mm", 0);
> BUG_ON(!cpuset_migrate_mm_wq);


Please don't drop Reviewed-by or Acked-by tags. Otherwise reviewers have
no clue which patch they already reviewed -- and they always have little
time ;)

--
Thanks,

David / dhildenb

2022-09-23 02:43:09

by Liu Shixin

Subject: Re: [PATCH v3 1/8] cgroup/cpuset: use hotplug_memory_notifier() directly

On 2022/9/23 1:56, David Hildenbrand wrote:
> On 22.09.22 16:18, Liu Shixin wrote:
>> Since patch 316346243be6 has already updated the minimum gcc version to 5.1.
>> The previous problem mentioned in patch f02c69680088 is not existed. So we
>> can now revert to use hotplug_memory_notifier() directly rather than
>> register_hotmemory_notifier().
>>
>> Signed-off-by: Liu Shixin <[email protected]>
>> ---
>> kernel/cgroup/cpuset.c | 7 +------
>> 1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
>> index b474289c15b8..0c6db6a4f427 100644
>> --- a/kernel/cgroup/cpuset.c
>> +++ b/kernel/cgroup/cpuset.c
>> @@ -3630,11 +3630,6 @@ static int cpuset_track_online_nodes(struct notifier_block *self,
>> return NOTIFY_OK;
>> }
>> -static struct notifier_block cpuset_track_online_nodes_nb = {
>> - .notifier_call = cpuset_track_online_nodes,
>> - .priority = 10, /* ??! */
>> -};
>> -
>> /**
>> * cpuset_init_smp - initialize cpus_allowed
>> *
>> @@ -3652,7 +3647,7 @@ void __init cpuset_init_smp(void)
>> cpumask_copy(top_cpuset.effective_cpus, cpu_active_mask);
>> top_cpuset.effective_mems = node_states[N_MEMORY];
>> - register_hotmemory_notifier(&cpuset_track_online_nodes_nb);
>> + hotplug_memory_notifier(cpuset_track_online_nodes, 10);
>> cpuset_migrate_mm_wq = alloc_ordered_workqueue("cpuset_migrate_mm", 0);
>> BUG_ON(!cpuset_migrate_mm_wq);
>
>
> Please don't drop Reviewed-by or Acked-by tags. Otherwise reviewers have no clue which patch they already reviewed -- and they always have little time ;)
>
Thanks for your reminder, I'll keep it in mind.