2022-08-12 12:13:17

by Saba Kareem, Syed

[permalink] [raw]
Subject: [PATCH 05/13] ASoC: amd: add acp6.2 pdm platform driver

PDM platform driver binds to the platform device created by
ACP6.2 PCI device. PDM driver registers ALSA DMA and CPU DAI
components with ASoC framework.

Signed-off-by: Syed Saba Kareem <[email protected]>
---
sound/soc/amd/ps/acp62.h | 5 +++
sound/soc/amd/ps/ps-pdm-dma.c | 82 +++++++++++++++++++++++++++++++++++
2 files changed, 87 insertions(+)
create mode 100644 sound/soc/amd/ps/ps-pdm-dma.c

diff --git a/sound/soc/amd/ps/acp62.h b/sound/soc/amd/ps/acp62.h
index ab56e1f8c31b..7636bfeb8a8a 100644
--- a/sound/soc/amd/ps/acp62.h
+++ b/sound/soc/amd/ps/acp62.h
@@ -45,6 +45,11 @@ enum acp_config {
ACP_CONFIG_15,
};

+struct pdm_dev_data {
+ void __iomem *acp62_base;
+ struct snd_pcm_substream *capture_stream;
+};
+
static inline u32 acp62_readl(void __iomem *base_addr)
{
return readl(base_addr - ACP62_PHY_BASE_ADDRESS);
diff --git a/sound/soc/amd/ps/ps-pdm-dma.c b/sound/soc/amd/ps/ps-pdm-dma.c
new file mode 100644
index 000000000000..bca2ac3e81f5
--- /dev/null
+++ b/sound/soc/amd/ps/ps-pdm-dma.c
@@ -0,0 +1,82 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * AMD ALSA SoC Pink Sardine PDM Driver
+ *
+ * Copyright 2022 Advanced Micro Devices, Inc.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+
+#include "acp62.h"
+
+#define DRV_NAME "acp_ps_pdm_dma"
+
+static struct snd_soc_dai_driver acp62_pdm_dai_driver = {
+ .name = "acp_ps_pdm_dma.0",
+ .capture = {
+ .rates = SNDRV_PCM_RATE_48000,
+ .formats = SNDRV_PCM_FMTBIT_S32_LE,
+ .channels_min = 2,
+ .channels_max = 2,
+ .rate_min = 48000,
+ .rate_max = 48000,
+ },
+};
+
+static const struct snd_soc_component_driver acp62_pdm_component = {
+ .name = DRV_NAME,
+};
+
+static int acp62_pdm_audio_probe(struct platform_device *pdev)
+{
+ struct resource *res;
+ struct pdm_dev_data *adata;
+ int status;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res) {
+ dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
+ return -ENODEV;
+ }
+
+ adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
+ if (!adata)
+ return -ENOMEM;
+
+ adata->acp62_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+ if (!adata->acp62_base)
+ return -ENOMEM;
+
+ adata->capture_stream = NULL;
+
+ dev_set_drvdata(&pdev->dev, adata);
+ status = devm_snd_soc_register_component(&pdev->dev,
+ &acp62_pdm_component,
+ &acp62_pdm_dai_driver, 1);
+ if (status) {
+ dev_err(&pdev->dev, "Fail to register acp pdm dai\n");
+
+ return -ENODEV;
+ }
+ return 0;
+}
+
+static struct platform_driver acp62_pdm_dma_driver = {
+ .probe = acp62_pdm_audio_probe,
+ .driver = {
+ .name = "acp_ps_pdm_dma",
+ },
+};
+
+module_platform_driver(acp62_pdm_dma_driver);
+
+MODULE_AUTHOR("[email protected]");
+MODULE_DESCRIPTION("AMD PHEONIX PDM Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:" DRV_NAME);
--
2.25.1


2022-08-12 14:44:35

by Amadeusz Sławiński

[permalink] [raw]
Subject: Re: [PATCH 05/13] ASoC: amd: add acp6.2 pdm platform driver

On 8/12/2022 2:07 PM, Syed Saba kareem wrote:
> PDM platform driver binds to the platform device created by
> ACP6.2 PCI device. PDM driver registers ALSA DMA and CPU DAI
> components with ASoC framework.
>
> Signed-off-by: Syed Saba Kareem <[email protected]>
> ---

...

> +
> +module_platform_driver(acp62_pdm_dma_driver);
> +
> +MODULE_AUTHOR("[email protected]");
> +MODULE_DESCRIPTION("AMD PHEONIX PDM Driver");

phoenix is usually written with "oe", so just making sure if above is
not a typo?

> +MODULE_LICENSE("GPL v2");
> +MODULE_ALIAS("platform:" DRV_NAME);

2022-08-16 09:24:48

by syed saba kareem

[permalink] [raw]
Subject: Re: [PATCH 05/13] ASoC: amd: add acp6.2 pdm platform driver


On 8/12/22 19:50, Amadeusz Sławiński wrote:
> [CAUTION: External Email]
>
> On 8/12/2022 2:07 PM, Syed Saba kareem wrote:
>> PDM platform driver binds to the platform device created by
>> ACP6.2 PCI device. PDM driver registers ALSA DMA and CPU DAI
>> components with ASoC framework.
>>
>> Signed-off-by: Syed Saba Kareem <[email protected]>
>> ---
>
> ...
>
>> +
>> +module_platform_driver(acp62_pdm_dma_driver);
>> +
>> +MODULE_AUTHOR("[email protected]");
>> +MODULE_DESCRIPTION("AMD PHEONIX PDM Driver");
>
> phoenix is usually written with "oe", so just making sure if above is
> not a typo?
>
It is a typo mistake will correct it.
>> +MODULE_LICENSE("GPL v2");
>> +MODULE_ALIAS("platform:" DRV_NAME);
>