2023-05-22 07:36:51

by Mukesh Ojha

[permalink] [raw]
Subject: Re: [PATCH] sched: deadline: Remove unnecessary ‘NULL’ values from dl_task_offline_migratio n



On 5/24/2023 5:11 AM, Li zeming wrote:
> later_rq is assigned first, so it does not need to initialize the
> assignment.
>
> Signed-off-by: Li zeming <[email protected]>
> ---
> kernel/sched/deadline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 5a9a4b81c972..d823e608c7f0 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -667,7 +667,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq);
>
> static struct rq *dl_task_offline_migration(struct rq *rq, struct task_struct *p)
> {
> - struct rq *later_rq = NULL;
> + struct rq *later_rq;
> struct dl_bw *dl_b;
>
> later_rq = find_lock_later_rq(p, rq);

Acked-by: Mukesh Ojha <[email protected]>

-- Mukesh