2017-07-13 11:22:47

by Kefeng Wang

Subject: [PATCH] nbd: kill unused ret in recv_work

No need to return value in queue work, kill ret variable.

Signed-off-by: Kefeng Wang <[email protected]>
---
drivers/block/nbd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index dea7d85..87a0a29 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -626,7 +626,6 @@ static void recv_work(struct work_struct *work)
struct nbd_device *nbd = args->nbd;
struct nbd_config *config = nbd->config;
struct nbd_cmd *cmd;
- int ret = 0;

while (1) {
cmd = nbd_read_stat(nbd, args->index);
@@ -636,7 +635,6 @@ static void recv_work(struct work_struct *work)
mutex_lock(&nsock->tx_lock);
nbd_mark_nsock_dead(nbd, nsock, 1);
mutex_unlock(&nsock->tx_lock);
- ret = PTR_ERR(cmd);
break;
}

--
1.8.3.1

2017-07-13 14:03:53

by Jens Axboe

Subject: Re: [PATCH] nbd: kill unused ret in recv_work

On 07/13/2017 05:20 AM, Kefeng Wang wrote:
> No need to return value in queue work, kill ret variable.

Applied, thanks.

--
Jens Axboe