2021-08-16 22:07:11

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the net-next tree

Hi all,

In commit

175e66924719 ("net: bridge: mcast: account for ipv6 size when dumping querier state")

Fixes tag

Fixes: 5e924fe6ccfd ("net: bridge: mcast: dump ipv6 querier state")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes: 85b410821174 ("net: bridge: mcast: dump ipv6 querier state")

In commit

cdda378bd8d9 ("net: bridge: mcast: drop sizeof for nest attribute's zero size")

Fixes tag

Fixes: 606433fe3e11 ("net: bridge: mcast: dump ipv4 querier state")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes: c7fa1d9b1fb1 ("net: bridge: mcast: dump ipv4 querier state")

In commit

0f0c4f1b72e0 ("samples: pktgen: add missing IPv6 option to pktgen scripts")

Fixes tag

Fixes: 0f06a6787e05 ("samples: Add an IPv6 "-6" option to the pktgen scripts")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Also, please keep all the commit message tags together at the end of
the commit message.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-08-17 07:56:06

by Nikolay Aleksandrov

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the net-next tree

On 17/08/2021 01:04, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 175e66924719 ("net: bridge: mcast: account for ipv6 size when dumping querier state")
>
> Fixes tag
>
> Fixes: 5e924fe6ccfd ("net: bridge: mcast: dump ipv6 querier state")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 85b410821174 ("net: bridge: mcast: dump ipv6 querier state")
>
> In commit
>
> cdda378bd8d9 ("net: bridge: mcast: drop sizeof for nest attribute's zero size")
>
> Fixes tag
>
> Fixes: 606433fe3e11 ("net: bridge: mcast: dump ipv4 querier state")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: c7fa1d9b1fb1 ("net: bridge: mcast: dump ipv4 querier state")

Hi,
Indeed that's what I meant, apologies for the mix up. I was working on my
querier state branch where I made the feature and forgot to rebase it before
doing the fixes on top.

Thanks,
Nik