2019-05-31 22:40:43

by Maciej S. Szmigiero

Subject: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config

Use ARRAY_SIZE for computing element count of cxusub_medion_pin_config
array as suggested by the kbuild test robot.

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Maciej S. Szmigiero <[email protected]>
---
drivers/media/usb/dvb-usb/cxusb-analog.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/media/usb/dvb-usb/cxusb-analog.c b/drivers/media/usb/dvb-usb/cxusb-analog.c
index 9b42ca71c177..51d3cba32b60 100644
--- a/drivers/media/usb/dvb-usb/cxusb-analog.c
+++ b/drivers/media/usb/dvb-usb/cxusb-analog.c
@@ -1622,8 +1622,7 @@ int cxusb_medion_analog_init(struct dvb_usb_device *dvbdev)
/* TODO: setup audio samples insertion */

ret = v4l2_subdev_call(cxdev->cx25840, core, s_io_pin_config,
- sizeof(cxusub_medion_pin_config) /
- sizeof(cxusub_medion_pin_config[0]),
+ ARRAY_SIZE(cxusub_medion_pin_config),
cxusub_medion_pin_config);
if (ret != 0)
dev_warn(&dvbdev->udev->dev,

2019-06-03 12:27:00

by Hans Verkuil

Subject: Re: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config

Hi Maciej,

Thank you for the patch, but I posted a fix for this earlier already:

https://patchwork.linuxtv.org/patch/56441/

I'll drop this patch in favor of the one above. Apologies for not
CC-ing you on my patch, I should have done that.

Regards,

Hans

On 6/1/19 12:37 AM, Maciej S. Szmigiero wrote:
> Use ARRAY_SIZE for computing element count of cxusub_medion_pin_config
> array as suggested by the kbuild test robot.
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Maciej S. Szmigiero <[email protected]>
> ---
> drivers/media/usb/dvb-usb/cxusb-analog.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/cxusb-analog.c b/drivers/media/usb/dvb-usb/cxusb-analog.c
> index 9b42ca71c177..51d3cba32b60 100644
> --- a/drivers/media/usb/dvb-usb/cxusb-analog.c
> +++ b/drivers/media/usb/dvb-usb/cxusb-analog.c
> @@ -1622,8 +1622,7 @@ int cxusb_medion_analog_init(struct dvb_usb_device *dvbdev)
> /* TODO: setup audio samples insertion */
>
> ret = v4l2_subdev_call(cxdev->cx25840, core, s_io_pin_config,
> - sizeof(cxusub_medion_pin_config) /
> - sizeof(cxusub_medion_pin_config[0]),
> + ARRAY_SIZE(cxusub_medion_pin_config),
> cxusub_medion_pin_config);
> if (ret != 0)
> dev_warn(&dvbdev->udev->dev,
>

2019-06-03 17:02:55

by Maciej S. Szmigiero

Subject: Re: [PATCH] media: cxusb-analog: Use ARRAY_SIZE for cxusub_medion_pin_config

Hi Hans,

On 03.06.2019 14:14, Hans Verkuil wrote:
> Hi Maciej,
>
> Thank you for the patch, but I posted a fix for this earlier already:
>
> https://patchwork.linuxtv.org/patch/56441/
>
> I'll drop this patch in favor of the one above. Apologies for not
> CC-ing you on my patch, I should have done that.

All right, thanks for the information.

> Regards,
>
> Hans

Regards,
Maciej