This WiFi AP is based on a MT7621 SoC with 128MiB RAM, 128MiB NAND,
a MT7603 2.4GHz WiFi and a MT7663 5GHz WiFi chips integrated on the board,
connected to the main SoC over PCIe.
The GMAC1 on the SoC is connected to PHY0 on the GSW and can be used to
improve routing bandwidth.
The device uses NMBM over NAND, which is not currently supported in the
mainline, so NAND node is skipped in this revision.
Signed-off-by: Liviu Dudau <[email protected]>
---
arch/mips/boot/dts/ralink/Makefile | 3 +-
.../dts/ralink/mt7621-tplink-hc220_g5.dts | 126 ++++++++++++++++++
2 files changed, 128 insertions(+), 1 deletion(-)
create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
index 11732b8c8163a..c57a2b40876b4 100644
--- a/arch/mips/boot/dts/ralink/Makefile
+++ b/arch/mips/boot/dts/ralink/Makefile
@@ -8,6 +8,7 @@ dtb-$(CONFIG_DTB_VOCORE2) += vocore2.dtb
dtb-$(CONFIG_SOC_MT7621) += \
mt7621-gnubee-gb-pc1.dtb \
- mt7621-gnubee-gb-pc2.dtb
+ mt7621-gnubee-gb-pc2.dtb \
+ mt7621-tplink-hc220_g5.dtb
obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y))
diff --git a/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
new file mode 100644
index 0000000000000..83d15711907d0
--- /dev/null
+++ b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
@@ -0,0 +1,126 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+/dts-v1/;
+
+#include "mt7621.dtsi"
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+ compatible = "tplink,hc220-g5", "mediatek,mt7621-soc";
+ model = "TP-Link HC220 G5 v1.0";
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x8000000>;
+ };
+
+ chosen {
+ /* bootargs = "earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0 kgdboc=ttyS0,115200 ip=192.168.88.1:192.168.88.2:::hc220:eth1:none kgdbcon console=ttyS0,115200"; */
+ /* bootargs = "console=ttyS0,115200 earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0"; */
+ bootargs = "console=ttyS0,115200 root=/dev/nfs ip=192.168.88.2:192.168.88.5::255.255.255.0:hc220_g5:eth1:none nfsroot=192.168.88.5:/mips,vers=4,sec=sys ro rootwait";
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ key-reset {
+ label = "reset";
+ gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_RESTART>;
+ };
+
+ key-wps {
+ label = "wps";
+ gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_WPS_BUTTON>;
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ red {
+ color = <LED_COLOR_ID_RED>;
+ function = LED_FUNCTION_FAULT;
+ gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
+ };
+
+ green {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_POWER;
+ gpios = <&gpio 14 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-on";
+ };
+
+ blue {
+ color = <LED_COLOR_ID_BLUE>;
+ function = LED_FUNCTION_WPS;
+ gpios = <&gpio 15 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+ resetc: reset-controller {
+ compatible = "ralink,rt2880-reset";
+ #reset-cells = <1>;
+ };
+
+ mtd {
+ compatible = "mediatek,mt7622-nfc";
+ };
+};
+
+&i2c {
+ status = "okay";
+};
+
+&pcie {
+ status = "okay";
+};
+
+&spi0 {
+ status = "okay";
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <50000000>;
+ };
+};
+
+/* gmac1 connected to MT7530's phy0 */
+&gmac1 {
+ status = "okay";
+ phy-handle = <ðphy0>;
+};
+
+&mdio {
+ /* MT7530's phy0 */
+ ethphy0: ethernet-phy@0 {
+ reg = <0>;
+ phy-mode = "rgmii";
+ };
+};
+
+&switch0 {
+ /* #gpio-cells = <2>;
+ gpio-controller; */
+
+ ports {
+ /* phy0 is muxed to gmac1 */
+ /delete-node/ port@0;
+
+ port@1 {
+ status = "okay";
+ label = "lan1";
+ };
+
+ port@2 {
+ status = "okay";
+ label = "wan";
+ };
+ };
+};
--
2.40.0
On 9.05.2023 22:01, Liviu Dudau wrote:
> This WiFi AP is based on a MT7621 SoC with 128MiB RAM, 128MiB NAND,
> a MT7603 2.4GHz WiFi and a MT7663 5GHz WiFi chips integrated on the board,
> connected to the main SoC over PCIe.
>
> The GMAC1 on the SoC is connected to PHY0 on the GSW and can be used to
> improve routing bandwidth.
>
> The device uses NMBM over NAND, which is not currently supported in the
> mainline, so NAND node is skipped in this revision.
>
> Signed-off-by: Liviu Dudau <[email protected]>
This is great to see. I'm going to mainline all the MT7621 devicetrees
on OpenWrt at some point, this is a good step for this.
> ---
> arch/mips/boot/dts/ralink/Makefile | 3 +-
> .../dts/ralink/mt7621-tplink-hc220_g5.dts | 126 ++++++++++++++++++
> 2 files changed, 128 insertions(+), 1 deletion(-)
> create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
>
> diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
> index 11732b8c8163a..c57a2b40876b4 100644
> --- a/arch/mips/boot/dts/ralink/Makefile
> +++ b/arch/mips/boot/dts/ralink/Makefile
> @@ -8,6 +8,7 @@ dtb-$(CONFIG_DTB_VOCORE2) += vocore2.dtb
>
> dtb-$(CONFIG_SOC_MT7621) += \
> mt7621-gnubee-gb-pc1.dtb \
> - mt7621-gnubee-gb-pc2.dtb
> + mt7621-gnubee-gb-pc2.dtb \
> + mt7621-tplink-hc220_g5.dtb
>
> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y))
> diff --git a/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
> new file mode 100644
> index 0000000000000..83d15711907d0
> --- /dev/null
> +++ b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
> @@ -0,0 +1,126 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +/dts-v1/;
> +
> +#include "mt7621.dtsi"
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +
> +/ {
> + compatible = "tplink,hc220-g5", "mediatek,mt7621-soc";
tplink,hc220-g5-v1 should fit better. Also please make another patch to
add the compatible string under Boards with Mediatek/Ralink MT7621 SoC
on Documentation/devicetree/bindings/mips/ralink.yaml.
> + model = "TP-Link HC220 G5 v1.0";
"TP-Link HC220 G5 v1" should be enough.
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x0 0x0 0x8000000>;
> + };
> +
> + chosen {
> + /* bootargs = "earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0 kgdboc=ttyS0,115200 ip=192.168.88.1:192.168.88.2:::hc220:eth1:none kgdbcon console=ttyS0,115200"; */
> + /* bootargs = "console=ttyS0,115200 earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0"; */
> + bootargs = "console=ttyS0,115200 root=/dev/nfs ip=192.168.88.2:192.168.88.5::255.255.255.0:hc220_g5:eth1:none nfsroot=192.168.88.5:/mips,vers=4,sec=sys ro rootwait";
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + key-reset {
> + label = "reset";
> + gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_RESTART>;
> + };
> +
> + key-wps {
> + label = "wps";
> + gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_WPS_BUTTON>;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + red {
> + color = <LED_COLOR_ID_RED>;
> + function = LED_FUNCTION_FAULT;
> + gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
> + };
> +
> + green {
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_POWER;
> + gpios = <&gpio 14 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + };
> +
> + blue {
> + color = <LED_COLOR_ID_BLUE>;
> + function = LED_FUNCTION_WPS;
> + gpios = <&gpio 15 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +
> + resetc: reset-controller {
> + compatible = "ralink,rt2880-reset";
> + #reset-cells = <1>;
> + };
> +
> + mtd {
> + compatible = "mediatek,mt7622-nfc";
> + };
> +};
> +
> +&i2c {
> + status = "okay";
> +};
> +
> +&pcie {
> + status = "okay";
> +};
> +
> +&spi0 {
> + status = "okay";
> +
> + flash@0 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <50000000>;
> + };
> +};
> +
> +/* gmac1 connected to MT7530's phy0 */
> +&gmac1 {
> + status = "okay";
> + phy-handle = <ðphy0>;
> +};
> +
> +&mdio {
> + /* MT7530's phy0 */
> + ethphy0: ethernet-phy@0 {
> + reg = <0>;
> + phy-mode = "rgmii";
> + };
> +};
These are partially wrong, check the mt7621.dtsi on mainline. Or better,
don't do it. I'm very close to adding support for changing the DSA
conduit for user ports. I suggest you just add port@0 to the DSA switch
node below.
> +
> +&switch0 {
> + /* #gpio-cells = <2>;
> + gpio-controller; */
> +
> + ports {
> + /* phy0 is muxed to gmac1 */
> + /delete-node/ port@0;
> +
> + port@1 {
> + status = "okay";
> + label = "lan1";
> + };
> +
> + port@2 {
> + status = "okay";
> + label = "wan";
> + };
> + };
> +};
Arınç
Please remove the dot from the subject. Also check the patches with
scripts/checkpatch.pl. At least one of them has got 80 columns on a
line, the limit is 75.
Arınç
On 9.05.2023 22:01, Liviu Dudau wrote:
> This WiFi AP is based on a MT7621 SoC with 128MiB RAM, 128MiB NAND,
> a MT7603 2.4GHz WiFi and a MT7663 5GHz WiFi chips integrated on the board,
> connected to the main SoC over PCIe.
>
> The GMAC1 on the SoC is connected to PHY0 on the GSW and can be used to
> improve routing bandwidth.
>
> The device uses NMBM over NAND, which is not currently supported in the
> mainline, so NAND node is skipped in this revision.
>
> Signed-off-by: Liviu Dudau <[email protected]>
> ---
> arch/mips/boot/dts/ralink/Makefile | 3 +-
> .../dts/ralink/mt7621-tplink-hc220_g5.dts | 126 ++++++++++++++++++
> 2 files changed, 128 insertions(+), 1 deletion(-)
> create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
>
> diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
> index 11732b8c8163a..c57a2b40876b4 100644
> --- a/arch/mips/boot/dts/ralink/Makefile
> +++ b/arch/mips/boot/dts/ralink/Makefile
> @@ -8,6 +8,7 @@ dtb-$(CONFIG_DTB_VOCORE2) += vocore2.dtb
>
> dtb-$(CONFIG_SOC_MT7621) += \
> mt7621-gnubee-gb-pc1.dtb \
> - mt7621-gnubee-gb-pc2.dtb
> + mt7621-gnubee-gb-pc2.dtb \
> + mt7621-tplink-hc220_g5.dtb
No underscores please. And add v1 on the filename.
Arınç
On Thu, May 11, 2023 at 03:41:30PM +0200, Arınç ÜNAL wrote:
> On 9.05.2023 22:01, Liviu Dudau wrote:
> > This WiFi AP is based on a MT7621 SoC with 128MiB RAM, 128MiB NAND,
> > a MT7603 2.4GHz WiFi and a MT7663 5GHz WiFi chips integrated on the board,
> > connected to the main SoC over PCIe.
> >
> > The GMAC1 on the SoC is connected to PHY0 on the GSW and can be used to
> > improve routing bandwidth.
> >
> > The device uses NMBM over NAND, which is not currently supported in the
> > mainline, so NAND node is skipped in this revision.
> >
> > Signed-off-by: Liviu Dudau <[email protected]>
>
> This is great to see. I'm going to mainline all the MT7621 devicetrees on
> OpenWrt at some point, this is a good step for this.
AFAIK this board is not supported by OpenWrt at all. So the flow will be
the other way this time :)
>
> > ---
> > arch/mips/boot/dts/ralink/Makefile | 3 +-
> > .../dts/ralink/mt7621-tplink-hc220_g5.dts | 126 ++++++++++++++++++
> > 2 files changed, 128 insertions(+), 1 deletion(-)
> > create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
> >
> > diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
> > index 11732b8c8163a..c57a2b40876b4 100644
> > --- a/arch/mips/boot/dts/ralink/Makefile
> > +++ b/arch/mips/boot/dts/ralink/Makefile
> > @@ -8,6 +8,7 @@ dtb-$(CONFIG_DTB_VOCORE2) += vocore2.dtb
> > dtb-$(CONFIG_SOC_MT7621) += \
> > mt7621-gnubee-gb-pc1.dtb \
> > - mt7621-gnubee-gb-pc2.dtb
> > + mt7621-gnubee-gb-pc2.dtb \
> > + mt7621-tplink-hc220_g5.dtb
> > obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y))
> > diff --git a/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
> > new file mode 100644
> > index 0000000000000..83d15711907d0
> > --- /dev/null
> > +++ b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
> > @@ -0,0 +1,126 @@
> > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +/dts-v1/;
> > +
> > +#include "mt7621.dtsi"
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/leds/common.h>
> > +
> > +/ {
> > + compatible = "tplink,hc220-g5", "mediatek,mt7621-soc";
>
> tplink,hc220-g5-v1 should fit better. Also please make another patch to add
> the compatible string under Boards with Mediatek/Ralink MT7621 SoC on
> Documentation/devicetree/bindings/mips/ralink.yaml.
Will do another patch with the documentation update. I will also send a v2
incorporating all your review comments, thanks for taking the time!
Regarding the full name: I'm quite tempted to drop the v1(.0) entirely as I'm
not really sure that TP-Link will release another board. Doing a search now
I fail to find on any TP-Link results the mention of the version.
>
> > + model = "TP-Link HC220 G5 v1.0";
>
> "TP-Link HC220 G5 v1" should be enough.
>
> > +
> > + memory@0 {
> > + device_type = "memory";
> > + reg = <0x0 0x0 0x0 0x8000000>;
> > + };
> > +
> > + chosen {
> > + /* bootargs = "earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0 kgdboc=ttyS0,115200 ip=192.168.88.1:192.168.88.2:::hc220:eth1:none kgdbcon console=ttyS0,115200"; */
> > + /* bootargs = "console=ttyS0,115200 earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0"; */
> > + bootargs = "console=ttyS0,115200 root=/dev/nfs ip=192.168.88.2:192.168.88.5::255.255.255.0:hc220_g5:eth1:none nfsroot=192.168.88.5:/mips,vers=4,sec=sys ro rootwait";
> > + };
> > +
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > +
> > + key-reset {
> > + label = "reset";
> > + gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
> > + linux,code = <KEY_RESTART>;
> > + };
> > +
> > + key-wps {
> > + label = "wps";
> > + gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
> > + linux,code = <KEY_WPS_BUTTON>;
> > + };
> > + };
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > +
> > + red {
> > + color = <LED_COLOR_ID_RED>;
> > + function = LED_FUNCTION_FAULT;
> > + gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
> > + };
> > +
> > + green {
> > + color = <LED_COLOR_ID_GREEN>;
> > + function = LED_FUNCTION_POWER;
> > + gpios = <&gpio 14 GPIO_ACTIVE_HIGH>;
> > + linux,default-trigger = "default-on";
> > + };
> > +
> > + blue {
> > + color = <LED_COLOR_ID_BLUE>;
> > + function = LED_FUNCTION_WPS;
> > + gpios = <&gpio 15 GPIO_ACTIVE_HIGH>;
> > + };
> > + };
> > +
> > + resetc: reset-controller {
> > + compatible = "ralink,rt2880-reset";
> > + #reset-cells = <1>;
> > + };
> > +
> > + mtd {
> > + compatible = "mediatek,mt7622-nfc";
> > + };
> > +};
> > +
> > +&i2c {
> > + status = "okay";
> > +};
> > +
> > +&pcie {
> > + status = "okay";
> > +};
> > +
> > +&spi0 {
> > + status = "okay";
> > +
> > + flash@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + reg = <0>;
> > + spi-max-frequency = <50000000>;
> > + };
> > +};
> > +
> > +/* gmac1 connected to MT7530's phy0 */
> > +&gmac1 {
> > + status = "okay";
> > + phy-handle = <ðphy0>;
> > +};
> > +
> > +&mdio {
> > + /* MT7530's phy0 */
> > + ethphy0: ethernet-phy@0 {
> > + reg = <0>;
> > + phy-mode = "rgmii";
> > + };
> > +};
>
> These are partially wrong, check the mt7621.dtsi on mainline. Or better,
> don't do it. I'm very close to adding support for changing the DSA conduit
> for user ports. I suggest you just add port@0 to the DSA switch node below.
>
I don't claim to be an expert on DSA or how MT7530 connects to MT7621, however
I do remember trying various combinations and failing to make all the ports
work. I blame TP-Link on having a weird setup, but to be sure I will try your
suggestion if I manage to understand exactly where I'm "partially wrong" :)
I will also try to remove the node to see what I get and report back here.
Best regards,
Liviu
> > +
> > +&switch0 {
> > + /* #gpio-cells = <2>;
> > + gpio-controller; */
> > +
> > + ports {
> > + /* phy0 is muxed to gmac1 */
> > + /delete-node/ port@0;
> > +
> > + port@1 {
> > + status = "okay";
> > + label = "lan1";
> > + };
> > +
> > + port@2 {
> > + status = "okay";
> > + label = "wan";
> > + };
> > + };
> > +};
>
> Arınç
--
Everyone who uses computers frequently has had, from time to time,
a mad desire to attack the precocious abacus with an axe.
-- John D. Clark, Ignition!
On 11.05.2023 18:03, Liviu Dudau wrote:
> On Thu, May 11, 2023 at 03:41:30PM +0200, Arınç ÜNAL wrote:
>> On 9.05.2023 22:01, Liviu Dudau wrote:
>>> This WiFi AP is based on a MT7621 SoC with 128MiB RAM, 128MiB NAND,
>>> a MT7603 2.4GHz WiFi and a MT7663 5GHz WiFi chips integrated on the board,
>>> connected to the main SoC over PCIe.
>>>
>>> The GMAC1 on the SoC is connected to PHY0 on the GSW and can be used to
>>> improve routing bandwidth.
>>>
>>> The device uses NMBM over NAND, which is not currently supported in the
>>> mainline, so NAND node is skipped in this revision.
>>>
>>> Signed-off-by: Liviu Dudau <[email protected]>
>>
>> This is great to see. I'm going to mainline all the MT7621 devicetrees on
>> OpenWrt at some point, this is a good step for this.
>
> AFAIK this board is not supported by OpenWrt at all. So the flow will be
> the other way this time :)
>
>>
>>> ---
>>> arch/mips/boot/dts/ralink/Makefile | 3 +-
>>> .../dts/ralink/mt7621-tplink-hc220_g5.dts | 126 ++++++++++++++++++
>>> 2 files changed, 128 insertions(+), 1 deletion(-)
>>> create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
>>>
>>> diff --git a/arch/mips/boot/dts/ralink/Makefile b/arch/mips/boot/dts/ralink/Makefile
>>> index 11732b8c8163a..c57a2b40876b4 100644
>>> --- a/arch/mips/boot/dts/ralink/Makefile
>>> +++ b/arch/mips/boot/dts/ralink/Makefile
>>> @@ -8,6 +8,7 @@ dtb-$(CONFIG_DTB_VOCORE2) += vocore2.dtb
>>> dtb-$(CONFIG_SOC_MT7621) += \
>>> mt7621-gnubee-gb-pc1.dtb \
>>> - mt7621-gnubee-gb-pc2.dtb
>>> + mt7621-gnubee-gb-pc2.dtb \
>>> + mt7621-tplink-hc220_g5.dtb
>>> obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y))
>>> diff --git a/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
>>> new file mode 100644
>>> index 0000000000000..83d15711907d0
>>> --- /dev/null
>>> +++ b/arch/mips/boot/dts/ralink/mt7621-tplink-hc220_g5.dts
>>> @@ -0,0 +1,126 @@
>>> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +/dts-v1/;
>>> +
>>> +#include "mt7621.dtsi"
>>> +
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +#include <dt-bindings/input/input.h>
>>> +#include <dt-bindings/leds/common.h>
>>> +
>>> +/ {
>>> + compatible = "tplink,hc220-g5", "mediatek,mt7621-soc";
>>
>> tplink,hc220-g5-v1 should fit better. Also please make another patch to add
>> the compatible string under Boards with Mediatek/Ralink MT7621 SoC on
>> Documentation/devicetree/bindings/mips/ralink.yaml.
>
> Will do another patch with the documentation update. I will also send a v2
> incorporating all your review comments, thanks for taking the time!
>
> Regarding the full name: I'm quite tempted to drop the v1(.0) entirely as I'm
> not really sure that TP-Link will release another board. Doing a search now
> I fail to find on any TP-Link results the mention of the version.
What I understand is TP-Link always call their first hardware release v1
as they are notorious for introducing new versions to cut costs as much
as possible. On the downloads website for the product, "v1" is there on
the product name.
https://www.tp-link.com/us/support/download/hc220-g5/
>
>>
>>> + model = "TP-Link HC220 G5 v1.0";
>>
>> "TP-Link HC220 G5 v1" should be enough.
>>
>>> +
>>> + memory@0 {
>>> + device_type = "memory";
>>> + reg = <0x0 0x0 0x0 0x8000000>;
>>> + };
>>> +
>>> + chosen {
>>> + /* bootargs = "earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0 kgdboc=ttyS0,115200 ip=192.168.88.1:192.168.88.2:::hc220:eth1:none kgdbcon console=ttyS0,115200"; */
>>> + /* bootargs = "console=ttyS0,115200 earlycon=uart8260,mmio32,0x1e000c00 root=/dev/ram0"; */
>>> + bootargs = "console=ttyS0,115200 root=/dev/nfs ip=192.168.88.2:192.168.88.5::255.255.255.0:hc220_g5:eth1:none nfsroot=192.168.88.5:/mips,vers=4,sec=sys ro rootwait";
>>> + };
>>> +
>>> + gpio-keys {
>>> + compatible = "gpio-keys";
>>> +
>>> + key-reset {
>>> + label = "reset";
>>> + gpios = <&gpio 8 GPIO_ACTIVE_LOW>;
>>> + linux,code = <KEY_RESTART>;
>>> + };
>>> +
>>> + key-wps {
>>> + label = "wps";
>>> + gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
>>> + linux,code = <KEY_WPS_BUTTON>;
>>> + };
>>> + };
>>> +
>>> + leds {
>>> + compatible = "gpio-leds";
>>> +
>>> + red {
>>> + color = <LED_COLOR_ID_RED>;
>>> + function = LED_FUNCTION_FAULT;
>>> + gpios = <&gpio 13 GPIO_ACTIVE_HIGH>;
>>> + };
>>> +
>>> + green {
>>> + color = <LED_COLOR_ID_GREEN>;
>>> + function = LED_FUNCTION_POWER;
>>> + gpios = <&gpio 14 GPIO_ACTIVE_HIGH>;
>>> + linux,default-trigger = "default-on";
>>> + };
>>> +
>>> + blue {
>>> + color = <LED_COLOR_ID_BLUE>;
>>> + function = LED_FUNCTION_WPS;
>>> + gpios = <&gpio 15 GPIO_ACTIVE_HIGH>;
>>> + };
>>> + };
>>> +
>>> + resetc: reset-controller {
>>> + compatible = "ralink,rt2880-reset";
>>> + #reset-cells = <1>;
>>> + };
>>> +
>>> + mtd {
>>> + compatible = "mediatek,mt7622-nfc";
>>> + };
>>> +};
>>> +
>>> +&i2c {
>>> + status = "okay";
>>> +};
>>> +
>>> +&pcie {
>>> + status = "okay";
>>> +};
>>> +
>>> +&spi0 {
>>> + status = "okay";
>>> +
>>> + flash@0 {
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + compatible = "jedec,spi-nor";
>>> + reg = <0>;
>>> + spi-max-frequency = <50000000>;
>>> + };
>>> +};
>>> +
>>> +/* gmac1 connected to MT7530's phy0 */
>>> +&gmac1 {
>>> + status = "okay";
>>> + phy-handle = <ðphy0>;
>>> +};
>>> +
>>> +&mdio {
>>> + /* MT7530's phy0 */
>>> + ethphy0: ethernet-phy@0 {
>>> + reg = <0>;
>>> + phy-mode = "rgmii";
>>> + };
>>> +};
>>
>> These are partially wrong, check the mt7621.dtsi on mainline. Or better,
>> don't do it. I'm very close to adding support for changing the DSA conduit
>> for user ports. I suggest you just add port@0 to the DSA switch node below.
>>
>
> I don't claim to be an expert on DSA or how MT7530 connects to MT7621, however
> I do remember trying various combinations and failing to make all the ports
> work. I blame TP-Link on having a weird setup, but to be sure I will try your
> suggestion if I manage to understand exactly where I'm "partially wrong" :)
You're not wrong, the bindings are. You must disable fixed-link. The
properties status okay and phy-mode rgmii on ethphy0 is not necessary so
these can be dropped. Take a look at the GB-PC2 bindings, rgmii-rxid is
specific to GB-PC2 so no need to do that:
https://github.com/torvalds/linux/blob/master/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts#L114
If you define the port under the DSA switch node, it should just work.
Arınç
Add device tree and bindings for the TP-Link HC220 G5 v1 wireless AP,
a consumer product from TP-Link based on MT7621.
Changes since v1:
- Changed compatible for the board to "tplink,hc220-g5-v1"
- Updated the DSA switch nodes to better reflect actual usage.
- Disabled the fixed-link in gmac1
- Added device tree bindings in Documentation/
Liviu Dudau (2):
mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board
dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board
.../devicetree/bindings/mips/ralink.yaml | 1 +
arch/mips/boot/dts/ralink/Makefile | 3 +-
.../dts/ralink/mt7621-tplink-hc220-g5-v1.dts | 129 ++++++++++++++++++
3 files changed, 132 insertions(+), 1 deletion(-)
create mode 100644 arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dts
--
2.40.1
Add bindings for the compatible string used for the TP-Link's
HC220 G5 V1 board, a wireless AP based on MT7621.
Signed-off-by: Liviu Dudau <[email protected]>
---
Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml
index 704b5b5951271..53c1f66353770 100644
--- a/Documentation/devicetree/bindings/mips/ralink.yaml
+++ b/Documentation/devicetree/bindings/mips/ralink.yaml
@@ -80,6 +80,7 @@ properties:
- enum:
- gnubee,gb-pc1
- gnubee,gb-pc2
+ - tplink,hc220-g5-v1
- const: mediatek,mt7621-soc
additionalProperties: true
--
2.40.1
Hey,
On Mon, May 29, 2023 at 04:08:33PM +0100, Liviu Dudau wrote:
> Add bindings for the compatible string used for the TP-Link's
> HC220 G5 V1 board, a wireless AP based on MT7621.
>
> Signed-off-by: Liviu Dudau <[email protected]>
Two process things:
- Please run get_maintainer.pl against the current git tree - you seem
to have missed 2 of the 3 dt-bindings maintainers. I don't mind my
omission, but omitting Krzysztof means you're submitting patches based
on a tree that is over a year old.
- Please don't send a v2 in reply to the v1.
> ---
> Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml
> index 704b5b5951271..53c1f66353770 100644
> --- a/Documentation/devicetree/bindings/mips/ralink.yaml
> +++ b/Documentation/devicetree/bindings/mips/ralink.yaml
> @@ -80,6 +80,7 @@ properties:
> - enum:
> - gnubee,gb-pc1
> - gnubee,gb-pc2
> + - tplink,hc220-g5-v1
For the actual change though,
Acked-by: Conor Dooley <[email protected]>
Thanks,
Conor.
> - const: mediatek,mt7621-soc
>
> additionalProperties: true
> --
> 2.40.1
>
On Mon, May 29, 2023 at 10:00:20PM +0100, Conor Dooley wrote:
> Hey,
Hi Conor,
>
> On Mon, May 29, 2023 at 04:08:33PM +0100, Liviu Dudau wrote:
> > Add bindings for the compatible string used for the TP-Link's
> > HC220 G5 V1 board, a wireless AP based on MT7621.
> >
> > Signed-off-by: Liviu Dudau <[email protected]>
>
> Two process things:
> - Please run get_maintainer.pl against the current git tree - you seem
> to have missed 2 of the 3 dt-bindings maintainers. I don't mind my
> omission, but omitting Krzysztof means you're submitting patches based
> on a tree that is over a year old.
Appologies for that, I should have check get_maintainer.pl rather than looking
at the output of git log for the file.
> - Please don't send a v2 in reply to the v1.
Sorry, I'm not sure why that makes any difference. Reason for sending it as a
reply was the fact that last conversation was more than two weeks ago, people
might have forgot the context. This way it's all in one thread.
>
> > ---
> > Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mips/ralink.yaml b/Documentation/devicetree/bindings/mips/ralink.yaml
> > index 704b5b5951271..53c1f66353770 100644
> > --- a/Documentation/devicetree/bindings/mips/ralink.yaml
> > +++ b/Documentation/devicetree/bindings/mips/ralink.yaml
> > @@ -80,6 +80,7 @@ properties:
> > - enum:
> > - gnubee,gb-pc1
> > - gnubee,gb-pc2
> > + - tplink,hc220-g5-v1
>
> For the actual change though,
> Acked-by: Conor Dooley <[email protected]>
Many thanks!
Best regards,
Liviu
>
> Thanks,
> Conor.
>
> > - const: mediatek,mt7621-soc
> >
> > additionalProperties: true
> > --
> > 2.40.1
> >
--
Everyone who uses computers frequently has had, from time to time,
a mad desire to attack the precocious abacus with an axe.
-- John D. Clark, Ignition!
On Mon, May 29, 2023 at 10:53:57PM +0100, Liviu Dudau wrote:
> On Mon, May 29, 2023 at 10:00:20PM +0100, Conor Dooley wrote:
> > Two process things:
> > - Please run get_maintainer.pl against the current git tree - you seem
> > to have missed 2 of the 3 dt-bindings maintainers. I don't mind my
> > omission, but omitting Krzysztof means you're submitting patches based
> > on a tree that is over a year old.
>
> Appologies for that, I should have check get_maintainer.pl rather than looking
> at the output of git log for the file.
Yeah, git log ain't the way to do things ;)
>
> > - Please don't send a v2 in reply to the v1.
>
> Sorry, I'm not sure why that makes any difference. Reason for sending it as a
> reply was the fact that last conversation was more than two weeks ago, people
> might have forgot the context. This way it's all in one thread.
That's fine, just include a link to v1 on lore for anyone that cares
about the context, like so:
https://lore.kernel.org/all/[email protected]/
I knew this mail had been sent today because I noticed at the time that
you'd only CCed Rob but I remembered nothing of the subject line since
I saw it hours ago. Look how far back in my mailbox it ended up because
of being sent as a reply to the v1, and that mailbox only contains
emails from the devicetree list!
4380 May 29 Liviu Dudau (7.6K) │ ┌─>[PATCH v2 1/2] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board
4381 T May 29 Liviu Dudau (5.8K) │ │ ┌─>
4382 sF May 29 To Liviu Dudau (6.8K) │ │ ┌─>
4383 May 29 Liviu Dudau (4.6K) │ ├─>[PATCH v2 2/2] dt-bindings: mips: Add bindings for TP-Link HC220 G5 v1 board
4384 May 29 Liviu Dudau (4.7K) │ ┌─>[PATCH v2 0/2] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board
4385 May 12 Arınç ÜNAL ( 12K) │ ┌─>
4386 May 11 Liviu Dudau ( 10K) │ ┌─>
4387 May 11 Arınç ÜNAL ( 10K) ├─>
4388 May 09 Liviu Dudau (7.8K) [PATCH] mips: dts: ralink: Add support for TP-Link HC220 G5 v1 board.
Some patch application & CI tools apparently also get confused, but I
dunno what those tools are.
Cheers,
Conor.
On Mon, May 29, 2023 at 5:08 PM Liviu Dudau <[email protected]> wrote:
>
> Add bindings for the compatible string used for the TP-Link's
> HC220 G5 V1 board, a wireless AP based on MT7621.
>
> Signed-off-by: Liviu Dudau <[email protected]>
> ---
> Documentation/devicetree/bindings/mips/ralink.yaml | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Sergio Paracuellos <[email protected]>
Thanks,
Sergio Paracuellos