2018-02-22 08:23:13

by Corentin LABBE

Subject: [PATCH 1/2] drm/amd: remove inclusion of non-existing scheduler directory

The scheduler directory was removed via commit 1b1f42d8fde4 ("drm: move amd_gpu_scheduler into common location")
Remove it from include path.

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile
index d6e5b7273853..8408aeeaf6c1 100644
--- a/drivers/gpu/drm/amd/amdgpu/Makefile
+++ b/drivers/gpu/drm/amd/amdgpu/Makefile
@@ -30,7 +30,6 @@ FULL_AMD_DISPLAY_PATH = $(FULL_AMD_PATH)/$(DISPLAY_FOLDER_NAME)
ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \
-I$(FULL_AMD_PATH)/include \
-I$(FULL_AMD_PATH)/amdgpu \
- -I$(FULL_AMD_PATH)/scheduler \
-I$(FULL_AMD_PATH)/powerplay/inc \
-I$(FULL_AMD_PATH)/acp/include \
-I$(FULL_AMD_DISPLAY_PATH) \
--
2.16.1

2018-02-22 08:24:17

by Corentin LABBE

Subject: [PATCH 2/2] drm/amd: Remove inclusion of non-existing include directories

This patch fix the following build warnings:
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o
cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs]
CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o
cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs]
[...]
This warning is shown for each file in amdgpu directory, so it spams a lot.

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/gpu/drm/amd/display/Makefile | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile
index c27c81cdeed3..22c72dffdf98 100644
--- a/drivers/gpu/drm/amd/display/Makefile
+++ b/drivers/gpu/drm/amd/display/Makefile
@@ -26,8 +26,6 @@

AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)

-subdir-ccflags-y += -I$(AMDDALPATH)/ -I$(AMDDALPATH)/include
-
subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/modules/inc
--
2.16.1

2018-02-22 08:28:43

by Christian König

Subject: Re: [PATCH 1/2] drm/amd: remove inclusion of non-existing scheduler directory

Am 22.02.2018 um 09:21 schrieb Corentin Labbe:
> The scheduler directory was removed via commit 1b1f42d8fde4 ("drm: move amd_gpu_scheduler into common location")
> Remove it from include path.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/amd/amdgpu/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/Makefile b/drivers/gpu/drm/amd/amdgpu/Makefile
> index d6e5b7273853..8408aeeaf6c1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Makefile
> +++ b/drivers/gpu/drm/amd/amdgpu/Makefile
> @@ -30,7 +30,6 @@ FULL_AMD_DISPLAY_PATH = $(FULL_AMD_PATH)/$(DISPLAY_FOLDER_NAME)
> ccflags-y := -I$(FULL_AMD_PATH)/include/asic_reg \
> -I$(FULL_AMD_PATH)/include \
> -I$(FULL_AMD_PATH)/amdgpu \
> - -I$(FULL_AMD_PATH)/scheduler \
> -I$(FULL_AMD_PATH)/powerplay/inc \
> -I$(FULL_AMD_PATH)/acp/include \
> -I$(FULL_AMD_DISPLAY_PATH) \

2018-02-22 08:30:14

by Christian König

Subject: Re: [PATCH 2/2] drm/amd: Remove inclusion of non-existing include directories

Am 22.02.2018 um 09:21 schrieb Corentin Labbe:
> This patch fix the following build warnings:
> CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o
> cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
> cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs]
> CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_device.o
> cc1: warning: ../display/: No such file or directory [-Wmissing-include-dirs]
> cc1: warning: ../display/include: No such file or directory [-Wmissing-include-dirs]
> [...]
> This warning is shown for each file in amdgpu directory, so it spams a lot.
>
> Signed-off-by: Corentin Labbe <[email protected]>

Acked-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/amd/display/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile
> index c27c81cdeed3..22c72dffdf98 100644
> --- a/drivers/gpu/drm/amd/display/Makefile
> +++ b/drivers/gpu/drm/amd/display/Makefile
> @@ -26,8 +26,6 @@
>
> AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
>
> -subdir-ccflags-y += -I$(AMDDALPATH)/ -I$(AMDDALPATH)/include
> -
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
> subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/modules/inc