2018-05-07 11:18:00

by Yisheng Xie

Subject: [PATCH] swiotlb: Update the comment of swiotlb

swiotlb use physical address of bounce buffer when do map and unmap,
therefore, related comment should be updated.

Signed-off-by: Yisheng Xie <[email protected]>
---
lib/swiotlb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index fece575..e3d9445 100644
--- a/lib/swiotlb.c
+++ b/lib/swiotlb.c
@@ -593,9 +593,8 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
}

/*
- * Allocates bounce buffer and returns its kernel virtual address.
+ * Allocates bounce buffer and returns its physical address.
*/
-
static phys_addr_t
map_single(struct device *hwdev, phys_addr_t phys, size_t size,
enum dma_data_direction dir, unsigned long attrs)
@@ -614,7 +613,7 @@ phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
}

/*
- * dma_addr is the kernel virtual address of the bounce buffer to unmap.
+ * tlb_addr is the physical address of the bounce buffer to unmap.
*/
void swiotlb_tbl_unmap_single(struct device *hwdev, phys_addr_t tlb_addr,
size_t size, enum dma_data_direction dir,
--
1.7.12.4

2018-05-09 07:35:41

by Christoph Hellwig

Subject: Re: [PATCH] swiotlb: Update the comment of swiotlb

Thanks,

applied to the dma-mapping tree.

2018-05-09 09:13:12

by Yisheng Xie

Subject: Re: [PATCH] swiotlb: Update the comment of swiotlb

Hi Christoph,

On 2018/5/9 15:38, Christoph Hellwig wrote:
> Thanks,
>
> applied to the dma-mapping tree.

Thanks

BTW, should lib/swiotlb.c also add to DMA MAPPING HELPERS, or
add yourself as a maintainer of SWIOTLB SUBSYSTEM ? It will make
get_maintainer.pl get you :)

Thanks
Yisheng
>
> .
>

2018-05-09 11:36:55

by Christoph Hellwig

Subject: Re: [PATCH] swiotlb: Update the comment of swiotlb

On Wed, May 09, 2018 at 05:08:30PM +0800, Yisheng Xie wrote:
> Hi Christoph,
>
> On 2018/5/9 15:38, Christoph Hellwig wrote:
> > Thanks,
> >
> > applied to the dma-mapping tree.
>
> Thanks
>
> BTW, should lib/swiotlb.c also add to DMA MAPPING HELPERS, or
> add yourself as a maintainer of SWIOTLB SUBSYSTEM ? It will make
> get_maintainer.pl get you :)

Konrad is the maintainer, but due to me touching the file a lot
lately I keep merging the patches for now. But anything non-trivial
absolutely requires an Ack from Konrad.

2018-05-09 14:22:04

by Konrad Rzeszutek Wilk

Subject: Re: [PATCH] swiotlb: Update the comment of swiotlb

On Wed, May 09, 2018 at 01:39:57PM +0200, Christoph Hellwig wrote:
> On Wed, May 09, 2018 at 05:08:30PM +0800, Yisheng Xie wrote:
> > Hi Christoph,
> >
> > On 2018/5/9 15:38, Christoph Hellwig wrote:
> > > Thanks,
> > >
> > > applied to the dma-mapping tree.
> >
> > Thanks
> >
> > BTW, should lib/swiotlb.c also add to DMA MAPPING HELPERS, or
> > add yourself as a maintainer of SWIOTLB SUBSYSTEM ? It will make
> > get_maintainer.pl get you :)
>
> Konrad is the maintainer, but due to me touching the file a lot
> lately I keep merging the patches for now. But anything non-trivial
> absolutely requires an Ack from Konrad.

<nods>

Thank you for pulling this in your tree.