2008-12-03 23:54:39

by Rafael J. Wysocki

[permalink] [raw]
Subject: 2.6.28-rc7-git2: Reported regressions from 2.6.27

[NOTES:
* Sorry for the delayed report. Recently, I've been distracted by a number
of regressions on one of my test boxes.
* I haven't managed to follow all of the linked threads this time in
search for fixes, so if you know of any patches fixing the listed bugs,
please let me know.]

This message contains a list of some regressions from 2.6.27, for which there
are no fixes in the mainline I know of. If any of them have been fixed already,
please let me know.

If you know of any other unresolved regressions from 2.6.27, please let me know
either and I'll add them to the list. Also, please let me know if any of the
entries below are invalid.

Each entry from the list will be sent additionally in an automatic reply to
this message with CCs to the people involved in reporting and handling the
issue.


Listed regressions statistics:

Date Total Pending Unresolved
----------------------------------------
2008-12-04 106 29 21
2008-11-22 93 25 15
2008-11-16 89 32 18
2008-11-09 73 40 27
2008-11-02 55 41 29
2008-10-25 26 25 20


Unresolved regressions
----------------------

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12161
Subject : [i915 drm] irq 16: nobody cared with latest git kernels
Submitter : fredi ml <[email protected]>
Date : 2008-12-02 13:26 (2 days old)
References : http://marc.info/?l=linux-kernel&m=122822444615724&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12160
Subject : networking oops after resume from s2ram (2.6.28-rc6)
Submitter : Marcin Slusarz <[email protected]>
Date : 2008-11-28 21:15 (6 days old)
References : http://marc.info/?l=linux-kernel&m=122790701615723&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12159
Subject : 2.6.28-rc6-git1 -- No sound produced from Intel HDA ALSA driver
Submitter : Miles Lane <[email protected]>
Date : 2008-11-27 20:33 (7 days old)
References : http://marc.info/?l=linux-kernel&m=122781805620212&w=4
Handled-By : Takashi Iwai <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12158
Subject : commit b1ee26b freezes system on switching from X to text console
Submitter : Gaudenz Steinlin <[email protected]>
Date : 2008-11-25 19:44 (9 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
References : http://marc.info/?l=linux-kernel&m=122764344231140&w=4
Handled-By : Benjamin Herrenschmidt <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12156
Subject : v2.6.28-rc2: x86_32 relocation regression?
Submitter : Vegard Nossum <[email protected]>
Date : 2008-11-24 21:19 (10 days old)
References : http://marc.info/?l=linux-kernel&m=122756158220966&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12155
Subject : Regression in 2.6.28-rc and 2.6.27-stable - hibernate related
Submitter : Fabio Comolli <[email protected]>
Date : 2008-11-23 16:17 (11 days old)
References : http://marc.info/?l=linux-kernel&m=122745709926361&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12154
Subject : Mmiotrace regression in 2.6.28-rc6
Submitter : Pekka Paalanen <[email protected]>
Date : 2008-11-23 13:41 (11 days old)
References : http://marc.info/?l=linux-kernel&m=122744774317151&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12153
Subject : 2.6.28-rc2: runaway loop modprobe char-major-5-1
Submitter : Meelis Roos <[email protected]>
Date : 2008-10-28 10:15 (37 days old)
References : http://marc.info/?l=linux-kernel&m=122518916014197&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12152
Subject : Huge wakeups number from i1915
Submitter : Yves-Alexis Perez <[email protected]>
Date : 2008-12-02 16:48 (2 days old)
References : http://marc.info/?l=linux-acpi&m=122823656702994&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12120
Subject : [Block layer or SCSI] requests aborted too early during check_partition()
Submitter : Stefan Richter <[email protected]>
Date : 2008-11-29 05:19 (5 days old)


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12100
Subject : resume (S2R) broken by Intel microcode module, on A110L
Submitter : Andreas Mohr <[email protected]>
Date : 2008-11-25 08:48 (9 days old)


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12061
Subject : snd_hda_intel: power_save: sound cracks on powerdown
Submitter : Jens Weibler <[email protected]>
Date : 2008-11-18 12:07 (16 days old)
Handled-By : Takashi Iwai <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12034
Subject : snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)
Submitter : Sergey <[email protected]>
Date : 2008-11-15 04:20 (19 days old)
Handled-By : Takashi Iwai <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12028
Subject : i915 DRM is broken in 2.6.28-rc4
Submitter : Adam Tkac <[email protected]>
Date : 2008-11-14 01:50 (20 days old)


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11970
Subject : gettimeofday return a old time in mmbench
Submitter : alexs <[email protected]>
Date : 2008-11-06 23:57 (28 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99ebcf8285df28f32fd2d1c19a7166e70f00309c
Handled-By : Ingo Molnar <[email protected]>
Thomas Gleixner <[email protected]>
Yanmin Zhang <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11958
Subject : [2.6.27.x =&gt; 2.6.28-rc3] Xorg crash with xf86MapVidMem error
Submitter : Tomasz Chmielewski <[email protected]>
Date : 2008-11-05 05:37 (29 days old)


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject : 2.6.28-rc VC switching with Intel graphics broken
Submitter : Romano Giannetti <[email protected]>
Date : 2008-11-03 12:10 (31 days old)
Handled-By : Jesse Barnes <[email protected]>


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11906
Subject : 2.6.28-rc2 seems to fail at powering down the monitor when it should
Submitter : Gene Heskett <[email protected]>
Date : 2008-10-30 6:39 (35 days old)
References : http://marc.info/?l=linux-kernel&m=122534879721424&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11858
Subject : Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9
Submitter : Tejun Heo <[email protected]>
Date : 2008-10-26 9:46 (39 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=242f9dcb8ba6f68fcd217a119a7648a4f69290e9
References : http://marc.info/?l=linux-kernel&m=122501447326698&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11849
Subject : default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)
Submitter : Kumar Gala <[email protected]>
Date : 2008-10-24 12:45 (41 days old)
References : http://marc.info/?l=linux-kernel&m=122485245924125&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11828
Subject : Linux 2.6.27-git3: no SD card reader
Submitter : J.A. Magallón <[email protected]>
Date : 2008-10-14 0:54 (51 days old)
References : http://marc.info/?l=linux-kernel&m=122394573904699&w=4


Regressions with patches
------------------------

Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12162
Subject : Commit 7cd5b08be3 breaks startup on Toshiba Portege R500
Submitter : Rafael J. Wysocki <[email protected]>
Date : 2008-12-03 22:00 (1 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7cd5b08be3c489df11b559fef210b81133764ad4
References : http://marc.info/?l=linux-kernel&m=122834170321535&w=4
Handled-By : Linus Torvalds <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122834271623218&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12082
Subject : IRQ and MSI allocations broken without sparse irq
Submitter : Jesper Dangaard Brouer <[email protected]>
Date : 2008-11-20 19:48 (14 days old)
References : http://marc.info/?l=linux-kernel&m=122721060501073&w=4
Handled-By : Thomas Gleixner <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122722773824802&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12081
Subject : xen: pin correct PGD on suspend
Submitter : Ian Campbell <[email protected]>
Date : 2008-11-21 10:21 (13 days old)
References : http://marc.info/?l=linux-kernel&m=122726293324850&w=4
Handled-By : Ian Campbell <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122726293324850&w=4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12047
Subject : ACPI toshiba: only register rfkill if bt is enabled
Submitter : Andrey Borzenkov <[email protected]>
Date : 2008-10-28 19:10 (37 days old)
References : http://marc.info/?l=linux-kernel&m=122522113619025&w=2
Handled-By : Frederik Deweerdt <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122526843117478&w=2


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12031
Subject : DRM enabled kernel hangs hard on resume (Intel graphics)
Submitter : Jens Axboe <[email protected]>
Date : 2008-11-12 18:42 (22 days old)
References : http://marc.info/?l=linux-kernel&m=122651551216820&w=4
Handled-By : Jesse Barnes <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=19007&action=view


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12020
Subject : scsi_times_out NULL pointer dereference
Submitter : Bernd Schubert <[email protected]>
Date : 2008-11-13 10:30 (21 days old)
Handled-By : James Bottomley <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=12020#c4


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11925
Subject : cdrom: missing compat ioctls
Submitter : Andreas Schwab <[email protected]>
Date : 2008-10-31 14:02 (34 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=33c2dca4957bd0da3e1af7b96d0758d97e708ef6
Handled-By : Andreas Schwab <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122548923531545&w=2


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11898
Subject : mke2fs hang on AIC79 device.
Submitter : alexs <[email protected]>
Date : 2008-10-30 01:17 (35 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f0c0a376d0fcd4c5579ecf5e95f88387cba85211
Handled-By : James Bottomley <[email protected]>
Mike Christie <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=11898#c28
http://bugzilla.kernel.org/show_bug.cgi?id=11898#c36


For details, please visit the bug entries and follow the links given in
references.

As you can see, there is a Bugzilla entry for each of the listed regressions.
There also is a Bugzilla entry used for tracking the regressions from 2.6.27,
unresolved as well as resolved, at:

http://bugzilla.kernel.org/show_bug.cgi?id=11808

Please let me know if there are any Bugzilla entries that should be added to
the list in there.

Thanks,
Rafael


2008-12-03 23:54:19

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11828] Linux 2.6.27-git3: no SD card reader

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11828
Subject : Linux 2.6.27-git3: no SD card reader
Submitter : J.A. Magallón <[email protected]>
Date : 2008-10-14 0:54 (51 days old)
References : http://marc.info/?l=linux-kernel&m=122394573904699&w=4

2008-12-04 00:02:25

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11849] default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11849
Subject : default IRQ affinity change in v2.6.27 (breaking several SMP PPC based systems)
Submitter : Kumar Gala <[email protected]>
Date : 2008-10-24 12:45 (41 days old)
References : http://marc.info/?l=linux-kernel&m=122485245924125&w=4

2008-12-04 00:02:44

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11906] 2.6.28-rc2 seems to fail at powering down the monitor when it should

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11906
Subject : 2.6.28-rc2 seems to fail at powering down the monitor when it should
Submitter : Gene Heskett <[email protected]>
Date : 2008-10-30 6:39 (35 days old)
References : http://marc.info/?l=linux-kernel&m=122534879721424&w=4

2008-12-04 00:03:13

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11925] cdrom: missing compat ioctls

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11925
Subject : cdrom: missing compat ioctls
Submitter : Andreas Schwab <[email protected]>
Date : 2008-10-31 14:02 (34 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=33c2dca4957bd0da3e1af7b96d0758d97e708ef6
Handled-By : Andreas Schwab <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122548923531545&w=2

2008-12-04 00:03:42

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11898] mke2fs hang on AIC79 device.

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11898
Subject : mke2fs hang on AIC79 device.
Submitter : alexs <[email protected]>
Date : 2008-10-30 01:17 (35 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f0c0a376d0fcd4c5579ecf5e95f88387cba85211
Handled-By : James Bottomley <[email protected]>
Mike Christie <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=11898#c28
http://bugzilla.kernel.org/show_bug.cgi?id=11898#c36

2008-12-04 00:04:05

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11858] Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11858
Subject : Timeout regression introduced by 242f9dcb8ba6f68fcd217a119a7648a4f69290e9
Submitter : Tejun Heo <[email protected]>
Date : 2008-10-26 9:46 (39 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=242f9dcb8ba6f68fcd217a119a7648a4f69290e9
References : http://marc.info/?l=linux-kernel&m=122501447326698&w=4

2008-12-04 00:04:36

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12081] xen: pin correct PGD on suspend

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12081
Subject : xen: pin correct PGD on suspend
Submitter : Ian Campbell <[email protected]>
Date : 2008-11-21 10:21 (13 days old)
References : http://marc.info/?l=linux-kernel&m=122726293324850&w=4
Handled-By : Ian Campbell <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122726293324850&w=4

2008-12-04 00:04:51

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12020] scsi_times_out NULL pointer dereference

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12020
Subject : scsi_times_out NULL pointer dereference
Submitter : Bernd Schubert <[email protected]>
Date : 2008-11-13 10:30 (21 days old)
Handled-By : James Bottomley <[email protected]>
Patch : http://bugzilla.kernel.org/show_bug.cgi?id=12020#c4

2008-12-04 00:05:18

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12047] ACPI toshiba: only register rfkill if bt is enabled

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12047
Subject : ACPI toshiba: only register rfkill if bt is enabled
Submitter : Andrey Borzenkov <[email protected]>
Date : 2008-10-28 19:10 (37 days old)
References : http://marc.info/?l=linux-kernel&m=122522113619025&w=2
Handled-By : Frederik Deweerdt <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122526843117478&w=2

2008-12-04 00:05:46

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12028] i915 DRM is broken in 2.6.28-rc4

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12028
Subject : i915 DRM is broken in 2.6.28-rc4
Submitter : Adam Tkac <[email protected]>
Date : 2008-11-14 01:50 (20 days old)

2008-12-04 00:06:15

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11958] [2.6.27.x =&gt; 2.6.28-rc3] Xorg crash with xf86MapVidMem error

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11958
Subject : [2.6.27.x =&gt; 2.6.28-rc3] Xorg crash with xf86MapVidMem error
Submitter : Tomasz Chmielewski <[email protected]>
Date : 2008-11-05 05:37 (29 days old)

2008-12-04 00:06:52

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12061] snd_hda_intel: power_save: sound cracks on powerdown

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12061
Subject : snd_hda_intel: power_save: sound cracks on powerdown
Submitter : Jens Weibler <[email protected]>
Date : 2008-11-18 12:07 (16 days old)
Handled-By : Takashi Iwai <[email protected]>

2008-12-04 00:06:34

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12031] DRM enabled kernel hangs hard on resume (Intel graphics)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12031
Subject : DRM enabled kernel hangs hard on resume (Intel graphics)
Submitter : Jens Axboe <[email protected]>
Date : 2008-11-12 18:42 (22 days old)
References : http://marc.info/?l=linux-kernel&m=122651551216820&w=4
Handled-By : Jesse Barnes <[email protected]>
Patch : http://bugzilla.kernel.org/attachment.cgi?id=19007&action=view

2008-12-04 00:07:19

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11970] gettimeofday return a old time in mmbench

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11970
Subject : gettimeofday return a old time in mmbench
Submitter : alexs <[email protected]>
Date : 2008-11-06 23:57 (28 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99ebcf8285df28f32fd2d1c19a7166e70f00309c
Handled-By : Ingo Molnar <[email protected]>
Thomas Gleixner <[email protected]>
Yanmin Zhang <[email protected]>

2008-12-04 00:07:44

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12034] snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12034
Subject : snd-hda-intel on Realtek ALC268 chip shows only Master volume (for playback)
Submitter : Sergey <[email protected]>
Date : 2008-11-15 04:20 (19 days old)
Handled-By : Takashi Iwai <[email protected]>

2008-12-04 00:07:59

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
Subject : 2.6.28-rc VC switching with Intel graphics broken
Submitter : Romano Giannetti <[email protected]>
Date : 2008-11-03 12:10 (31 days old)
Handled-By : Jesse Barnes <[email protected]>

2008-12-04 00:08:27

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12159] 2.6.28-rc6-git1 -- No sound produced from Intel HDA ALSA driver

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12159
Subject : 2.6.28-rc6-git1 -- No sound produced from Intel HDA ALSA driver
Submitter : Miles Lane <[email protected]>
Date : 2008-11-27 20:33 (7 days old)
References : http://marc.info/?l=linux-kernel&m=122781805620212&w=4
Handled-By : Takashi Iwai <[email protected]>

2008-12-04 00:08:46

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12120] [Block layer or SCSI] requests aborted too early during check_partition()

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12120
Subject : [Block layer or SCSI] requests aborted too early during check_partition()
Submitter : Stefan Richter <[email protected]>
Date : 2008-11-29 05:19 (5 days old)

2008-12-04 00:09:13

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12082] IRQ and MSI allocations broken without sparse irq

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12082
Subject : IRQ and MSI allocations broken without sparse irq
Submitter : Jesper Dangaard Brouer <[email protected]>
Date : 2008-11-20 19:48 (14 days old)
References : http://marc.info/?l=linux-kernel&m=122721060501073&w=4
Handled-By : Thomas Gleixner <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122722773824802&w=4

2008-12-04 00:09:33

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12100] resume (S2R) broken by Intel microcode module, on A110L

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12100
Subject : resume (S2R) broken by Intel microcode module, on A110L
Submitter : Andreas Mohr <[email protected]>
Date : 2008-11-25 08:48 (9 days old)

2008-12-04 00:09:50

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12152] Huge wakeups number from i1915

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12152
Subject : Huge wakeups number from i1915
Submitter : Yves-Alexis Perez <[email protected]>
Date : 2008-12-02 16:48 (2 days old)
References : http://marc.info/?l=linux-acpi&m=122823656702994&w=4

2008-12-04 00:10:23

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12153] 2.6.28-rc2: runaway loop modprobe char-major-5-1

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12153
Subject : 2.6.28-rc2: runaway loop modprobe char-major-5-1
Submitter : Meelis Roos <[email protected]>
Date : 2008-10-28 10:15 (37 days old)
References : http://marc.info/?l=linux-kernel&m=122518916014197&w=4

2008-12-04 00:10:48

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12154] Mmiotrace regression in 2.6.28-rc6

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12154
Subject : Mmiotrace regression in 2.6.28-rc6
Submitter : Pekka Paalanen <[email protected]>
Date : 2008-11-23 13:41 (11 days old)
References : http://marc.info/?l=linux-kernel&m=122744774317151&w=4

2008-12-04 00:11:13

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12158] commit b1ee26b freezes system on switching from X to text console

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12158
Subject : commit b1ee26b freezes system on switching from X to text console
Submitter : Gaudenz Steinlin <[email protected]>
Date : 2008-11-25 19:44 (9 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
References : http://marc.info/?l=linux-kernel&m=122764344231140&w=4
Handled-By : Benjamin Herrenschmidt <[email protected]>

2008-12-04 00:11:31

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12155] Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12155
Subject : Regression in 2.6.28-rc and 2.6.27-stable - hibernate related
Submitter : Fabio Comolli <[email protected]>
Date : 2008-11-23 16:17 (11 days old)
References : http://marc.info/?l=linux-kernel&m=122745709926361&w=4

2008-12-04 00:11:48

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12156] v2.6.28-rc2: x86_32 relocation regression?

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12156
Subject : v2.6.28-rc2: x86_32 relocation regression?
Submitter : Vegard Nossum <[email protected]>
Date : 2008-11-24 21:19 (10 days old)
References : http://marc.info/?l=linux-kernel&m=122756158220966&w=4

2008-12-04 00:12:14

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12160] networking oops after resume from s2ram (2.6.28-rc6)

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12160
Subject : networking oops after resume from s2ram (2.6.28-rc6)
Submitter : Marcin Slusarz <[email protected]>
Date : 2008-11-28 21:15 (6 days old)
References : http://marc.info/?l=linux-kernel&m=122790701615723&w=4

2008-12-04 00:12:40

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12161] [i915 drm] irq 16: nobody cared with latest git kernels

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12161
Subject : [i915 drm] irq 16: nobody cared with latest git kernels
Submitter : fredi ml <[email protected]>
Date : 2008-12-02 13:26 (2 days old)
References : http://marc.info/?l=linux-kernel&m=122822444615724&w=4

2008-12-04 00:13:00

by Rafael J. Wysocki

[permalink] [raw]
Subject: [Bug #12162] Commit 7cd5b08be3 breaks startup on Toshiba Portege R500

This message has been generated automatically as a part of a report
of recent regressions.

The following bug entry is on the current list of known regressions
from 2.6.27. Please verify if it still should be listed and let me know
(either way).


Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12162
Subject : Commit 7cd5b08be3 breaks startup on Toshiba Portege R500
Submitter : Rafael J. Wysocki <[email protected]>
Date : 2008-12-03 22:00 (1 days old)
First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7cd5b08be3c489df11b559fef210b81133764ad4
References : http://marc.info/?l=linux-kernel&m=122834170321535&w=4
Handled-By : Linus Torvalds <[email protected]>
Patch : http://marc.info/?l=linux-kernel&m=122834271623218&w=4

2008-12-04 00:14:54

by James Bottomley

[permalink] [raw]
Subject: Re: [Bug #12020] scsi_times_out NULL pointer dereference

On Wed, 2008-12-03 at 22:57 +0100, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).

That's a hard call. We think this might be fixed by Tejun's block timer
patch, but the reporter has been unable to reproduce the problem (with
or without the timer patch).

Perhaps list as closed for now and reopen if we get another problem
report with kernels containing the block timer patch?

James

2008-12-04 00:17:37

by James Bottomley

[permalink] [raw]
Subject: Re: 2.6.28-rc7-git2: Reported regressions from 2.6.27

On Wed, 2008-12-03 at 22:49 +0100, Rafael J. Wysocki wrote:
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12120
> Subject : [Block layer or SCSI] requests aborted too early
> during check_partition()
> Submitter : Stefan Richter <[email protected]>
> Date : 2008-11-29 05:19 (5 days old)

Fixed by this patch:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9728c0814ecb505546696a659858fdb761375544

James

2008-12-04 00:35:28

by Linus Torvalds

[permalink] [raw]
Subject: Re: [Bug #12162] Commit 7cd5b08be3 breaks startup on Toshiba Portege R500


Rafael, I'm assuming my one-liner patch fixes your problem too, since you
attached the patch to the bugzilla entry. So I committed it as such. But
if it doesn't, we'll need to do something else.

The commit ended up being as appended..

Linus
---
From: Linus Torvalds <[email protected]>
Date: Wed, 3 Dec 2008 16:20:19 -0800
Subject: [PATCH] iTCO_wdt: fix typo when setting TCO_EN bit

The code used '&= 0x00002000' when it tried to set the TCO_EN bit, which
obviously didn't set that bit at all, but instead just reset all the
other bits in the SMI_EN register.

This bug seemingly caused various random behavior, with Frans Pop
reporting that X.org just silently hung at startup and Rafael Wysocki
reports the fan spinning with full speed.

See
http://lkml.org/lkml/2008/12/3/178
http://bugzilla.kernel.org/show_bug.cgi?id=12162

The problem seems to have been triggered by "[WATCHDOG] iTCO_wdt :
problem with rebooting on new ICH9 based motherboards" (commit
7cd5b08be3c489df11b559fef210b81133764ad4), but the bogus code existed
before that too (in the "supermicro_old_pre_stop()" function), it just
apparently never showed up due to different logic.

In that commit the broken code got moved around and now gets executed
much more.

Reported-by: Rafael J. Wysocki <[email protected]>
Tested-by: Frans Pop <[email protected]>
Cc: Wim Van Sebroeck <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
---
drivers/watchdog/iTCO_wdt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
index 26173a2..5b395a4 100644
--- a/drivers/watchdog/iTCO_wdt.c
+++ b/drivers/watchdog/iTCO_wdt.c
@@ -392,7 +392,7 @@ static int iTCO_wdt_stop(void)

/* Bit 13: TCO_EN -> 1 = Enables the TCO logic to generate SMI# */
val32 = inl(SMI_EN);
- val32 &= 0x00002000;
+ val32 |= 0x00002000;
outl(val32, SMI_EN);

/* Set the NO_REBOOT bit to prevent later reboots, just for sure */

2008-12-04 00:44:36

by Linus Torvalds

[permalink] [raw]
Subject: Re: [Bug #12158] commit b1ee26b freezes system on switching from X to text console



On Wed, 3 Dec 2008, Rafael J. Wysocki wrote:
>
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12158
> Subject : commit b1ee26b freezes system on switching from X to text console
> Submitter : Gaudenz Steinlin <[email protected]>
> Date : 2008-11-25 19:44 (9 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
> References : http://marc.info/?l=linux-kernel&m=122764344231140&w=4
> Handled-By : Benjamin Herrenschmidt <[email protected]>

I think we're assuming that this already got fixed by commit
c4c6fa9891f3d1bcaae4f39fb751d5302965b566 ("radeonfb: fix problem with
color expansion & alignment").

Gaudenz?

Linus

2008-12-04 01:15:35

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #12162] Commit 7cd5b08be3 breaks startup on Toshiba Portege R500

On Thursday, 4 of December 2008, Linus Torvalds wrote:
>
> Rafael, I'm assuming my one-liner patch fixes your problem too, since you
> attached the patch to the bugzilla entry. So I committed it as such. But
> if it doesn't, we'll need to do something else.
>
> The commit ended up being as appended..

I've just pulled your tree including this commit and it boots correctly, so
this is the right fix.

I've already closed the bug.

Thanks,
Rafael


> ---
> From: Linus Torvalds <[email protected]>
> Date: Wed, 3 Dec 2008 16:20:19 -0800
> Subject: [PATCH] iTCO_wdt: fix typo when setting TCO_EN bit
>
> The code used '&= 0x00002000' when it tried to set the TCO_EN bit, which
> obviously didn't set that bit at all, but instead just reset all the
> other bits in the SMI_EN register.
>
> This bug seemingly caused various random behavior, with Frans Pop
> reporting that X.org just silently hung at startup and Rafael Wysocki
> reports the fan spinning with full speed.
>
> See
> http://lkml.org/lkml/2008/12/3/178
> http://bugzilla.kernel.org/show_bug.cgi?id=12162
>
> The problem seems to have been triggered by "[WATCHDOG] iTCO_wdt :
> problem with rebooting on new ICH9 based motherboards" (commit
> 7cd5b08be3c489df11b559fef210b81133764ad4), but the bogus code existed
> before that too (in the "supermicro_old_pre_stop()" function), it just
> apparently never showed up due to different logic.
>
> In that commit the broken code got moved around and now gets executed
> much more.
>
> Reported-by: Rafael J. Wysocki <[email protected]>
> Tested-by: Frans Pop <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Signed-off-by: Linus Torvalds <[email protected]>
> ---
> drivers/watchdog/iTCO_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 26173a2..5b395a4 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -392,7 +392,7 @@ static int iTCO_wdt_stop(void)
>
> /* Bit 13: TCO_EN -> 1 = Enables the TCO logic to generate SMI# */
> val32 = inl(SMI_EN);
> - val32 &= 0x00002000;
> + val32 |= 0x00002000;
> outl(val32, SMI_EN);
>
> /* Set the NO_REBOOT bit to prevent later reboots, just for sure */
>
>



--
Everyone knows that debugging is twice as hard as writing a program
in the first place. So if you're as clever as you can be when you write it,
how will you ever debug it? --- Brian Kernighan

2008-12-04 01:32:50

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: [Bug #12158] commit b1ee26b freezes system on switching from X to text console

On Wed, 2008-12-03 at 16:44 -0800, Linus Torvalds wrote:
>
> On Wed, 3 Dec 2008, Rafael J. Wysocki wrote:
> >
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12158
> > Subject : commit b1ee26b freezes system on switching from X to text console
> > Submitter : Gaudenz Steinlin <[email protected]>
> > Date : 2008-11-25 19:44 (9 days old)
> > First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b1ee26bab14886350ba12a5c10cbc0696ac679bf
> > References : http://marc.info/?l=linux-kernel&m=122764344231140&w=4
> > Handled-By : Benjamin Herrenschmidt <[email protected]>
>
> I think we're assuming that this already got fixed by commit
> c4c6fa9891f3d1bcaae4f39fb751d5302965b566 ("radeonfb: fix problem with
> color expansion & alignment").

No, this is a different problem I think. That race between VT switch and
X, which I -suspect- may be an X bug. I haven't managed to pin it down
yet, so what I may do for .28 is send a patch that disables color
expansion acceleration unless you explicitely request it via a module
param. At least until I can find what's going on.

Cheers,
Ben.

2008-12-04 07:31:38

by Frederik Deweerdt

[permalink] [raw]
Subject: Re: [Bug #12047] ACPI toshiba: only register rfkill if bt is enabled

Hello Rafael,
On Wed, Dec 3, 2008 at 10:58 PM, Rafael J. Wysocki <[email protected]> wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12047
> Subject : ACPI toshiba: only register rfkill if bt is enabled
> Submitter : Andrey Borzenkov <[email protected]>
> Date : 2008-10-28 19:10 (37 days old)
> References : http://marc.info/?l=linux-kernel&m=122522113619025&w=2
> Handled-By : Frederik Deweerdt <[email protected]>
> Patch : http://marc.info/?l=linux-kernel&m=122526843117478&w=2
Still should be listed, an updated patch is in -mm now.

Regards,
Frederik

2008-12-04 07:46:20

by Ingo Molnar

[permalink] [raw]
Subject: Re: [Bug #11970] gettimeofday return a old time in mmbench


* Rafael J. Wysocki <[email protected]> wrote:

> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11970
> Subject : gettimeofday return a old time in mmbench
> Submitter : alexs <[email protected]>
> Date : 2008-11-06 23:57 (28 days old)
> First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99ebcf8285df28f32fd2d1c19a7166e70f00309c
> Handled-By : Ingo Molnar <[email protected]>
> Thomas Gleixner <[email protected]>
> Yanmin Zhang <[email protected]>

fixed by the patch below from John Stultz, queued up in
tip/timers/urgent.

The bisection-blamed merge commit above likely just causes a random shift
in the timings or compiler optimization conditions of this code - making
the bug more likely to trigger. The bug/race itself is old.

Ingo

------------------------->
>From 6c9bacb41c10ba84ff68f238e234d96f35fb64f7 Mon Sep 17 00:00:00 2001
From: john stultz <[email protected]>
Date: Mon, 1 Dec 2008 18:34:41 -0800
Subject: [PATCH] time: catch xtime_nsec underflows and fix them

Impact: fix time warp bug

Alex Shi, along with Yanmin Zhang have been noticing occasional time
inconsistencies recently. Through their great diagnosis, they found that
the xtime_nsec value used in update_wall_time was occasionally going
negative. After looking through the code for awhile, I realized we have
the possibility for an underflow when three conditions are met in
update_wall_time():

1) We have accumulated a second's worth of nanoseconds, so we
incremented xtime.tv_sec and appropriately decrement xtime_nsec.
(This doesn't cause xtime_nsec to go negative, but it can cause it
to be small).

2) The remaining offset value is large, but just slightly less then
cycle_interval.

3) clocksource_adjust() is speeding up the clock, causing a
corrective amount (compensating for the increase in the multiplier
being multiplied against the unaccumulated offset value) to be
subtracted from xtime_nsec.

This can cause xtime_nsec to underflow.

Unfortunately, since we notify the NTP subsystem via second_overflow()
whenever we accumulate a full second, and this effects the error
accumulation that has already occured, we cannot simply revert the
accumulated second from xtime nor move the second accumulation to after
the clocksource_adjust call without a change in behavior.

This leaves us with (at least) two options:

1) Simply return from clocksource_adjust() without making a change if we
notice the adjustment would cause xtime_nsec to go negative.

This would work, but I'm concerned that if a large adjustment was needed
(due to the error being large), it may be possible to get stuck with an
ever increasing error that becomes too large to correct (since it may
always force xtime_nsec negative). This may just be paranoia on my part.

2) Catch xtime_nsec if it is negative, then add back the amount its
negative to both xtime_nsec and the error.

This second method is consistent with how we've handled earlier rounding
issues, and also has the benefit that the error being added is always in
the oposite direction also always equal or smaller then the correction
being applied. So the risk of a corner case where things get out of
control is lessened.

This patch fixes bug 11970, as tested by Yanmin Zhang
http://bugzilla.kernel.org/show_bug.cgi?id=11970

Reported-by: [email protected]
Signed-off-by: John Stultz <[email protected]>
Acked-by: "Zhang, Yanmin" <[email protected]>
Tested-by: "Zhang, Yanmin" <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
---
kernel/time/timekeeping.c | 22 ++++++++++++++++++++++
1 files changed, 22 insertions(+), 0 deletions(-)

diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index e7acfb4..fa05e88 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -518,6 +518,28 @@ void update_wall_time(void)
/* correct the clock when NTP error is too big */
clocksource_adjust(offset);

+ /*
+ * Since in the loop above, we accumulate any amount of time
+ * in xtime_nsec over a second into xtime.tv_sec, its possible for
+ * xtime_nsec to be fairly small after the loop. Further, if we're
+ * slightly speeding the clocksource up in clocksource_adjust(),
+ * its possible the required corrective factor to xtime_nsec could
+ * cause it to underflow.
+ *
+ * Now, we cannot simply roll the accumulated second back, since
+ * the NTP subsystem has been notified via second_overflow. So
+ * instead we push xtime_nsec forward by the amount we underflowed,
+ * and add that amount into the error.
+ *
+ * We'll correct this error next time through this function, when
+ * xtime_nsec is not as small.
+ */
+ if (unlikely((s64)clock->xtime_nsec < 0)) {
+ s64 neg = -(s64)clock->xtime_nsec;
+ clock->xtime_nsec = 0;
+ clock->error += neg << (NTP_SCALE_SHIFT - clock->shift);
+ }
+
/* store full nanoseconds into xtime after rounding it up and
* add the remainder to the error difference.
*/

2008-12-04 08:05:53

by Wim Van Sebroeck

[permalink] [raw]
Subject: Re: [Bug #12162] Commit 7cd5b08be3 breaks startup on Toshiba Portege R500

Hi All,

I will test the watchdog part tonight on an ICH4 and ICH9 chipset.
I indeed moved the code over from the supermicro_old_pre_stop code.
And I'm sure this fix indeed needs to go in.

Kind regards,
Wim.

>
> Rafael, I'm assuming my one-liner patch fixes your problem too, since you
> attached the patch to the bugzilla entry. So I committed it as such. But
> if it doesn't, we'll need to do something else.
>
> The commit ended up being as appended..
>
> Linus
> ---
> From: Linus Torvalds <[email protected]>
> Date: Wed, 3 Dec 2008 16:20:19 -0800
> Subject: [PATCH] iTCO_wdt: fix typo when setting TCO_EN bit
>
> The code used '&= 0x00002000' when it tried to set the TCO_EN bit, which
> obviously didn't set that bit at all, but instead just reset all the
> other bits in the SMI_EN register.
>
> This bug seemingly caused various random behavior, with Frans Pop
> reporting that X.org just silently hung at startup and Rafael Wysocki
> reports the fan spinning with full speed.
>
> See
> http://lkml.org/lkml/2008/12/3/178
> http://bugzilla.kernel.org/show_bug.cgi?id=12162
>
> The problem seems to have been triggered by "[WATCHDOG] iTCO_wdt :
> problem with rebooting on new ICH9 based motherboards" (commit
> 7cd5b08be3c489df11b559fef210b81133764ad4), but the bogus code existed
> before that too (in the "supermicro_old_pre_stop()" function), it just
> apparently never showed up due to different logic.
>
> In that commit the broken code got moved around and now gets executed
> much more.
>
> Reported-by: Rafael J. Wysocki <[email protected]>
> Tested-by: Frans Pop <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Signed-off-by: Linus Torvalds <[email protected]>
> ---
> drivers/watchdog/iTCO_wdt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 26173a2..5b395a4 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -392,7 +392,7 @@ static int iTCO_wdt_stop(void)
>
> /* Bit 13: TCO_EN -> 1 = Enables the TCO logic to generate SMI# */
> val32 = inl(SMI_EN);
> - val32 &= 0x00002000;
> + val32 |= 0x00002000;
> outl(val32, SMI_EN);
>
> /* Set the NO_REBOOT bit to prevent later reboots, just for sure */

2008-12-04 08:50:29

by Fabio Comolli

[permalink] [raw]
Subject: Re: [Bug #12155] Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

Hi.

On Wed, Dec 3, 2008 at 10:58 PM, Rafael J. Wysocki <[email protected]> wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12155
> Subject : Regression in 2.6.28-rc and 2.6.27-stable - hibernate related
> Submitter : Fabio Comolli <[email protected]>
> Date : 2008-11-23 16:17 (11 days old)
> References : http://marc.info/?l=linux-kernel&m=122745709926361&w=4
>

Unfortunately I don't have much time to test but yes, it was present
last time I tried.
I'll try -rc7-git probably tonight and 2.6.27.8 when -stable team releases it.

2008-12-04 10:55:30

by Romano Giannetti

[permalink] [raw]
Subject: Re: [Bug #11947] 2.6.28-rc VC switching with Intel graphics broken


Rafael J. Wysocki wrote:
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11947
> Subject : 2.6.28-rc VC switching with Intel graphics broken
> Submitter : Romano Giannetti <[email protected]>
> Date : 2008-11-03 12:10 (31 days old)
> Handled-By : Jesse Barnes <[email protected]>
>

It is fixed for me in -rc7-105 (to be exact, it seems that commit 52440211dc
fixed it), but there are more people with a very similar problem still unfixed.

Romano

--
Sorry for the disclaimer --- ¡I cannot stop it!


--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ley. Si Ud. ha recibido esta comunicación por error, por favor, notifíquelo inmediatamente al remitente contestando a este mensaje y proceda a continuación a destruirlo. Gracias por su colaboración.

This communication contains confidential information. It is for the exclusive use of the intended addressee. If you are not the intended addressee, please note that any form of distribution, copying or use of this communication or the information in it is strictly prohibited by law. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy this message. Thank you for your cooperation.

2008-12-04 19:03:12

by Pekka Paalanen

[permalink] [raw]
Subject: Re: [Bug #12154] Mmiotrace regression in 2.6.28-rc6

On Wed, 3 Dec 2008 22:58:03 +0100 (CET)
"Rafael J. Wysocki" <[email protected]> wrote:

> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).
>
>
> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12154
> Subject : Mmiotrace regression in 2.6.28-rc6
> Submitter : Pekka Paalanen <[email protected]>
> Date : 2008-11-23 13:41 (11 days old)
> References : http://marc.info/?l=linux-kernel&m=122744774317151&w=4

This is fixed:

http://marc.info/?l=linux-kernel&m=122746837006707&w=2

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7ee1768ddb3075ae3a0801cc2d0ea4195530a7db

Thanks.

--
Pekka Paalanen
http://www.iki.fi/pq/

2008-12-04 22:46:04

by Wim Van Sebroeck

[permalink] [raw]
Subject: Re: [Bug #12162] Commit 7cd5b08be3 breaks startup on Toshiba Portege R500

Hi All,

> I will test the watchdog part tonight on an ICH4 and ICH9 chipset.
> I indeed moved the code over from the supermicro_old_pre_stop code.
> And I'm sure this fix indeed needs to go in.

Test on ICH4 is OK.
Test on ICH9 -> the watchdog timer runs but doesn't reboot the system anymore.
The following bits are active in SMI_EN and thus need to be investigated:
13 - TCO_EN (Not relevant since we set/unset this allready)
5 - APMC_EN
4 - SLP_SMI_EN
3 - LEGACY_USB_EN
1 - End Of SMI
0 - GBL_SMI_EN

A first test indicated that if bit 0 is forced to 0, the system reboots again.
The second test reveals that setting bits 5, 4, 3 and 1 to 0 doesn't help the rebooting of the ICH9 chipset.
So the real issue with ICH9 and rebooting has to do with the GBL_SMI_EN bit.

So next step will be to create an additional patch and then test it with Rafael and Frans...

Kind regards,
Wim.

2008-12-05 16:22:00

by Gaudenz Steinlin

[permalink] [raw]
Subject: Re: [Bug #12158] commit b1ee26b freezes system on switching from X to text console

On Wed, Dec 03, 2008 at 04:44:03PM -0800, Linus Torvalds wrote:

> I think we're assuming that this already got fixed by commit
> c4c6fa9891f3d1bcaae4f39fb751d5302965b566 ("radeonfb: fix problem with
> color expansion & alignment").
>
> Gaudenz?

Sorry, no, this commit does not fix my bug.

Gaudenz

--
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~

2008-12-06 20:08:44

by Fabio Comolli

[permalink] [raw]
Subject: Re: [Bug #12155] Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

Hi Rafael.

On Thu, Dec 4, 2008 at 9:50 AM, Fabio Comolli <[email protected]> wrote:
> Hi.
>
> I'll try -rc7-git probably tonight and 2.6.27.8 when -stable team releases it.
>

2.6.28-rc7 survived 7 suspend/resume cycles and then showed the bug.
This time I modified my config to use the timed printk's. This is the
output:

[ 8831.905901] Syncing filesystems ... done.
[ 8831.906707] Freezing user space processes ... (elapsed 0.00 seconds) done.
[ 8831.907860] Freezing remaining freezable tasks ... (elapsed 0.00
seconds) done.
[ 8831.909257] PM: Shrinking memory... done (0 pages freed)
[ 8831.975535] PM: Freed 0 kbytes in 0.06 seconds (0.00 MB/s)
[ 8831.975558] Suspending console(s) (use no_console_suspend to debug)
[ 8831.976131] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[ 8832.041534] pciehp 0000:00:1c.0:pcie02: pciehp_suspend ENTRY
[ 8832.041755] ACPI handle has no context!
[ 8832.041765] tifm_7xx1 0000:06:06.3: PCI INT A disabled
[ 8832.041773] ACPI handle has no context!
[ 8832.056238] ACPI handle has no context!
[ 8832.072271] eth1: Going into suspend...
[ 8832.078493] ipw2200 0000:06:05.0: PCI INT A disabled
[ 8832.078502] ACPI handle has no context!
[ 8832.092042] [fglrx] Power down the ASIC .
[ 8832.144044] fglrx_pci 0000:01:00.0: PCI INT A disabled
[ 8832.144155] ata2: port disabled. ignoring.
[ 8832.144211] ata_piix 0000:00:1f.1: PCI INT A disabled
[ 8832.144606] Intel ICH 0000:00:1e.2: PCI INT A disabled
[ 8832.144743] ehci_hcd 0000:00:1d.7: PCI INT A disabled
[ 8832.144783] uhci_hcd 0000:00:1d.3: PCI INT D disabled
[ 8832.144822] uhci_hcd 0000:00:1d.2: PCI INT C disabled
[ 8832.144860] uhci_hcd 0000:00:1d.1: PCI INT B disabled
[ 8832.144899] uhci_hcd 0000:00:1d.0: PCI INT A disabled
[ 8832.144903] pciehp 0000:00:1c.0:pcie02: pciehp_suspend ENTRY
[ 8832.145347] ACPI: Preparing to enter system sleep state S4
[ 8832.147058] PM: Creating hibernation image:
[ 8832.148005] PM: Need to copy 169684 pages
[ 8832.148005] Intel machine check architecture supported.
[ 8832.148005] Intel machine check reporting enabled on CPU#0.
[ 9073.757209] Force enabled HPET at resume
[ 9073.757323] ACPI: Waking up from system sleep state S4
[ 9073.757352] ACPI: EC: non-query interrupt received, switching to
interrupt mode
[ 9073.757352] pcieport-driver 0000:00:01.0: setting latency timer to 64
[ 9073.757352] pcieport-driver 0000:00:1c.0: setting latency timer to 64
[ 9073.757352] pciehp 0000:00:1c.0:pcie02: pciehp_resume ENTRY
[ 9073.757352] uhci_hcd 0000:00:1d.0: PCI INT A -> GSI 23 (level, low) -> IRQ 23
[ 9073.757352] uhci_hcd 0000:00:1d.0: setting latency timer to 64
[ 9073.757352] uhci_hcd 0000:00:1d.1: PCI INT B -> GSI 19 (level, low) -> IRQ 19
[ 9073.757352] uhci_hcd 0000:00:1d.1: setting latency timer to 64
[ 9073.757352] uhci_hcd 0000:00:1d.2: PCI INT C -> GSI 18 (level, low) -> IRQ 18
[ 9073.757352] uhci_hcd 0000:00:1d.2: setting latency timer to 64
[ 9073.757352] uhci_hcd 0000:00:1d.3: PCI INT D -> GSI 16 (level, low) -> IRQ 16
[ 9073.757352] uhci_hcd 0000:00:1d.3: setting latency timer to 64
[ 9073.757352] ehci_hcd 0000:00:1d.7: PCI INT A -> GSI 23 (level, low) -> IRQ 23
[ 9073.757352] ehci_hcd 0000:00:1d.7: setting latency timer to 64
[ 9073.757352] pci 0000:00:1e.0: setting latency timer to 64
[ 9073.757352] Intel ICH 0000:00:1e.2: PCI INT A -> GSI 17 (level,
low) -> IRQ 17
[ 9073.757352] Intel ICH 0000:00:1e.2: setting latency timer to 64
[ 9073.757352] ata_piix 0000:00:1f.1: restoring config space at offset
0x1 (was 0x2880001, writing 0x2880005)
[ 9073.757352] ata_piix 0000:00:1f.1: PCI INT A -> GSI 18 (level, low) -> IRQ 18
[ 9073.757352] ata_piix 0000:00:1f.1: setting latency timer to 64
[ 9073.757352] ata2: port disabled. ignoring.
[ 9073.757352] fglrx_pci 0000:01:00.0: power state changed by ACPI to D0
[ 9073.757352] fglrx_pci 0000:01:00.0: PCI INT A -> GSI 16 (level,
low) -> IRQ 16
[ 9073.757352] fglrx_pci 0000:01:00.0: setting latency timer to 64
[ 9073.757352] [fglrx] Power up the ASIC
[ 9073.757352] eth1: Coming out of suspend...
[ 9073.757352] ipw2200 0000:06:05.0: enabling device (0000 -> 0002)
[ 9073.757352] ipw2200 0000:06:05.0: PCI INT A -> GSI 20 (level, low) -> IRQ 20
[ 9073.757352] ipw2200 0000:06:05.0: restoring config space at offset
0xf (was 0x18030100, writing 0x1803010b)
[ 9073.757352] ipw2200 0000:06:05.0: restoring config space at offset
0x4 (was 0x0, writing 0xc8206000)
[ 9073.757352] ipw2200 0000:06:05.0: restoring config space at offset
0x3 (was 0x0, writing 0x8008)
[ 9073.757352] ipw2200 0000:06:05.0: restoring config space at offset
0x1 (was 0x2900002, writing 0x2900116)
[ 9073.757352] ata1.01: ACPI cmd ef/03:0c:00:00:00:b0 filtered out
[ 9073.757352] ata1.01: ACPI cmd ef/03:22:00:00:00:b0 filtered out
[ 9073.757352] ata1.00: ACPI cmd ef/03:0c:00:00:00:a0 filtered out
[ 9073.757352] ata1.00: ACPI cmd ef/03:45:00:00:00:a0 filtered out
[ 9073.757352] ata1.00: configured for UDMA/100
[ 9073.757352] ata1.01: configured for MWDMA2
[ 9073.757352] sd 0:0:0:0: [sda] 156301488 512-byte hardware sectors:
(80.0 GB/74.5 GiB)
[ 9073.757352] sd 0:0:0:0: [sda] Write Protect is off
[ 9073.757352] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[ 9073.757352] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[ 9073.757352] sd 0:0:0:0: [sda] 156301488 512-byte hardware sectors:
(80.0 GB/74.5 GiB)
[ 9073.757352] sd 0:0:0:0: [sda] Write Protect is off
[ 9073.757352] sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
[ 9073.757352] sd 0:0:0:0: [sda] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[ 9073.757352] firewire_ohci 0000:06:06.2: restoring config space at
offset 0xf (was 0x4020300, writing 0x402030b)
[ 9073.757352] firewire_ohci 0000:06:06.2: restoring config space at
offset 0x5 (was 0x0, writing 0xc8200000)
[ 9073.757352] firewire_ohci 0000:06:06.2: restoring config space at
offset 0x4 (was 0x0, writing 0xc8208000)
[ 9073.757352] firewire_ohci 0000:06:06.2: restoring config space at
offset 0x3 (was 0x800000, writing 0x808008)
[ 9073.757352] firewire_ohci 0000:06:06.2: restoring config space at
offset 0x1 (was 0x2100000, writing 0x2100116)
[ 9073.757352] tifm_7xx1 0000:06:06.3: restoring config space at
offset 0xf (was 0x40701ff, writing 0x407010a)
[ 9073.757352] tifm_7xx1 0000:06:06.3: restoring config space at
offset 0x4 (was 0x0, writing 0xc8204000)
[ 9073.757352] tifm_7xx1 0000:06:06.3: restoring config space at
offset 0x3 (was 0x800000, writing 0x808008)
[ 9073.757352] tifm_7xx1 0000:06:06.3: restoring config space at
offset 0x1 (was 0x2100000, writing 0x2100106)
[ 9073.757352] tifm_7xx1 0000:06:06.3: PCI INT A -> GSI 22 (level,
low) -> IRQ 22
[ 9073.757352] pciehp 0000:00:1c.0:pcie02: pciehp_resume ENTRY
[ 9073.757352] sd 0:0:0:0: [sda] Starting disk
[ 9073.757352] Restarting tasks ... done.

Unfortunately I can see nothing wrong in this log, it's basically
identical to the good resume case.

The hang lasted 3min 57sec, just for the record.

Regards,
Fabio

2008-12-07 13:39:17

by Fabio Comolli

[permalink] [raw]
Subject: Re: [Bug #12155] Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

Hi.

On Sat, Dec 6, 2008 at 9:08 PM, Fabio Comolli <[email protected]> wrote:
> Hi Rafael.
>
> On Thu, Dec 4, 2008 at 9:50 AM, Fabio Comolli <[email protected]> wrote:
>> Hi.
>>
>> I'll try -rc7-git probably tonight and 2.6.27.8 when -stable team releases it.
>>
>
> 2.6.28-rc7 survived 7 suspend/resume cycles and then showed the bug.

2.6.27.8 got me really scared. After the resume and the usual hang, my
hard disk did not recover and my rootfilesystem's journal aborted. Of
course I don't have messages to post as the rootfs was at this point
mounted readonly. I read those info from dmesg.

I went back to my dear 2.6.27.4 which is stable and never caused me
any problems.

Unless someone jumps in with some ideas, I'm not going to do testings
anymore. I can't lose my only machine because of this.

Regards,
Fabio

2008-12-07 19:18:05

by Frederik

[permalink] [raw]
Subject: Re: [Bug #12161] [i915 drm] irq 16: nobody cared with latest git kernels

Hi Rafael,
On Wednesday 03 December 2008 22:58:06 Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of recent regressions.
>
> The following bug entry is on the current list of known regressions
> from 2.6.27. Please verify if it still should be listed and let me know
> (either way).

This regression is present on kernels newer than 2.4.28-rc3. Unfortunately it
needs time to hit this bug so there's no easy way to bisect it ... And BTW
there is a bugzilla entry here for this issue:

https://bugs.freedesktop.org/show_bug.cgi?id=18609


> Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12161
> Subject : [i915 drm] irq 16: nobody cared with latest git kernels
> Submitter : fredi ml <[email protected]>
> Date : 2008-12-02 13:26 (2 days old)
> References : http://marc.info/?l=linux-kernel&m=122822444615724&w=4

Thanks,
Frederik

2008-12-07 20:09:32

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #12155] Regression in 2.6.28-rc and 2.6.27-stable - hibernate related

On Sunday, 7 of December 2008, Fabio Comolli wrote:
> Hi.
>
> On Sat, Dec 6, 2008 at 9:08 PM, Fabio Comolli <[email protected]> wrote:
> > Hi Rafael.
> >
> > On Thu, Dec 4, 2008 at 9:50 AM, Fabio Comolli <[email protected]> wrote:
> >> Hi.
> >>
> >> I'll try -rc7-git probably tonight and 2.6.27.8 when -stable team releases it.
> >>
> >
> > 2.6.28-rc7 survived 7 suspend/resume cycles and then showed the bug.
>
> 2.6.27.8 got me really scared. After the resume and the usual hang, my
> hard disk did not recover and my rootfilesystem's journal aborted. Of
> course I don't have messages to post as the rootfs was at this point
> mounted readonly. I read those info from dmesg.
>
> I went back to my dear 2.6.27.4 which is stable and never caused me
> any problems.
>
> Unless someone jumps in with some ideas, I'm not going to do testings
> anymore. I can't lose my only machine because of this.

OK, thanks for the testing so far.

Please just ignore the subsequent automatic messages about this regression.

Thanks,
Rafael

2008-12-07 20:10:28

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #12154] Mmiotrace regression in 2.6.28-rc6

On Thursday, 4 of December 2008, Pekka Paalanen wrote:
> On Wed, 3 Dec 2008 22:58:03 +0100 (CET)
> "Rafael J. Wysocki" <[email protected]> wrote:
>
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=12154
> > Subject : Mmiotrace regression in 2.6.28-rc6
> > Submitter : Pekka Paalanen <[email protected]>
> > Date : 2008-11-23 13:41 (11 days old)
> > References : http://marc.info/?l=linux-kernel&m=122744774317151&w=4
>
> This is fixed:
>
> http://marc.info/?l=linux-kernel&m=122746837006707&w=2
>
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7ee1768ddb3075ae3a0801cc2d0ea4195530a7db

Thanks, closed now.

Rafael

2008-12-07 20:13:30

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #12161] [i915 drm] irq 16: nobody cared with latest git kernels

On Sunday, 7 of December 2008, Frederik wrote:
> Hi Rafael,
> On Wednesday 03 December 2008 22:58:06 Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
>
> This regression is present on kernels newer than 2.4.28-rc3. Unfortunately it
> needs time to hit this bug so there's no easy way to bisect it ... And BTW
> there is a bugzilla entry here for this issue:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=18609

Thanks, I added the reference to the bug entry.

Rafael

2008-12-07 20:23:18

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #12020] scsi_times_out NULL pointer dereference

On Thursday, 4 of December 2008, James Bottomley wrote:
> On Wed, 2008-12-03 at 22:57 +0100, Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
>
> That's a hard call. We think this might be fixed by Tejun's block timer
> patch, but the reporter has been unable to reproduce the problem (with
> or without the timer patch).
>
> Perhaps list as closed for now and reopen if we get another problem
> report with kernels containing the block timer patch?

I closed it as unreproducible on the basis of the last Bugzilla comment.

Thanks,
Rafael

2008-12-07 20:26:20

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [Bug #11970] gettimeofday return a old time in mmbench

On Thursday, 4 of December 2008, Ingo Molnar wrote:
>
> * Rafael J. Wysocki <[email protected]> wrote:
>
> > This message has been generated automatically as a part of a report
> > of recent regressions.
> >
> > The following bug entry is on the current list of known regressions
> > from 2.6.27. Please verify if it still should be listed and let me know
> > (either way).
> >
> >
> > Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11970
> > Subject : gettimeofday return a old time in mmbench
> > Submitter : alexs <[email protected]>
> > Date : 2008-11-06 23:57 (28 days old)
> > First-Bad-Commit: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=99ebcf8285df28f32fd2d1c19a7166e70f00309c
> > Handled-By : Ingo Molnar <[email protected]>
> > Thomas Gleixner <[email protected]>
> > Yanmin Zhang <[email protected]>
>
> fixed by the patch below from John Stultz, queued up in
> tip/timers/urgent.
>
> The bisection-blamed merge commit above likely just causes a random shift
> in the timings or compiler optimization conditions of this code - making
> the bug more likely to trigger. The bug/race itself is old.

The patch has been merged, so the bug is closed now.

Thanks,
Rafael


> ------------------------->
> From 6c9bacb41c10ba84ff68f238e234d96f35fb64f7 Mon Sep 17 00:00:00 2001
> From: john stultz <[email protected]>
> Date: Mon, 1 Dec 2008 18:34:41 -0800
> Subject: [PATCH] time: catch xtime_nsec underflows and fix them
>
> Impact: fix time warp bug
>
> Alex Shi, along with Yanmin Zhang have been noticing occasional time
> inconsistencies recently. Through their great diagnosis, they found that
> the xtime_nsec value used in update_wall_time was occasionally going
> negative. After looking through the code for awhile, I realized we have
> the possibility for an underflow when three conditions are met in
> update_wall_time():
>
> 1) We have accumulated a second's worth of nanoseconds, so we
> incremented xtime.tv_sec and appropriately decrement xtime_nsec.
> (This doesn't cause xtime_nsec to go negative, but it can cause it
> to be small).
>
> 2) The remaining offset value is large, but just slightly less then
> cycle_interval.
>
> 3) clocksource_adjust() is speeding up the clock, causing a
> corrective amount (compensating for the increase in the multiplier
> being multiplied against the unaccumulated offset value) to be
> subtracted from xtime_nsec.
>
> This can cause xtime_nsec to underflow.
>
> Unfortunately, since we notify the NTP subsystem via second_overflow()
> whenever we accumulate a full second, and this effects the error
> accumulation that has already occured, we cannot simply revert the
> accumulated second from xtime nor move the second accumulation to after
> the clocksource_adjust call without a change in behavior.
>
> This leaves us with (at least) two options:
>
> 1) Simply return from clocksource_adjust() without making a change if we
> notice the adjustment would cause xtime_nsec to go negative.
>
> This would work, but I'm concerned that if a large adjustment was needed
> (due to the error being large), it may be possible to get stuck with an
> ever increasing error that becomes too large to correct (since it may
> always force xtime_nsec negative). This may just be paranoia on my part.
>
> 2) Catch xtime_nsec if it is negative, then add back the amount its
> negative to both xtime_nsec and the error.
>
> This second method is consistent with how we've handled earlier rounding
> issues, and also has the benefit that the error being added is always in
> the oposite direction also always equal or smaller then the correction
> being applied. So the risk of a corner case where things get out of
> control is lessened.
>
> This patch fixes bug 11970, as tested by Yanmin Zhang
> http://bugzilla.kernel.org/show_bug.cgi?id=11970
>
> Reported-by: [email protected]
> Signed-off-by: John Stultz <[email protected]>
> Acked-by: "Zhang, Yanmin" <[email protected]>
> Tested-by: "Zhang, Yanmin" <[email protected]>
> Signed-off-by: Ingo Molnar <[email protected]>
> ---
> kernel/time/timekeeping.c | 22 ++++++++++++++++++++++
> 1 files changed, 22 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index e7acfb4..fa05e88 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -518,6 +518,28 @@ void update_wall_time(void)
> /* correct the clock when NTP error is too big */
> clocksource_adjust(offset);
>
> + /*
> + * Since in the loop above, we accumulate any amount of time
> + * in xtime_nsec over a second into xtime.tv_sec, its possible for
> + * xtime_nsec to be fairly small after the loop. Further, if we're
> + * slightly speeding the clocksource up in clocksource_adjust(),
> + * its possible the required corrective factor to xtime_nsec could
> + * cause it to underflow.
> + *
> + * Now, we cannot simply roll the accumulated second back, since
> + * the NTP subsystem has been notified via second_overflow. So
> + * instead we push xtime_nsec forward by the amount we underflowed,
> + * and add that amount into the error.
> + *
> + * We'll correct this error next time through this function, when
> + * xtime_nsec is not as small.
> + */
> + if (unlikely((s64)clock->xtime_nsec < 0)) {
> + s64 neg = -(s64)clock->xtime_nsec;
> + clock->xtime_nsec = 0;
> + clock->error += neg << (NTP_SCALE_SHIFT - clock->shift);
> + }
> +
> /* store full nanoseconds into xtime after rounding it up and
> * add the remainder to the error difference.
> */