2009-06-18 23:07:43

by Jiri Slaby

Subject: [PATCH 1/1] ath5k: fix beacon_int handling

73ca5203366235f8a43e490767284ba8cfd8c479
(ath5k: remove conf->beacon_int usage)
removed bintval setting from ath5k_config. We need to init the
interval earlier and don't touch it in add_interface anymore.

Otherwise it will be set only once by upper layer through
bss_info_changed but not on second and further hostap executions.

We ended up having bintval 1000 which rendered the AP useless on
many clients.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Nick Kossifidis <[email protected]>
Cc: Luis R. Rodriguez <[email protected]>
Cc: Bob Copeland <[email protected]>
---
drivers/net/wireless/ath/ath5k/base.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
index 55f7de0..70ba861 100644
--- a/drivers/net/wireless/ath/ath5k/base.c
+++ b/drivers/net/wireless/ath/ath5k/base.c
@@ -538,6 +538,7 @@ ath5k_pci_probe(struct pci_dev *pdev,
sc->iobase = mem; /* So we can unmap it on detach */
sc->cachelsz = csz * sizeof(u32); /* convert to bytes */
sc->opmode = NL80211_IFTYPE_STATION;
+ sc->bintval = 1000;
mutex_init(&sc->lock);
spin_lock_init(&sc->rxbuflock);
spin_lock_init(&sc->txbuflock);
@@ -2748,9 +2749,6 @@ static int ath5k_add_interface(struct ieee80211_hw *hw,
goto end;
}

- /* Set to a reasonable value. Note that this will
- * be set to mac80211's value at ath5k_config(). */
- sc->bintval = 1000;
ath5k_hw_set_lladdr(sc->ah, conf->mac_addr);

ret = 0;
--
1.6.3.2

2009-06-19 01:15:03

by Bob Copeland

Subject: Re: [ath5k-devel] [PATCH 1/1] ath5k: fix beacon_int handling

On Thu, Jun 18, 2009 at 7:06 PM, Jiri Slaby<[email protected]> wrote:
> 73ca5203366235f8a43e490767284ba8cfd8c479
> (ath5k: remove conf->beacon_int usage)
> removed bintval setting from ath5k_config. We need to init the
> interval earlier and don't touch it in add_interface anymore.
>
> Otherwise it will be set only once by upper layer through
> bss_info_changed but not on second and further hostap executions.

Shouldn't we just not destroy the value in add_interface?

I thought conf->beacon_int was deprecated.

--
Bob Copeland %% http://www.bobcopeland.com

2009-06-19 01:16:13

by Bob Copeland

Subject: Re: [ath5k-devel] [PATCH 1/1] ath5k: fix beacon_int handling

On Thu, Jun 18, 2009 at 9:14 PM, Bob Copeland<[email protected]> wrote:
>> Otherwise it will be set only once by upper layer through
>> bss_info_changed but not on second and further hostap executions.
>
> Shouldn't we just not destroy the value in add_interface?

Err, nevermind, that's exactly what your patch does.

--
Bob Copeland %% http://www.bobcopeland.com