2020-07-14 09:00:57

by Katsuhiro Suzuki

Subject: [PATCH] dt-bindings: sound: convert ROHM BD28623 amplifier binding to yaml

This patch converts ROHM BD28623UMV class D speaker amplifier binding
to DT schema.

Signed-off-by: Katsuhiro Suzuki <[email protected]>
---
.../bindings/sound/rohm,bd28623.txt | 29 ---------
.../bindings/sound/rohm,bd28623.yaml | 65 +++++++++++++++++++
2 files changed, 65 insertions(+), 29 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.txt
create mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.yaml

diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt b/Documentation/devicetree/bindings/sound/rohm,bd28623.txt
deleted file mode 100644
index d84557c2686e..000000000000
--- a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-ROHM BD28623MUV Class D speaker amplifier for digital input
-
-This codec does not have any control buses such as I2C, it detect format and
-rate of I2S signal automatically. It has two signals that can be connected
-to GPIOs: reset and mute.
-
-Required properties:
-- compatible : should be "rohm,bd28623"
-- #sound-dai-cells: should be 0.
-- VCCA-supply : regulator phandle for the VCCA supply
-- VCCP1-supply : regulator phandle for the VCCP1 supply
-- VCCP2-supply : regulator phandle for the VCCP2 supply
-
-Optional properties:
-- reset-gpios : GPIO specifier for the active low reset line
-- mute-gpios : GPIO specifier for the active low mute line
-
-Example:
-
- codec {
- compatible = "rohm,bd28623";
- #sound-dai-cells = <0>;
-
- VCCA-supply = <&vcc_reg>;
- VCCP1-supply = <&vcc_reg>;
- VCCP2-supply = <&vcc_reg>;
- reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
- mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
- };
diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
new file mode 100644
index 000000000000..acd8609252b4
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/rohm,bd28623.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ROHM BD28623MUV Class D speaker amplifier for digital input
+
+description:
+ This codec does not have any control buses such as I2C, it detect
+ format and rate of I2S signal automatically. It has two signals
+ that can be connected to GPIOs reset and mute.
+
+maintainers:
+ - Katsuhiro Suzuki <[email protected]>
+
+properties:
+ compatible:
+ const: rohm,bd28623
+
+ "#sound-dai-cells":
+ const: 0
+
+ VCCA-supply:
+ description:
+ regulator phandle for the VCCA (for analog) power supply
+
+ VCCP1-supply:
+ description:
+ regulator phandle for the VCCP1 (for ch1) power supply
+
+ VCCP2-supply:
+ description:
+ regulator phandle for the VCCP2 (for ch2) power supply
+
+ reset-gpios:
+ maxItems: 1
+ description:
+ GPIO specifier for the active low reset line
+
+ mute-gpios:
+ maxItems: 1
+ description:
+ GPIO specifier for the active low mute line
+
+required:
+ - compatible
+ - VCCA-supply
+ - VCCP1-supply
+ - VCCP2-supply
+ - "#sound-dai-cells"
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ codec {
+ compatible = "rohm,bd28623";
+ #sound-dai-cells = <0>;
+
+ VCCA-supply = <&vcc_reg>;
+ VCCP1-supply = <&vcc_reg>;
+ VCCP2-supply = <&vcc_reg>;
+ reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
+ mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
+ };
--
2.27.0

2020-07-21 02:15:42

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: sound: convert ROHM BD28623 amplifier binding to yaml

On Tue, Jul 14, 2020 at 05:09:59PM +0900, Katsuhiro Suzuki wrote:
> This patch converts ROHM BD28623UMV class D speaker amplifier binding
> to DT schema.
>
> Signed-off-by: Katsuhiro Suzuki <[email protected]>
> ---
> .../bindings/sound/rohm,bd28623.txt | 29 ---------
> .../bindings/sound/rohm,bd28623.yaml | 65 +++++++++++++++++++
> 2 files changed, 65 insertions(+), 29 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.txt
> create mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt b/Documentation/devicetree/bindings/sound/rohm,bd28623.txt
> deleted file mode 100644
> index d84557c2686e..000000000000
> --- a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt
> +++ /dev/null
> @@ -1,29 +0,0 @@
> -ROHM BD28623MUV Class D speaker amplifier for digital input
> -
> -This codec does not have any control buses such as I2C, it detect format and
> -rate of I2S signal automatically. It has two signals that can be connected
> -to GPIOs: reset and mute.
> -
> -Required properties:
> -- compatible : should be "rohm,bd28623"
> -- #sound-dai-cells: should be 0.
> -- VCCA-supply : regulator phandle for the VCCA supply
> -- VCCP1-supply : regulator phandle for the VCCP1 supply
> -- VCCP2-supply : regulator phandle for the VCCP2 supply
> -
> -Optional properties:
> -- reset-gpios : GPIO specifier for the active low reset line
> -- mute-gpios : GPIO specifier for the active low mute line
> -
> -Example:
> -
> - codec {
> - compatible = "rohm,bd28623";
> - #sound-dai-cells = <0>;
> -
> - VCCA-supply = <&vcc_reg>;
> - VCCP1-supply = <&vcc_reg>;
> - VCCP2-supply = <&vcc_reg>;
> - reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
> - mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> - };
> diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
> new file mode 100644
> index 000000000000..acd8609252b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/rohm,bd28623.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BD28623MUV Class D speaker amplifier for digital input
> +
> +description:
> + This codec does not have any control buses such as I2C, it detect
> + format and rate of I2S signal automatically. It has two signals
> + that can be connected to GPIOs reset and mute.
> +
> +maintainers:
> + - Katsuhiro Suzuki <[email protected]>
> +
> +properties:
> + compatible:
> + const: rohm,bd28623
> +
> + "#sound-dai-cells":
> + const: 0
> +
> + VCCA-supply:
> + description:
> + regulator phandle for the VCCA (for analog) power supply
> +
> + VCCP1-supply:
> + description:
> + regulator phandle for the VCCP1 (for ch1) power supply
> +
> + VCCP2-supply:
> + description:
> + regulator phandle for the VCCP2 (for ch2) power supply
> +
> + reset-gpios:
> + maxItems: 1
> + description:
> + GPIO specifier for the active low reset line
> +
> + mute-gpios:
> + maxItems: 1
> + description:
> + GPIO specifier for the active low mute line
> +
> +required:
> + - compatible
> + - VCCA-supply
> + - VCCP1-supply
> + - VCCP2-supply
> + - "#sound-dai-cells"

Needs an:

additionalProperties: false

With that,

Reviewed-by: Rob Herring <[email protected]>

> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + codec {
> + compatible = "rohm,bd28623";
> + #sound-dai-cells = <0>;
> +
> + VCCA-supply = <&vcc_reg>;
> + VCCP1-supply = <&vcc_reg>;
> + VCCP2-supply = <&vcc_reg>;
> + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
> + mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
> + };
> --
> 2.27.0
>

2020-07-22 18:10:51

by Katsuhiro Suzuki

Subject: Re: [PATCH] dt-bindings: sound: convert ROHM BD28623 amplifier binding to yaml

Hello Rob,

Thanks a lot for your review!

Best Regards,
Katsuhiro Suzuki

On 2020/07/21 11:12, Rob Herring wrote:
> On Tue, Jul 14, 2020 at 05:09:59PM +0900, Katsuhiro Suzuki wrote:
>> This patch converts ROHM BD28623UMV class D speaker amplifier binding
>> to DT schema.
>>
>> Signed-off-by: Katsuhiro Suzuki <[email protected]>
>> ---
>> .../bindings/sound/rohm,bd28623.txt | 29 ---------
>> .../bindings/sound/rohm,bd28623.yaml | 65 +++++++++++++++++++
>> 2 files changed, 65 insertions(+), 29 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.txt
>> create mode 100644 Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt b/Documentation/devicetree/bindings/sound/rohm,bd28623.txt
>> deleted file mode 100644
>> index d84557c2686e..000000000000
>> --- a/Documentation/devicetree/bindings/sound/rohm,bd28623.txt
>> +++ /dev/null
>> @@ -1,29 +0,0 @@
>> -ROHM BD28623MUV Class D speaker amplifier for digital input
>> -
>> -This codec does not have any control buses such as I2C, it detect format and
>> -rate of I2S signal automatically. It has two signals that can be connected
>> -to GPIOs: reset and mute.
>> -
>> -Required properties:
>> -- compatible : should be "rohm,bd28623"
>> -- #sound-dai-cells: should be 0.
>> -- VCCA-supply : regulator phandle for the VCCA supply
>> -- VCCP1-supply : regulator phandle for the VCCP1 supply
>> -- VCCP2-supply : regulator phandle for the VCCP2 supply
>> -
>> -Optional properties:
>> -- reset-gpios : GPIO specifier for the active low reset line
>> -- mute-gpios : GPIO specifier for the active low mute line
>> -
>> -Example:
>> -
>> - codec {
>> - compatible = "rohm,bd28623";
>> - #sound-dai-cells = <0>;
>> -
>> - VCCA-supply = <&vcc_reg>;
>> - VCCP1-supply = <&vcc_reg>;
>> - VCCP2-supply = <&vcc_reg>;
>> - reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
>> - mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
>> - };
>> diff --git a/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
>> new file mode 100644
>> index 000000000000..acd8609252b4
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/rohm,bd28623.yaml
>> @@ -0,0 +1,65 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/rohm,bd28623.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ROHM BD28623MUV Class D speaker amplifier for digital input
>> +
>> +description:
>> + This codec does not have any control buses such as I2C, it detect
>> + format and rate of I2S signal automatically. It has two signals
>> + that can be connected to GPIOs reset and mute.
>> +
>> +maintainers:
>> + - Katsuhiro Suzuki <[email protected]>
>> +
>> +properties:
>> + compatible:
>> + const: rohm,bd28623
>> +
>> + "#sound-dai-cells":
>> + const: 0
>> +
>> + VCCA-supply:
>> + description:
>> + regulator phandle for the VCCA (for analog) power supply
>> +
>> + VCCP1-supply:
>> + description:
>> + regulator phandle for the VCCP1 (for ch1) power supply
>> +
>> + VCCP2-supply:
>> + description:
>> + regulator phandle for the VCCP2 (for ch2) power supply
>> +
>> + reset-gpios:
>> + maxItems: 1
>> + description:
>> + GPIO specifier for the active low reset line
>> +
>> + mute-gpios:
>> + maxItems: 1
>> + description:
>> + GPIO specifier for the active low mute line
>> +
>> +required:
>> + - compatible
>> + - VCCA-supply
>> + - VCCP1-supply
>> + - VCCP2-supply
>> + - "#sound-dai-cells"
>
> Needs an:
>
> additionalProperties: false
>
> With that,
>
> Reviewed-by: Rob Herring <[email protected]>
>
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/gpio/gpio.h>
>> + codec {
>> + compatible = "rohm,bd28623";
>> + #sound-dai-cells = <0>;
>> +
>> + VCCA-supply = <&vcc_reg>;
>> + VCCP1-supply = <&vcc_reg>;
>> + VCCP2-supply = <&vcc_reg>;
>> + reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>;
>> + mute-gpios = <&gpio 1 GPIO_ACTIVE_LOW>;
>> + };
>> --
>> 2.27.0
>>