2023-03-30 15:02:23

by srinivas pandruvada

Subject: [PATCH] platform/x86: intel-uncore-freq: Add client processors

Make Intel uncore frequency driver support to client processor starting
from Alder Lake.

Signed-off-by: Srinivas Pandruvada <[email protected]>
---
.../platform/x86/intel/uncore-frequency/uncore-frequency.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
index 00ac7e381441..32e2515ee366 100644
--- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
+++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
@@ -204,6 +204,13 @@ static const struct x86_cpu_id intel_uncore_cpu_ids[] = {
X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
X86_MATCH_INTEL_FAM6_MODEL(EMERALDRAPIDS_X, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_S, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE, NULL),
+ X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE_L, NULL),
{}
};
MODULE_DEVICE_TABLE(x86cpu, intel_uncore_cpu_ids);
--
2.39.1

2023-04-06 11:11:54

by Hans de Goede

Subject: Re: [PATCH] platform/x86: intel-uncore-freq: Add client processors

Hi Srinivas,

On 3/30/23 16:59, Srinivas Pandruvada wrote:
> Make Intel uncore frequency driver support to client processor starting
> from Alder Lake.
>
> Signed-off-by: Srinivas Pandruvada <[email protected]>

I assume that this is independent from the
"[PATCH] platform/x86/intel-uncore-freq: Uncore frequency control via TPMI"
changes ?

(just double checking before I merge this).

Regards,

Hans



> ---
> .../platform/x86/intel/uncore-frequency/uncore-frequency.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> index 00ac7e381441..32e2515ee366 100644
> --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> @@ -204,6 +204,13 @@ static const struct x86_cpu_id intel_uncore_cpu_ids[] = {
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(EMERALDRAPIDS_X, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_S, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE_L, NULL),
> {}
> };
> MODULE_DEVICE_TABLE(x86cpu, intel_uncore_cpu_ids);

2023-04-06 18:17:20

by srinivas pandruvada

Subject: Re: [PATCH] platform/x86: intel-uncore-freq: Add client processors

Hi Hans,

On Thu, 2023-04-06 at 12:58 +0200, Hans de Goede wrote:
> Hi Srinivas,
>
> On 3/30/23 16:59, Srinivas Pandruvada wrote:
> > Make Intel uncore frequency driver support to client processor
> > starting
> > from Alder Lake.
> >
> > Signed-off-by: Srinivas Pandruvada
> > <[email protected]>
>
> I assume that this is independent from the
> "[PATCH] platform/x86/intel-uncore-freq: Uncore frequency control via
> TPMI"
> changes ?
>
Yes this is independent and there is no TPMI dependency.


Thanks,
Srinivas

> (just double checking before I merge this).
>
> Regards,
>
> Hans
>
>
>
> > ---
> >  .../platform/x86/intel/uncore-frequency/uncore-frequency.c | 7
> > +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-
> > frequency.c b/drivers/platform/x86/intel/uncore-frequency/uncore-
> > frequency.c
> > index 00ac7e381441..32e2515ee366 100644
> > --- a/drivers/platform/x86/intel/uncore-frequency/uncore-
> > frequency.c
> > +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-
> > frequency.c
> > @@ -204,6 +204,13 @@ static const struct x86_cpu_id
> > intel_uncore_cpu_ids[] = {
> >         X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D,   NULL),
> >         X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
> >         X86_MATCH_INTEL_FAM6_MODEL(EMERALDRAPIDS_X, NULL),
> > +       X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, NULL),
> > +       X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, NULL),
> > +       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE, NULL),
> > +       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, NULL),
> > +       X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_S, NULL),
> > +       X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE, NULL),
> > +       X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE_L, NULL),
> >         {}
> >  };
> >  MODULE_DEVICE_TABLE(x86cpu, intel_uncore_cpu_ids);
>

2023-04-07 13:29:48

by Hans de Goede

Subject: Re: [PATCH] platform/x86: intel-uncore-freq: Add client processors

Hi,

On 3/30/23 16:59, Srinivas Pandruvada wrote:
> Make Intel uncore frequency driver support to client processor starting
> from Alder Lake.
>
> Signed-off-by: Srinivas Pandruvada <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
> .../platform/x86/intel/uncore-frequency/uncore-frequency.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> index 00ac7e381441..32e2515ee366 100644
> --- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> +++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency.c
> @@ -204,6 +204,13 @@ static const struct x86_cpu_id intel_uncore_cpu_ids[] = {
> X86_MATCH_INTEL_FAM6_MODEL(ICELAKE_D, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X, NULL),
> X86_MATCH_INTEL_FAM6_MODEL(EMERALDRAPIDS_X, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_S, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE, NULL),
> + X86_MATCH_INTEL_FAM6_MODEL(METEORLAKE_L, NULL),
> {}
> };
> MODULE_DEVICE_TABLE(x86cpu, intel_uncore_cpu_ids);