2023-02-16 11:19:16

by ChiaEn Wu

[permalink] [raw]
Subject: [PATCH v2][next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name

Revise RT9467 compatible name from "richtek,rt9467-charger" to
"richtek,rt9467" because it has to match the "compatible name" in
the source code.

Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
Signed-off-by: ChiaEn Wu <[email protected]>
---
v2:
- Add more description about this change in the commit message.
- Rename "richtek,rt9467-charger.yaml" to "richtek,rt9467.yaml".
- Rename "$id" as above.

---
.../power/supply/richtek,rt9467-charger.yaml | 82 ----------------------
.../bindings/power/supply/richtek,rt9467.yaml | 82 ++++++++++++++++++++++
2 files changed, 82 insertions(+), 82 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
create mode 100644 Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml

diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
deleted file mode 100644
index 92c5706..00000000
--- a/Documentation/devicetree/bindings/power/supply/richtek,rt9467-charger.yaml
+++ /dev/null
@@ -1,82 +0,0 @@
-# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/power/supply/richtek,rt9467-charger.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: Richtek RT9467 Switching Battery Charger with Power Path Management
-
-maintainers:
- - ChiYuan Huang <[email protected]>
- - ChiaEn Wu <[email protected]>
-
-description: |
- RT9467 is a switch-mode single cell Li-Ion/Li-Polymer battery charger for
- portable applications. It integrates a synchronous PWM controller, power
- MOSFETs, input current sensing and regulation, high-accuracy voltage
- regulation, and charge termination. The charge current is regulated through
- integrated sensing resistors.
-
- The RT9467 also features USB On-The-Go (OTG) support. It also integrates
- D+/D- pin for USB host/charging port detection.
-
- Datasheet is available at
- https://www.richtek.com/assets/product_file/RT9467/DS9467-01.pdf
-
-properties:
- compatible:
- const: richtek,rt9467-charger
-
- reg:
- maxItems: 1
-
- wakeup-source: true
-
- interrupts:
- maxItems: 1
-
- charge-enable-gpios:
- description: GPIO is used to turn on and off charging.
- maxItems: 1
-
- usb-otg-vbus-regulator:
- type: object
- description: OTG boost regulator.
- unevaluatedProperties: false
- $ref: /schemas/regulator/regulator.yaml#
-
- properties:
- enable-gpios: true
-
-required:
- - compatible
- - reg
- - wakeup-source
- - interrupts
-
-additionalProperties: false
-
-examples:
- - |
- #include <dt-bindings/interrupt-controller/irq.h>
- #include <dt-bindings/gpio/gpio.h>
- i2c {
- #address-cells = <1>;
- #size-cells = <0>;
-
- charger@5b {
- compatible = "richtek,rt9467-charger";
- reg = <0x5b>;
- wakeup-source;
- interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>;
- charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_LOW>;
-
- rt9467_otg_vbus: usb-otg-vbus-regulator {
- regulator-name = "rt9467-usb-otg-vbus";
- regulator-min-microvolt = <4425000>;
- regulator-max-microvolt = <5825000>;
- regulator-min-microamp = <500000>;
- regulator-max-microamp = <3000000>;
- };
- };
- };
diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml
new file mode 100644
index 00000000..3723717
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml
@@ -0,0 +1,82 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/supply/richtek,rt9467.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Richtek RT9467 Switching Battery Charger with Power Path Management
+
+maintainers:
+ - ChiYuan Huang <[email protected]>
+ - ChiaEn Wu <[email protected]>
+
+description: |
+ RT9467 is a switch-mode single cell Li-Ion/Li-Polymer battery charger for
+ portable applications. It integrates a synchronous PWM controller, power
+ MOSFETs, input current sensing and regulation, high-accuracy voltage
+ regulation, and charge termination. The charge current is regulated through
+ integrated sensing resistors.
+
+ The RT9467 also features USB On-The-Go (OTG) support. It also integrates
+ D+/D- pin for USB host/charging port detection.
+
+ Datasheet is available at
+ https://www.richtek.com/assets/product_file/RT9467/DS9467-01.pdf
+
+properties:
+ compatible:
+ const: richtek,rt9467
+
+ reg:
+ maxItems: 1
+
+ wakeup-source: true
+
+ interrupts:
+ maxItems: 1
+
+ charge-enable-gpios:
+ description: GPIO is used to turn on and off charging.
+ maxItems: 1
+
+ usb-otg-vbus-regulator:
+ type: object
+ description: OTG boost regulator.
+ unevaluatedProperties: false
+ $ref: /schemas/regulator/regulator.yaml#
+
+ properties:
+ enable-gpios: true
+
+required:
+ - compatible
+ - reg
+ - wakeup-source
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/gpio/gpio.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ charger@5b {
+ compatible = "richtek,rt9467";
+ reg = <0x5b>;
+ wakeup-source;
+ interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>;
+ charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_LOW>;
+
+ rt9467_otg_vbus: usb-otg-vbus-regulator {
+ regulator-name = "rt9467-usb-otg-vbus";
+ regulator-min-microvolt = <4425000>;
+ regulator-max-microvolt = <5825000>;
+ regulator-min-microamp = <500000>;
+ regulator-max-microamp = <3000000>;
+ };
+ };
+ };
--
2.7.4



2023-02-16 13:24:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2][next] dt-bindings: power: supply: Revise Richtek RT9467 compatible name

On 16/02/2023 12:17, ChiaEn Wu wrote:
> Revise RT9467 compatible name from "richtek,rt9467-charger" to
> "richtek,rt9467" because it has to match the "compatible name" in
> the source code.
>
> Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger")
> Signed-off-by: ChiaEn Wu <[email protected]>
> ---
> v2:
> - Add more description about this change in the commit message.
> - Rename "richtek,rt9467-charger.yaml" to "richtek,rt9467.yaml".
> - Rename "$id" as above.

Thanks for the change, but the patch was not created correctly - there
is no indication of rename thus it's very difficult to review. Please
use correct patch-generation arguments. For git, "git format-patch"
should be enough. If it is not enough, then play with -M argument. If it
is still wrong, play with -M and -B.

If you use other tools - investigate your tools to create proper rename
diff.

Best regards,
Krzysztof