2023-06-02 01:35:41

by John Hubbard

Subject: [PATCH 01/12] selftests/mm: fix uffd-stress unused function warning

uffd_minor_feature() was unused. Remove it in order to fix the
associated clang build warning.

Signed-off-by: John Hubbard <[email protected]>
---
tools/testing/selftests/mm/uffd-stress.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c
index f1ad9eef1c3a..995ff13e74c7 100644
--- a/tools/testing/selftests/mm/uffd-stress.c
+++ b/tools/testing/selftests/mm/uffd-stress.c
@@ -88,16 +88,6 @@ static void uffd_stats_reset(struct uffd_args *args, unsigned long n_cpus)
}
}

-static inline uint64_t uffd_minor_feature(void)
-{
- if (test_type == TEST_HUGETLB && map_shared)
- return UFFD_FEATURE_MINOR_HUGETLBFS;
- else if (test_type == TEST_SHMEM)
- return UFFD_FEATURE_MINOR_SHMEM;
- else
- return 0;
-}
-
static void *locking_thread(void *arg)
{
unsigned long cpu = (unsigned long) arg;
--
2.40.1

2023-06-02 10:19:49

by David Hildenbrand

Subject: Re: [PATCH 01/12] selftests/mm: fix uffd-stress unused function warning

On 02.06.23 03:33, John Hubbard wrote:
> uffd_minor_feature() was unused. Remove it in order to fix the
> associated clang build warning.
>
> Signed-off-by: John Hubbard <[email protected]>
> ---
> tools/testing/selftests/mm/uffd-stress.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/uffd-stress.c b/tools/testing/selftests/mm/uffd-stress.c
> index f1ad9eef1c3a..995ff13e74c7 100644
> --- a/tools/testing/selftests/mm/uffd-stress.c
> +++ b/tools/testing/selftests/mm/uffd-stress.c
> @@ -88,16 +88,6 @@ static void uffd_stats_reset(struct uffd_args *args, unsigned long n_cpus)
> }
> }
>
> -static inline uint64_t uffd_minor_feature(void)
> -{
> - if (test_type == TEST_HUGETLB && map_shared)
> - return UFFD_FEATURE_MINOR_HUGETLBFS;
> - else if (test_type == TEST_SHMEM)
> - return UFFD_FEATURE_MINOR_SHMEM;
> - else
> - return 0;
> -}
> -
> static void *locking_thread(void *arg)
> {
> unsigned long cpu = (unsigned long) arg;


Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2023-06-02 15:39:54

by Peter Xu

Subject: Re: [PATCH 01/12] selftests/mm: fix uffd-stress unused function warning

On Thu, Jun 01, 2023 at 06:33:47PM -0700, John Hubbard wrote:
> uffd_minor_feature() was unused. Remove it in order to fix the
> associated clang build warning.
>
> Signed-off-by: John Hubbard <[email protected]>

Reviewed-by: Peter Xu <[email protected]>

--
Peter Xu