2022-11-12 16:06:32

by Aidan MacDonald

[permalink] [raw]
Subject: [PATCH] irqchip: sl28cpld: Replace irqchip mask_invert with unmask_base

Remove use of the deprecated mask_invert flag. Inverted mask
registers (where a '1' bit enables an IRQ) can be described more
directly as an unmask register.

Signed-off-by: Aidan MacDonald <[email protected]>
---
drivers/irqchip/irq-sl28cpld.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-sl28cpld.c b/drivers/irqchip/irq-sl28cpld.c
index fbb354413ffa..f2172240172c 100644
--- a/drivers/irqchip/irq-sl28cpld.c
+++ b/drivers/irqchip/irq-sl28cpld.c
@@ -65,8 +65,7 @@ static int sl28cpld_intc_probe(struct platform_device *pdev)
irqchip->chip.num_irqs = ARRAY_SIZE(sl28cpld_irqs);
irqchip->chip.num_regs = 1;
irqchip->chip.status_base = base + INTC_IP;
- irqchip->chip.mask_base = base + INTC_IE;
- irqchip->chip.mask_invert = true;
+ irqchip->chip.unmask_base = base + INTC_IE;
irqchip->chip.ack_base = base + INTC_IP;

return devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),
--
2.38.1



2022-11-16 07:16:01

by Michael Walle

[permalink] [raw]
Subject: Re: [PATCH] irqchip: sl28cpld: Replace irqchip mask_invert with unmask_base

Am 2022-11-12 16:27, schrieb Aidan MacDonald:
> Remove use of the deprecated mask_invert flag. Inverted mask
> registers (where a '1' bit enables an IRQ) can be described more
> directly as an unmask register.
>
> Signed-off-by: Aidan MacDonald <[email protected]>

Reviewed-by: Michael Walle <[email protected]>

Thanks,
-michael

Subject: [irqchip: irq/irqchip-next] irqchip/sl28cpld: Replace irqchip mask_invert with unmask_base

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: d502c558fd2b190c9125e8da54bef3f302fa9b15
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d502c558fd2b190c9125e8da54bef3f302fa9b15
Author: Aidan MacDonald <[email protected]>
AuthorDate: Sat, 12 Nov 2022 15:27:01
Committer: Marc Zyngier <[email protected]>
CommitterDate: Sat, 26 Nov 2022 13:29:52

irqchip/sl28cpld: Replace irqchip mask_invert with unmask_base

Remove use of the deprecated mask_invert flag. Inverted mask
registers (where a '1' bit enables an IRQ) can be described more
directly as an unmask register.

Signed-off-by: Aidan MacDonald <[email protected]>
Reviewed-by: Michael Walle <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-sl28cpld.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-sl28cpld.c b/drivers/irqchip/irq-sl28cpld.c
index fbb3544..f217224 100644
--- a/drivers/irqchip/irq-sl28cpld.c
+++ b/drivers/irqchip/irq-sl28cpld.c
@@ -65,8 +65,7 @@ static int sl28cpld_intc_probe(struct platform_device *pdev)
irqchip->chip.num_irqs = ARRAY_SIZE(sl28cpld_irqs);
irqchip->chip.num_regs = 1;
irqchip->chip.status_base = base + INTC_IP;
- irqchip->chip.mask_base = base + INTC_IE;
- irqchip->chip.mask_invert = true;
+ irqchip->chip.unmask_base = base + INTC_IE;
irqchip->chip.ack_base = base + INTC_IP;

return devm_regmap_add_irq_chip_fwnode(dev, dev_fwnode(dev),