2023-12-11 00:13:41

by Gary Rookard

[permalink] [raw]
Subject: [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other

Hi,

This patch series renames (5) different variables with
the checkpatch coding style issue, Avoid CamelCase.

Patch 1/5) rename variable HTIOTActDetermineRaFunc
Patch 2/5) rename variable HTResetIOTSetting
Patch 3/5) rename variable HTConstructCapabilityElement
Patch 4/5) rename variable HTConstructRT2RTAggElement
Patch 5/5) rename variable HT_PickMCSRate

Signed-off-by: Gary Rookard <[email protected]>

Gary Rookard (5):
staging: rtl8192e: rename variable HTIOTActDetermineRaFunc
staging: rtl8192e: rename variable HTResetIOTSetting
staging: rtl8192e: rename variable HTConstructCapabilityElement
staging: rtl8192e: rename variable HTConstructRT2RTAggElement
staging: rtl8192e: rename variable HT_PickMCSRate

drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +++++++-------
drivers/staging/rtl8192e/rtllib.h | 6 +++---
drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
3 files changed, 13 insertions(+), 13 deletions(-)

--
2.41.0


2023-12-11 00:13:41

by Gary Rookard

[permalink] [raw]
Subject: [PATCH 3/5] staging: rtl8192e: rename variable HTConstructCapabilityElement

Coding style issue, checkpatch Avoid CamelCase,
rename it. HTConstructCapabilityElement -> ht_construct_capability_element

Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 2a3cb6434100..c2c7fc316f62 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -247,7 +247,7 @@ void ht_reset_iot_setting(struct rt_hi_throughput *ht_info)
ht_info->iot_ra_func = 0;
}

-void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
+void ht_construct_capability_element(struct rtllib_device *ieee, u8 *posHTCap,
u8 *len, u8 IsEncrypt, bool bAssoc)
{
struct rt_hi_throughput *pHT = ieee->ht_info;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index e8c795faf4f9..ff3ba9bca023 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1755,7 +1755,7 @@ void HTSetConnectBwMode(struct rtllib_device *ieee,
enum ht_channel_width bandwidth,
enum ht_extchnl_offset Offset);
void ht_update_default_setting(struct rtllib_device *ieee);
-void HTConstructCapabilityElement(struct rtllib_device *ieee,
+void ht_construct_capability_element(struct rtllib_device *ieee,
u8 *posHTCap, u8 *len,
u8 isEncrypt, bool bAssoc);
void HTConstructRT2RTAggElement(struct rtllib_device *ieee,
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 296c2ca643e8..9e9725ed8fa0 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -733,7 +733,7 @@ rtllib_association_req(struct rtllib_network *beacon,
if (ieee->ht_info->current_ht_support && ieee->ht_info->enable_ht) {
ht_cap_buf = (u8 *)&(ieee->ht_info->SelfHTCap);
ht_cap_len = sizeof(ieee->ht_info->SelfHTCap);
- HTConstructCapabilityElement(ieee, ht_cap_buf, &ht_cap_len,
+ ht_construct_capability_element(ieee, ht_cap_buf, &ht_cap_len,
encrypt, true);
if (ieee->ht_info->current_rt2rt_aggregation) {
realtek_ie_buf = ieee->ht_info->sz_rt2rt_agg_buf;
--
2.41.0

2023-12-11 00:13:50

by Gary Rookard

[permalink] [raw]
Subject: [PATCH 4/5] staging: rtl8192e: rename variable HTConstructRT2RTAggElement

Coding style issue, checkpatch Avoid CamelCase,
rename it. HTConstructRT2RTAggElement -> ht_construct_rt2rt_agg_element

Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index c2c7fc316f62..a374f4c9f17e 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -328,7 +328,7 @@ void ht_construct_capability_element(struct rtllib_device *ieee, u8 *posHTCap,
}
}

-void HTConstructRT2RTAggElement(struct rtllib_device *ieee, u8 *posRT2RTAgg,
+void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg,
u8 *len)
{
if (!posRT2RTAgg) {
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index ff3ba9bca023..0d6144548c34 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -1758,7 +1758,7 @@ void ht_update_default_setting(struct rtllib_device *ieee);
void ht_construct_capability_element(struct rtllib_device *ieee,
u8 *posHTCap, u8 *len,
u8 isEncrypt, bool bAssoc);
-void HTConstructRT2RTAggElement(struct rtllib_device *ieee,
+void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee,
u8 *posRT2RTAgg, u8 *len);
void HTOnAssocRsp(struct rtllib_device *ieee);
void HTInitializeHTInfo(struct rtllib_device *ieee);
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 9e9725ed8fa0..31a072e2a6d7 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -739,7 +739,7 @@ rtllib_association_req(struct rtllib_network *beacon,
realtek_ie_buf = ieee->ht_info->sz_rt2rt_agg_buf;
realtek_ie_len =
sizeof(ieee->ht_info->sz_rt2rt_agg_buf);
- HTConstructRT2RTAggElement(ieee, realtek_ie_buf,
+ ht_construct_rt2rt_agg_element(ieee, realtek_ie_buf,
&realtek_ie_len);
}
}
--
2.41.0

2023-12-11 00:14:10

by Gary Rookard

[permalink] [raw]
Subject: [PATCH 5/5] staging: rtl8192e: rename variable HT_PickMCSRate

Coding style issue, checkpatch Avoid CamelCase,
rename it. HT_PickMCSRate -> ht_pick_mcs_rate

Signed-off-by: Gary Rookard <[email protected]>
---
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index a374f4c9f17e..14e25f87c1bf 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -350,7 +350,7 @@ void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg,
*len = 6 + 2;
}

-static u8 HT_PickMCSRate(struct rtllib_device *ieee, u8 *pOperateMCS)
+static u8 ht_pick_mcs_rate(struct rtllib_device *ieee, u8 *pOperateMCS)
{
u8 i;

@@ -426,7 +426,7 @@ static u8 HTFilterMCSRate(struct rtllib_device *ieee, u8 *pSupportMCS,
pOperateMCS[i] = ieee->reg_dot11tx_ht_oper_rate_set[i] &
pSupportMCS[i];

- HT_PickMCSRate(ieee, pOperateMCS);
+ ht_pick_mcs_rate(ieee, pOperateMCS);

if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev))
pOperateMCS[1] = 0;
--
2.41.0

2023-12-11 18:54:41

by Philipp Hortmann

[permalink] [raw]
Subject: Re: [PATCH 0/5] [Series 1] rename variable HTIOTActDetermineRaFunc and (4) other

On 12/11/23 01:13, Gary Rookard wrote:
> Hi,
>
> This patch series renames (5) different variables with
> the checkpatch coding style issue, Avoid CamelCase.
>
> Patch 1/5) rename variable HTIOTActDetermineRaFunc
> Patch 2/5) rename variable HTResetIOTSetting
> Patch 3/5) rename variable HTConstructCapabilityElement
> Patch 4/5) rename variable HTConstructRT2RTAggElement
> Patch 5/5) rename variable HT_PickMCSRate
>
> Signed-off-by: Gary Rookard <[email protected]>
>
> Gary Rookard (5):
> staging: rtl8192e: rename variable HTIOTActDetermineRaFunc
> staging: rtl8192e: rename variable HTResetIOTSetting
> staging: rtl8192e: rename variable HTConstructCapabilityElement
> staging: rtl8192e: rename variable HTConstructRT2RTAggElement
> staging: rtl8192e: rename variable HT_PickMCSRate
>
> drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +++++++-------
> drivers/staging/rtl8192e/rtllib.h | 6 +++---
> drivers/staging/rtl8192e/rtllib_softmac.c | 6 +++---
> 3 files changed, 13 insertions(+), 13 deletions(-)
>

Compiled and tested on hardware -> OK