2023-05-20 05:46:07

by Leonardo Bras

Subject: [RFC PATCH v2 0/3] Move usages of struct __call_single_data to call_single_data_t

Changes since RFCv1:
- request->csd moved to the middle of the struct, without size impact
- type change happens in a different patch (thanks Jens Axboe!)
- Improved the third patch to also update the .h file.

Leonardo Bras (3):
blk-mq: Move csd inside struct request so it's 32-byte aligned
blk-mq: Change request->csd type to call_single_data_t
smp: Change signatures to use call_single_data_t

include/linux/blk-mq.h | 10 +++++-----
include/linux/smp.h | 2 +-
kernel/smp.c | 4 ++--
kernel/up.c | 2 +-
4 files changed, 9 insertions(+), 9 deletions(-)

--
2.40.1

2023-06-13 04:15:36

by Leonardo Bras

Subject: Re: [RFC PATCH v2 0/3] Move usages of struct __call_single_data to call_single_data_t

Friendly ping

On Sat, May 20, 2023 at 2:30 AM Leonardo Bras <[email protected]> wrote:
>
> Changes since RFCv1:
> - request->csd moved to the middle of the struct, without size impact
> - type change happens in a different patch (thanks Jens Axboe!)
> - Improved the third patch to also update the .h file.
>
> Leonardo Bras (3):
> blk-mq: Move csd inside struct request so it's 32-byte aligned
> blk-mq: Change request->csd type to call_single_data_t
> smp: Change signatures to use call_single_data_t
>
> include/linux/blk-mq.h | 10 +++++-----
> include/linux/smp.h | 2 +-
> kernel/smp.c | 4 ++--
> kernel/up.c | 2 +-
> 4 files changed, 9 insertions(+), 9 deletions(-)
>
> --
> 2.40.1
>

2023-07-04 07:45:39

by Leonardo Bras

Subject: Re: [RFC PATCH v2 0/3] Move usages of struct __call_single_data to call_single_data_t

On Tue, 2023-06-13 at 00:51 -0300, Leonardo Bras Soares Passos wrote:
> Friendly ping
>
> On Sat, May 20, 2023 at 2:30 AM Leonardo Bras <[email protected]> wrote:
> >
> > Changes since RFCv1:
> > - request->csd moved to the middle of the struct, without size impact
> > - type change happens in a different patch (thanks Jens Axboe!)
> > - Improved the third patch to also update the .h file.
> >
> > Leonardo Bras (3):
> > blk-mq: Move csd inside struct request so it's 32-byte aligned
> > blk-mq: Change request->csd type to call_single_data_t
> > smp: Change signatures to use call_single_data_t
> >
> > include/linux/blk-mq.h | 10 +++++-----
> > include/linux/smp.h | 2 +-
> > kernel/smp.c | 4 ++--
> > kernel/up.c | 2 +-
> > 4 files changed, 9 insertions(+), 9 deletions(-)
> >
> > --
> > 2.40.1
> >

Hello Jens,

I still want your feedback on this series :)

I think I addressed every issue of RFCv1, but if you have any other feedback,
please let me know.

Thanks!
Leo