2010-01-16 22:52:30

by Thiago Farina

Subject: [PATCH] console/vgacon.c: mark file-local symbol static.

warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?

Signed-off-by: Thiago Farina <[email protected]>
---
drivers/video/console/vgacon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index cc4bbbe..19e474d 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -112,7 +112,7 @@ static int vga_video_font_height;
static int vga_scan_lines __read_mostly;
static unsigned int vga_rolled_over;

-int vgacon_text_mode_force = 0;
+static int vgacon_text_mode_force = 0;

bool vgacon_text_force(void)
{
--
1.6.6.103.g699d2

2010-01-17 01:18:27

by Matthew Garrett

Subject: Re: [PATCH] console/vgacon.c: mark file-local symbol static.

On Sat, Jan 16, 2010 at 05:52:13PM -0500, Thiago Farina wrote:
> warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <[email protected]>
> ---
> drivers/video/console/vgacon.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
> index cc4bbbe..19e474d 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -112,7 +112,7 @@ static int vga_video_font_height;
> static int vga_scan_lines __read_mostly;
> static unsigned int vga_rolled_over;
>
> -int vgacon_text_mode_force = 0;
> +static int vgacon_text_mode_force = 0;

Should probably lose the assignment while we're at it?

--
Matthew Garrett | [email protected]

2010-01-17 13:36:46

by Thiago Farina

Subject: [PATCH] console/vgacon.c: mark file-local symbol static.

warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?

Signed-off-by: Thiago Farina <[email protected]>
---
drivers/video/console/vgacon.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index cc4bbbe..182dd6f 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -112,7 +112,7 @@ static int vga_video_font_height;
static int vga_scan_lines __read_mostly;
static unsigned int vga_rolled_over;

-int vgacon_text_mode_force = 0;
+static int vgacon_text_mode_force;

bool vgacon_text_force(void)
{
--
1.6.6.103.g699d2

2010-01-17 19:31:16

by Matthew Garrett

Subject: Re: [PATCH] console/vgacon.c: mark file-local symbol static.

On Sun, Jan 17, 2010 at 08:36:36AM -0500, Thiago Farina wrote:
> warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <[email protected]>
Acked-by: Matthew Garrett <[email protected]>

--
Matthew Garrett | [email protected]