2017-08-27 06:05:38

by Arvind Yadav

Subject: [PATCH] staging: lustre: constify cl_lock_operations

cl_lock_operations are not supposed to change at runtime.
cl_lock_slice_add is working with const cl_lock_operations.
So mark the non-const cl_lock_operations structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/lustre/lustre/obdecho/echo_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/staging/lustre/lustre/obdecho/echo_client.c
index 1c4a8fe..b3fbc3c 100644
--- a/drivers/staging/lustre/lustre/obdecho/echo_client.c
+++ b/drivers/staging/lustre/lustre/obdecho/echo_client.c
@@ -319,7 +319,7 @@ static void echo_lock_fini(const struct lu_env *env,
kmem_cache_free(echo_lock_kmem, ecl);
}

-static struct cl_lock_operations echo_lock_ops = {
+static const struct cl_lock_operations echo_lock_ops = {
.clo_fini = echo_lock_fini,
};

--
2.7.4

2017-08-28 08:24:40

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: lustre: constify cl_lock_operations

On Sun, Aug 27, 2017 at 11:35:27AM +0530, Arvind Yadav wrote:
> cl_lock_operations are not supposed to change at runtime.
> cl_lock_slice_add is working with const cl_lock_operations.
> So mark the non-const cl_lock_operations structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/staging/lustre/lustre/obdecho/echo_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Someone else already sent this same patch in, and it's already applied
in my tree :(