2023-09-22 16:33:15

by Rohit Agarwal

[permalink] [raw]
Subject: [PATCH v4 0/5] Add USB Support on Qualcomm's SDX75 Platform

Hi,

Changes in v4:
- Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.

Changes in v3:
- Removed the unnecessary change introduced in v2 of patch 2/5
- Added Fixes tag in patch 3/5
- Rebased patch 5/5 on Dmitry's cleanup patches.
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/linux-phy/[email protected]/

Changes in v2:
- Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
and reusing the bindings.
- Rephrased the commit message of patch 3/5
- Removed stray lines from the patch 5/5

This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.

Thanks,
Rohit.


Rohit Agarwal (5):
dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75
dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY
dt-bindings: usb: qcom,dwc3: Fix SDX65 clocks
dt-bindings: usb: dwc3: Add SDX75 compatible
phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support

.../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 2 +
.../bindings/phy/qcom,snps-eusb2-phy.yaml | 7 +-
.../devicetree/bindings/usb/qcom,dwc3.yaml | 4 +
drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 173 +++++++++++++++++++++
4 files changed, 185 insertions(+), 1 deletion(-)

--
2.7.4


2023-10-13 10:29:23

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] Add USB Support on Qualcomm's SDX75 Platform

On 22-09-23, 10:42, Rohit Agarwal wrote:
> Hi,
>
> Changes in v4:
> - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
>
> Changes in v3:
> - Removed the unnecessary change introduced in v2 of patch 2/5
> - Added Fixes tag in patch 3/5
> - Rebased patch 5/5 on Dmitry's cleanup patches.
> https://lore.kernel.org/all/[email protected]/
> https://lore.kernel.org/linux-phy/[email protected]/
>
> Changes in v2:
> - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
> and reusing the bindings.
> - Rephrased the commit message of patch 3/5
> - Removed stray lines from the patch 5/5
>
> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.

The phy patches fail to apply, can you please rebase the three patches
and resend

--
~Vinod

2023-10-13 10:40:07

by Rohit Agarwal

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] Add USB Support on Qualcomm's SDX75 Platform


On 10/13/2023 3:59 PM, Vinod Koul wrote:
> On 22-09-23, 10:42, Rohit Agarwal wrote:
>> Hi,
>>
>> Changes in v4:
>> - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
>>
>> Changes in v3:
>> - Removed the unnecessary change introduced in v2 of patch 2/5
>> - Added Fixes tag in patch 3/5
>> - Rebased patch 5/5 on Dmitry's cleanup patches.
>> https://lore.kernel.org/all/[email protected]/
>> https://lore.kernel.org/linux-phy/[email protected]/
>>
>> Changes in v2:
>> - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
>> and reusing the bindings.
>> - Rephrased the commit message of patch 3/5
>> - Removed stray lines from the patch 5/5
>>
>> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.
> The phy patches fail to apply, can you please rebase the three patches
> and resend
Can you please apply these two series. This series depends on it for
successful compilation.
[1]
https://lore.kernel.org/all/[email protected]/
[2]
https://lore.kernel.org/linux-phy/[email protected]/

Thanks,
Rohit.

2023-10-13 10:46:01

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] Add USB Support on Qualcomm's SDX75 Platform

On 13-10-23, 16:08, Rohit Agarwal wrote:
>
> On 10/13/2023 3:59 PM, Vinod Koul wrote:
> > On 22-09-23, 10:42, Rohit Agarwal wrote:
> > > Hi,
> > >
> > > Changes in v4:
> > > - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
> > >
> > > Changes in v3:
> > > - Removed the unnecessary change introduced in v2 of patch 2/5
> > > - Added Fixes tag in patch 3/5
> > > - Rebased patch 5/5 on Dmitry's cleanup patches.
> > > https://lore.kernel.org/all/[email protected]/
> > > https://lore.kernel.org/linux-phy/[email protected]/
> > >
> > > Changes in v2:
> > > - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
> > > and reusing the bindings.
> > > - Rephrased the commit message of patch 3/5
> > > - Removed stray lines from the patch 5/5
> > >
> > > This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.
> > The phy patches fail to apply, can you please rebase the three patches
> > and resend
> Can you please apply these two series. This series depends on it for
> successful compilation.
> [1] https://lore.kernel.org/all/[email protected]/

This one has a pending comment bw Konrad and Dmitry..

> [2] https://lore.kernel.org/linux-phy/[email protected]/

This one is already in -next

>
> Thanks,
> Rohit.

--
~Vinod

2023-10-13 10:48:19

by Rohit Agarwal

[permalink] [raw]
Subject: Re: [PATCH v4 0/5] Add USB Support on Qualcomm's SDX75 Platform


On 10/13/2023 4:15 PM, Vinod Koul wrote:
> On 13-10-23, 16:08, Rohit Agarwal wrote:
>> On 10/13/2023 3:59 PM, Vinod Koul wrote:
>>> On 22-09-23, 10:42, Rohit Agarwal wrote:
>>>> Hi,
>>>>
>>>> Changes in v4:
>>>> - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
>>>>
>>>> Changes in v3:
>>>> - Removed the unnecessary change introduced in v2 of patch 2/5
>>>> - Added Fixes tag in patch 3/5
>>>> - Rebased patch 5/5 on Dmitry's cleanup patches.
>>>> https://lore.kernel.org/all/[email protected]/
>>>> https://lore.kernel.org/linux-phy/[email protected]/
>>>>
>>>> Changes in v2:
>>>> - Dropped the new dt schema introduced in v1 for sdx75 usb3 phy
>>>> and reusing the bindings.
>>>> - Rephrased the commit message of patch 3/5
>>>> - Removed stray lines from the patch 5/5
>>>>
>>>> This series adds support of USB3 PHY support for Qualcomm's SDX75 Platform.
>>> The phy patches fail to apply, can you please rebase the three patches
>>> and resend
>> Can you please apply these two series. This series depends on it for
>> successful compilation.
>> [1] https://lore.kernel.org/all/[email protected]/
> This one has a pending comment bw Konrad and Dmitry..
Ok, Will wait for this to get resolved.

Thanks,
Rohit.
>
>> [2] https://lore.kernel.org/linux-phy/[email protected]/
> This one is already in -next
>
>> Thanks,
>> Rohit.

2023-11-27 13:22:52

by Vinod Koul

[permalink] [raw]
Subject: Re: (subset) [PATCH v4 0/5] Add USB Support on Qualcomm's SDX75 Platform


On Fri, 22 Sep 2023 10:42:00 +0530, Rohit Agarwal wrote:
> Changes in v4:
> - Replaced the v5 offsets with v6 offsets as per Dmitry's suggestion in patch 5/5.
>
> Changes in v3:
> - Removed the unnecessary change introduced in v2 of patch 2/5
> - Added Fixes tag in patch 3/5
> - Rebased patch 5/5 on Dmitry's cleanup patches.
> https://lore.kernel.org/all/[email protected]/
> https://lore.kernel.org/linux-phy/[email protected]/
>
> [...]

Applied, thanks!

[1/5] dt-bindings: phy: qcom,snps-eusb2-phy: Add compatible for SDX75
(no commit info)
[2/5] dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY
(no commit info)
[5/5] phy: qcom-qmp-usb: Add Qualcomm SDX75 USB3 PHY support
commit: 7f6f9e0def00cfaeb1d034fd13dbd84470aeccbd

Best regards,
--
~Vinod