2024-02-13 06:19:21

by Randy Dunlap

Subject: [PATCH v3] drm: drm_crtc: correct some comments

Fix some typos and punctuation.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Alex Deucher <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
---
v2: s/instances/instance/ (Alex)
v3: rebase and resend;
add more Cc:s

drivers/gpu/drm/drm_crtc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff -- a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -61,13 +61,13 @@
* to one or more &drm_encoder, which are then each connected to one
* &drm_connector.
*
- * To create a CRTC, a KMS drivers allocates and zeroes an instances of
+ * To create a CRTC, a KMS driver allocates and zeroes an instance of
* &struct drm_crtc (possibly as part of a larger structure) and registers it
* with a call to drm_crtc_init_with_planes().
*
- * The CRTC is also the entry point for legacy modeset operations, see
- * &drm_crtc_funcs.set_config, legacy plane operations, see
- * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2, and other legacy
+ * The CRTC is also the entry point for legacy modeset operations (see
+ * &drm_crtc_funcs.set_config), legacy plane operations (see
+ * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2), and other legacy
* operations like &drm_crtc_funcs.gamma_set. For atomic drivers all these
* features are controlled through &drm_property and
* &drm_mode_config_funcs.atomic_check.

2024-02-14 08:30:10

by Thomas Zimmermann

Subject: Re: [PATCH v3] drm: drm_crtc: correct some comments

Am 13.02.24 um 07:17 schrieb Randy Dunlap:
> Fix some typos and punctuation.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Alex Deucher <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: [email protected]
> Cc: Maarten Lankhorst <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Thomas Zimmermann <[email protected]>

Reviewed-by: Thomas Zimmermann <[email protected]>

> ---
> v2: s/instances/instance/ (Alex)
> v3: rebase and resend;
> add more Cc:s
>
> drivers/gpu/drm/drm_crtc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff -- a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -61,13 +61,13 @@
> * to one or more &drm_encoder, which are then each connected to one
> * &drm_connector.
> *
> - * To create a CRTC, a KMS drivers allocates and zeroes an instances of
> + * To create a CRTC, a KMS driver allocates and zeroes an instance of
> * &struct drm_crtc (possibly as part of a larger structure) and registers it
> * with a call to drm_crtc_init_with_planes().
> *
> - * The CRTC is also the entry point for legacy modeset operations, see
> - * &drm_crtc_funcs.set_config, legacy plane operations, see
> - * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2, and other legacy
> + * The CRTC is also the entry point for legacy modeset operations (see
> + * &drm_crtc_funcs.set_config), legacy plane operations (see
> + * &drm_crtc_funcs.page_flip and &drm_crtc_funcs.cursor_set2), and other legacy
> * operations like &drm_crtc_funcs.gamma_set. For atomic drivers all these
> * features are controlled through &drm_property and
> * &drm_mode_config_funcs.atomic_check.

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)