2009-11-02 18:28:58

by Thiago Farina

[permalink] [raw]
Subject: Re: [PATCH] trivial: fix assorted typos all over the place

I thought that this kind of patches were not allowed.

Don't you need to split this in individual patches, to make the work
in reviewing this, more easier?


2009-11-02 18:40:08

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH] trivial: fix assorted typos all over the place

On Mon, 2 Nov 2009, Thiago Farina wrote:

> I thought that this kind of patches were not allowed.

By whom?

> Don't you need to split this in individual patches, to make the work in
> reviewing this, more easier?

I'd say -- just use common sense. Comment typo fixes aren't big deal,
really.

If all the changes are just in the comments/help texts, then reviewing it
is really quite easy task which one can easily do while stuck/bored/too
tired to do other things which would actually require some thinking.

That said, if the spelling fixes touch some real code (variables/macro
defines etc), then they'd of course better be separated.

--
Jiri Kosina
SUSE Labs, Novell Inc.

2009-11-04 10:45:43

by André Goddard Rosa

[permalink] [raw]
Subject: Re: [PATCH] trivial: fix assorted typos all over the place

Hi, Thiago!

On Mon, Nov 2, 2009 at 4:29 PM, Thiago Farina <[email protected]> wrote:
> I thought that this kind of patches were not allowed.
>
> Don't you need to split this in individual patches, to make the work
> in reviewing this, more easier?
>

I have made it that way before sending the big consolidated patch.
Please see:
http://marc.info/?l=linux-kernel&m=125717767417323&w=2

Thanks,
Andr?