2009-11-08 15:44:49

by Jan Engelhardt

Subject: Re: [PATCH v4 07/12] vsprintf: factor out skip_space code in a separate function

On Saturday 2009-11-07 16:16, André Goddard Rosa wrote:

>It decreases code size:

And may increase runtime. If GCC determined that skip_space
itself (without the noinline you added) is going to be inlined,
let it go ahead.

> text data bss dec hex filename
> 15719 0 8 15727 3d6f lib/vsprintf.o-before
> 15543 0 8 15551 3cbf lib/vsprintf.o-after

2009-11-08 15:52:58

by André Goddard Rosa

Subject: Re: [PATCH v4 07/12] vsprintf: factor out skip_space code in a separate function

On Sun, Nov 8, 2009 at 1:44 PM, Jan Engelhardt <[email protected]> wrote:
>
> On Saturday 2009-11-07 16:16, Andr? Goddard Rosa wrote:
>
>>It decreases code size:
>
> And may increase runtime. If GCC determined that skip_space
> itself (without the noinline you added) is going to be inlined,
> let it go ahead.

Later in the series, when stepping over the whole tree for using that function,
I changed it to let gcc decide instead as you correctly pointed out.

Thanks for reviewing,
Andr?