On Sun, Nov 8, 2009 at 2:50 PM, Alan Cox <[email protected]> wrote:
> On Sat, ?7 Nov 2009 13:16:18 -0200
> Andr? Goddard Rosa <[email protected]> wrote:
>
>> On the following sentence:
>> ? ? while (*s && isspace(*s))
>> ? ? ? ? s++;
>
> Looks fine but for one thing: it's actually shorter inline than moved
> into /lib so at the very least it should be a header inline not a
> function call.
I have tried header "static inline" approach per your suggestion and
code size increases by 197 bytes from:
64954 584 588 66126 1024e (TOTALS-lib.a-before)
to:
65151 584 588 66323 10313 (TOTALS-lib.a-after)
> Second minor comment. Although it never made it into the final ANSI C,
> the proposed name (and the one used in a lot of other non Linux code for
> this) is stpblk().
Thank you,
Andr?