2009-11-09 15:31:41

by André Goddard Rosa

[permalink] [raw]
Subject: Re:

On Mon, Nov 9, 2009 at 10:39 AM, David Howells <[email protected]> wrote:
> MIME-Version: 1.0
> Content-Type: text/plain; charset=iso-8859-1
> Content-Transfer-Encoding: quoted-printable
>
> Andr=E9 Goddard Rosa <[email protected]> wrote:
>
>> It decreases code size:
>> ? ?text ? ?data ? ? bss ? ? dec ? ? hex filename
>> ? 15719 ? ? ? 0 ? ? ? 8 ? 15727 ? ?3d6f lib/vsprintf.o-before
>> ? 15543 ? ? ? 0 ? ? ? 8 ? 15551 ? ?3cbf lib/vsprintf.o-after
>
> Whilst this may be true, there will be a countervailing decrease in
> performance. ?Have you assessed that?

(trimmed long cc: list to keep it sane, I'll not use get_maintainer.pl
output this way anymore)

I'm not sure it decreases performance. From the last iteration of the
patch, I removed
the hint to force "not inlining", so that gcc can inline it if it
thinks it's better.

Are those so performance sensitive that it makes sense to perform this
assessment?
If you think so, what would you suggest? A micro-benchmark or some
real use case?

Best regards,
Andr?