2009-11-09 03:28:03

by Rusty Russell

[permalink] [raw]
Subject: Re: [PATCH v4 01/12] vsprintf: factorize "(null)" string

On Sun, 8 Nov 2009 01:46:09 am you wrote:
> Change "<NULL>" to "(null)" and make it a static const char[] hoping that
> the compiler will make null_str a label to a read-only area containing it.

(Trimmed the 79 recipients of the original).

Hi Andre,

Consistently using <NULL> or (null) makes sense. But I'm really missing your argument: is there some reason why normal string merging won't work?

Confused,
Rusty.


2009-11-10 14:33:29

by André Goddard Rosa

[permalink] [raw]
Subject: Re: [PATCH v4 01/12] vsprintf: factorize "(null)" string

On Mon, Nov 9, 2009 at 1:28 AM, Rusty Russell <[email protected]> wrote:
> Hi Andre,
>
> Consistently using <NULL> or (null) makes sense. ?But I'm really missing your argument: is there some reason
> why normal string merging won't work?
>

Hi, Rusty!

I agree that it works fine as well; the factorization only makes
explicit the fact that's a constant string, that's all.

Thank you,
Andr?