On Sat, 07 Nov 2009, Andr? Goddard Rosa wrote:
> Also, while at it, if we see (*str && isspace(*str)), we can be sure to
> remove the first condition (*str) as the second one (isspace(*str)) also
> evaluates to 0 whenever *str == 0, making it redundant. In other words,
> "a char equals zero is never a space".
You didn't document in isspace() that it must return false for NUL. Please
do that before you remove any such checks.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
On Sat, Nov 14, 2009 at 1:20 PM, Henrique de Moraes Holschuh
<[email protected]> wrote:
> On Sat, 07 Nov 2009, Andr? Goddard Rosa wrote:
>> Also, while at it, if we see (*str && isspace(*str)), we can be sure to
>> remove the first condition (*str) as the second one (isspace(*str)) also
>> evaluates to 0 whenever *str == 0, making it redundant. In other words,
>> "a char equals zero is never a space".
>
> You didn't document in isspace() that it must return false for NUL. ?Please
> do that before you remove any such checks.
>
Good idea Henrique, I will do it!
Thank you,
Andr?