2024-01-06 12:42:28

by Colin Ian King

Subject: [PATCH][next] accel/habanalabs: remove redundant assignment to pointer 'input'

From: Colin Ian King <[email protected]>

The pointer input is assigned a value that is not read, it is
being re-assigned again later with the same value. Resolve this
by moving the declaration to input into the if block.

Cleans up clang scan build warning:
warning: Value stored to 'input' during its initialization is never
read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/accel/habanalabs/goya/goya_coresight.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/accel/habanalabs/goya/goya_coresight.c b/drivers/accel/habanalabs/goya/goya_coresight.c
index 41cae5fd843b..3827ea4c02f7 100644
--- a/drivers/accel/habanalabs/goya/goya_coresight.c
+++ b/drivers/accel/habanalabs/goya/goya_coresight.c
@@ -576,7 +576,6 @@ static int goya_config_spmu(struct hl_device *hdev,
struct hl_debug_params *params)
{
u64 base_reg;
- struct hl_debug_params_spmu *input = params->input;
u64 *output;
u32 output_arr_len;
u32 events_num;
@@ -592,7 +591,7 @@ static int goya_config_spmu(struct hl_device *hdev,
base_reg = debug_spmu_regs[params->reg_idx] - CFG_BASE;

if (params->enable) {
- input = params->input;
+ struct hl_debug_params_spmu *input = params->input;

if (!input)
return -EINVAL;
--
2.43.0

2024-01-09 14:41:11

by Oded Gabbay

Subject: Re: [PATCH][next] accel/habanalabs: remove redundant assignment to pointer 'input'

On 06/01/2024 14:42, Colin Ian King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer input is assigned a value that is not read, it is
> being re-assigned again later with the same value. Resolve this
> by moving the declaration to input into the if block.
>
> Cleans up clang scan build warning:
> warning: Value stored to 'input' during its initialization is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/accel/habanalabs/goya/goya_coresight.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/accel/habanalabs/goya/goya_coresight.c b/drivers/accel/habanalabs/goya/goya_coresight.c
> index 41cae5fd843b..3827ea4c02f7 100644
> --- a/drivers/accel/habanalabs/goya/goya_coresight.c
> +++ b/drivers/accel/habanalabs/goya/goya_coresight.c
> @@ -576,7 +576,6 @@ static int goya_config_spmu(struct hl_device *hdev,
> struct hl_debug_params *params)
> {
> u64 base_reg;
> - struct hl_debug_params_spmu *input = params->input;
> u64 *output;
> u32 output_arr_len;
> u32 events_num;
> @@ -592,7 +591,7 @@ static int goya_config_spmu(struct hl_device *hdev,
> base_reg = debug_spmu_regs[params->reg_idx] - CFG_BASE;
>
> if (params->enable) {
> - input = params->input;
> + struct hl_debug_params_spmu *input = params->input;
>
> if (!input)
> return -EINVAL;
Thanks for the patch.
Reviewed-by: Oded Gabbay <[email protected]>
Applied to -next.
Oded