2023-07-24 13:34:29

by Konrad Dybcio

Subject: Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload size for IPQ9574

On 24.07.2023 14:47, Praveenkumar I wrote:
> Set 256 bytes as payload size for IPQ9574 via early fixup. This allows
> PCIe RC to use the max payload size when a capable link partner is
> connected.
>
> Signed-off-by: Praveenkumar I <[email protected]>
> ---
[...]

>
> +static void qcom_fixup_mps_256(struct pci_dev *dev)
> +{
> + pcie_set_mps(dev, 256);
Looks like setting "dev->pcie_mpss = 1" here would make the PCIe generic
code take care of this.

Konrad

2023-07-24 14:32:59

by Praveenkumar I

Subject: Re: [PATCH 1/1] PCI: qcom: Add early fixup to set the max payload size for IPQ9574

On 7/24/2023 6:23 PM, Konrad Dybcio wrote:
> On 24.07.2023 14:47, Praveenkumar I wrote:
>> Set 256 bytes as payload size for IPQ9574 via early fixup. This allows
>> PCIe RC to use the max payload size when a capable link partner is
>> connected.
>>
>> Signed-off-by: Praveenkumar I <[email protected]>
>> ---
> [...]
>
>> +static void qcom_fixup_mps_256(struct pci_dev *dev)
>> +{
>> + pcie_set_mps(dev, 256);
> Looks like setting "dev->pcie_mpss = 1" here would make the PCIe generic
> code take care of this.
Yes, but that is not helping as the generic code pci_configure_mps() has
a check for,
/         if (!bridge || !pci_is_pcie(bridge))/
/            return;/
/Here it is returning and mps is not set to new 256 bytes./
>
> Konrad
--
Thanks,
Praveenkumar