2018-01-14 21:06:35

by SF Markus Elfring

Subject: [PATCH] mfd/htc-i2cpld: Delete an error message for a failed memory allocation in htcpld_setup_chips()

From: Markus Elfring <[email protected]>
Date: Sun, 14 Jan 2018 22:02:16 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/htc-i2cpld.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
index 3f9eee5f8fb9..4bf8b7781c77 100644
--- a/drivers/mfd/htc-i2cpld.c
+++ b/drivers/mfd/htc-i2cpld.c
@@ -479,10 +479,8 @@ static int htcpld_setup_chips(struct platform_device *pdev)
htcpld->nchips = pdata->num_chip;
htcpld->chip = devm_kzalloc(dev, sizeof(struct htcpld_chip) * htcpld->nchips,
GFP_KERNEL);
- if (!htcpld->chip) {
- dev_warn(dev, "Unable to allocate memory for chips\n");
+ if (!htcpld->chip)
return -ENOMEM;
- }

/* Add the chips as best we can */
for (i = 0; i < htcpld->nchips; i++) {
--
2.15.1

2018-01-22 15:23:41

by Lee Jones

Subject: Re: [PATCH] mfd/htc-i2cpld: Delete an error message for a failed memory allocation in htcpld_setup_chips()

On Sun, 14 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Sun, 14 Jan 2018 22:02:16 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/htc-i2cpld.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog