2023-05-25 15:11:04

by Richard Fitzgerald

[permalink] [raw]
Subject: [PATCH 08/13] ASoC: cs35l56: Pass correct pointer to cs35l56_irq()

cs35l56_irq() was changed to take a cs35l56_base* but the code
in cs35l56-sdw was still passing it a cs35l56_private*.

Signed-off-by: Richard Fitzgerald <[email protected]>
---
sound/soc/codecs/cs35l56-sdw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs35l56-sdw.c b/sound/soc/codecs/cs35l56-sdw.c
index 09d255cc7652..b433266b7844 100644
--- a/sound/soc/codecs/cs35l56-sdw.c
+++ b/sound/soc/codecs/cs35l56-sdw.c
@@ -230,7 +230,7 @@ static void cs35l56_sdw_irq_work(struct work_struct *work)
struct cs35l56_private,
sdw_irq_work);

- cs35l56_irq(-1, cs35l56);
+ cs35l56_irq(-1, &cs35l56->base);

/* unmask interrupts */
if (!cs35l56->sdw_irq_no_unmask)
--
2.30.2



2023-05-25 15:37:12

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 08/13] ASoC: cs35l56: Pass correct pointer to cs35l56_irq()

On Thu, May 25, 2023 at 04:06:54PM +0100, Richard Fitzgerald wrote:
> cs35l56_irq() was changed to take a cs35l56_base* but the code
> in cs35l56-sdw was still passing it a cs35l56_private*.

For bisection this should be squashed into the change it's fixing.


Attachments:
(No filename) (264.00 B)
signature.asc (499.00 B)
Download all attachments

2023-05-25 15:49:03

by Richard Fitzgerald

[permalink] [raw]
Subject: Re: [PATCH 08/13] ASoC: cs35l56: Pass correct pointer to cs35l56_irq()

On 25/5/23 16:14, Mark Brown wrote:
> On Thu, May 25, 2023 at 04:06:54PM +0100, Richard Fitzgerald wrote:
>> cs35l56_irq() was changed to take a cs35l56_base* but the code
>> in cs35l56-sdw was still passing it a cs35l56_private*.
>
> For bisection this should be squashed into the change it's fixing.

Oh damn. I knew I had to do that and forgot.