2020-03-20 06:26:01

by Qiujun Huang

Subject: [PATCH v2] PCI: dwc: fix compile err for pcie-tagra194

make allmodconfig
ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
make[2]: *** [__modpost] Error 1
make[1]: *** [modules] Error 2
make: *** [sub-make] Error 2

need to export the symbols.

Signed-off-by: Qiujun Huang <[email protected]>
---
drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
index 4233c43..1cdcbd1 100644
--- a/drivers/pci/controller/dwc/pcie-designware-ep.c
+++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
@@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)

pci_epc_linkup(epc);
}
+EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);

void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
{
@@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)

pci_epc_init_notify(epc);
}
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);

static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
int flags)
@@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)

return 0;
}
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);

int dw_pcie_ep_init(struct dw_pcie_ep *ep)
{
@@ -629,3 +632,4 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)

return dw_pcie_ep_init_complete(ep);
}
+EXPORT_SYMBOL_GPL(dw_pcie_ep_init);
--
1.8.3.1

2020-03-20 09:16:35

by Vidya Sagar

Subject: Re: [PATCH v2] PCI: dwc: fix compile err for pcie-tagra194

On 3/20/2020 11:54 AM, Qiujun Huang wrote:
> External email: Use caution opening links or attachments
>
>
> make allmodconfig
> ERROR: modpost: "dw_pcie_ep_init" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_init_notify" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_init_complete" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> ERROR: modpost: "dw_pcie_ep_linkup" [drivers/pci/controller/dwc/pcie-tegra194.ko] undefined!
> make[2]: *** [__modpost] Error 1
> make[1]: *** [modules] Error 2
> make: *** [sub-make] Error 2
>
> need to export the symbols.
>
> Signed-off-by: Qiujun Huang <[email protected]>
> ---
> drivers/pci/controller/dwc/pcie-designware-ep.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> index 4233c43..1cdcbd1 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> @@ -18,6 +18,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep)
>
> pci_epc_linkup(epc);
> }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_linkup);
>
> void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
> {
> @@ -25,6 +26,7 @@ void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep)
>
> pci_epc_init_notify(epc);
> }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_notify);
>
> static void __dw_pcie_ep_reset_bar(struct dw_pcie *pci, enum pci_barno bar,
> int flags)
> @@ -535,6 +537,7 @@ int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep)
>
> return 0;
> }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init_complete);
>
> int dw_pcie_ep_init(struct dw_pcie_ep *ep)
> {
> @@ -629,3 +632,4 @@ int dw_pcie_ep_init(struct dw_pcie_ep *ep)
>
> return dw_pcie_ep_init_complete(ep);
> }
> +EXPORT_SYMBOL_GPL(dw_pcie_ep_init);
> --
> 1.8.3.1
>

Thanks for the change Qiujun.
Reviewed-by: Vidya Sagar <[email protected]>
Tested-by: Vidya Sagar <[email protected]>