2009-10-02 05:15:22

by Rakib Mullick

Subject: [PATCH] acpi: Annote acpi_processor_add with __cpuinit.

Annote acpi_processor_add with cpuinit since it calls a cpuinit function
acpi_processor_power_init and fixes a section mismatch warning.

We were warned by the following warning:

LD drivers/acpi/processor.o
WARNING: drivers/acpi/processor.o(.text+0x1829): Section mismatch in
reference from the function acpi_processor_add() to the function
.cpuinit.text:acpi_processor_power_init()
The function acpi_processor_add() references
the function __cpuinit acpi_processor_power_init().
This is often because acpi_processor_add lacks a __cpuinit
annotation or the annotation of acpi_processor_power_init is wrong.

-------
Signed-off-by: Rakib Mullick <[email protected]>

--- linus/drivers/acpi/processor_core.c 2009-09-28 12:04:54.000000000 +0600
+++ rakib/drivers/acpi/processor_core.c 2009-09-29 23:21:13.000000000 +0600
@@ -770,7 +770,7 @@ static struct notifier_block acpi_cpu_no
.notifier_call = acpi_cpu_soft_notify,
};

-static int acpi_processor_add(struct acpi_device *device)
+static int __cpuinit acpi_processor_add(struct acpi_device *device)
{
struct acpi_processor *pr = NULL;
int result = 0;

2009-11-05 21:50:01

by Len Brown

Subject: Re: [PATCH] acpi: Annote acpi_processor_add with __cpuinit.

applied

thanks,
Len Brown, Intel Open Source Technology Center