2018-09-06 16:42:24

by Katsuhiro Suzuki

Subject: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328

This patch adds port and endpoint of i2s and spdif nodes for rk3328.
Because to use modern sound card interface such as audio-graph-card.

Signed-off-by: Katsuhiro Suzuki <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index d3ef6566325e..41f0a20b73ed 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -179,7 +179,13 @@
clock-names = "i2s_clk", "i2s_hclk";
dmas = <&dmac 11>, <&dmac 12>;
dma-names = "tx", "rx";
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ i2s0_p0: port@0 {
+ i2s0_p0_0: endpoint {
+ };
+ };
};

i2s1: i2s@ff010000 {
@@ -190,7 +196,13 @@
clock-names = "i2s_clk", "i2s_hclk";
dmas = <&dmac 14>, <&dmac 15>;
dma-names = "tx", "rx";
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ i2s1_p0: port@0 {
+ i2s1_p0_0: endpoint {
+ };
+ };
};

i2s2: i2s@ff020000 {
@@ -201,7 +213,13 @@
clock-names = "i2s_clk", "i2s_hclk";
dmas = <&dmac 0>, <&dmac 1>;
dma-names = "tx", "rx";
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ i2s2_p0: port@0 {
+ i2s2_p0_0: endpoint {
+ };
+ };
};

spdif: spdif@ff030000 {
@@ -214,7 +232,13 @@
dma-names = "tx";
pinctrl-names = "default";
pinctrl-0 = <&spdifm2_tx>;
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ spdif_p0: port@0 {
+ spdif_p0_0: endpoint {
+ };
+ };
};

pdm: pdm@ff040000 {
--
2.18.0

2018-09-10 13:59:42

by Heiko Stuebner

Subject: Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328

Hi,

Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki:
> This patch adds port and endpoint of i2s and spdif nodes for rk3328.
> Because to use modern sound card interface such as audio-graph-card.
>
> Signed-off-by: Katsuhiro Suzuki <[email protected]>
> ---
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index d3ef6566325e..41f0a20b73ed 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -179,7 +179,13 @@
> clock-names = "i2s_clk", "i2s_hclk";
> dmas = <&dmac 11>, <&dmac 12>;
> dma-names = "tx", "rx";
> + #sound-dai-cells = <0>;
> status = "disabled";
> +
> + i2s0_p0: port@0 {

there is only one port per device, so this should probably be
i2s0_p0: port {
without the address. Same for all others.
The of-graph framework should work just fine then as well.

Heiko

2018-09-10 16:10:44

by Katsuhiro Suzuki

Subject: Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328

Hi Heiko,

On 2018年09月10日 22:57, Heiko Stuebner wrote:
> Hi,
>
> Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki:
>> This patch adds port and endpoint of i2s and spdif nodes for rk3328.
>> Because to use modern sound card interface such as audio-graph-card.
>>
>> Signed-off-by: Katsuhiro Suzuki <[email protected]>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> index d3ef6566325e..41f0a20b73ed 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> @@ -179,7 +179,13 @@
>> clock-names = "i2s_clk", "i2s_hclk";
>> dmas = <&dmac 11>, <&dmac 12>;
>> dma-names = "tx", "rx";
>> + #sound-dai-cells = <0>;
>> status = "disabled";
>> +
>> + i2s0_p0: port@0 {
>
> there is only one port per device, so this should probably be
> i2s0_p0: port {
> without the address. Same for all others.
> The of-graph framework should work just fine then as well.

Thanks, indeed. I'll fix and send v2.


>
> Heiko
>
>
>

Regards,
--
Katsuhiro Suzuki