2024-03-25 09:47:44

by Gao Xiang

[permalink] [raw]
Subject: [PATCH] erofs: drop experimental warning for FSDAX

As EXT4/XFS filesystems, FSDAX functionality is considered to be stable.
Let's drop this warning.

Signed-off-by: Gao Xiang <[email protected]>
---
fs/erofs/super.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 6fbb1fba2d31..fc60a5a7794f 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -430,7 +430,6 @@ static bool erofs_fc_set_dax_mode(struct fs_context *fc, unsigned int mode)

switch (mode) {
case EROFS_MOUNT_DAX_ALWAYS:
- warnfc(fc, "DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
set_opt(&ctx->opt, DAX_ALWAYS);
clear_opt(&ctx->opt, DAX_NEVER);
return true;
--
2.39.3



2024-03-25 11:18:39

by Jingbo Xu

[permalink] [raw]
Subject: Re: [PATCH] erofs: drop experimental warning for FSDAX



On 3/25/24 8:51 AM, Gao Xiang wrote:
> As EXT4/XFS filesystems, FSDAX functionality is considered to be stable.
> Let's drop this warning.
>
> Signed-off-by: Gao Xiang <[email protected]>
> ---
> fs/erofs/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 6fbb1fba2d31..fc60a5a7794f 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -430,7 +430,6 @@ static bool erofs_fc_set_dax_mode(struct fs_context *fc, unsigned int mode)
>
> switch (mode) {
> case EROFS_MOUNT_DAX_ALWAYS:
> - warnfc(fc, "DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
> set_opt(&ctx->opt, DAX_ALWAYS);
> clear_opt(&ctx->opt, DAX_NEVER);
> return true;

Reviewed-by: Jingbo Xu <[email protected]>

--
Thanks,
Jingbo