2022-11-03 13:07:59

by Cosmin Tanislav

Subject: [PATCH v4 11/13] dt-bindings: iio: temperature: ltc2983: use generic node name in example

From: Cosmin Tanislav <[email protected]>

Examples should use the generic IIO node name. Fix it.

Signed-off-by: Cosmin Tanislav <[email protected]>
---
.../devicetree/bindings/iio/temperature/adi,ltc2983.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
index 467e165e9b0b..bd357ff28e65 100644
--- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
@@ -420,7 +420,7 @@ examples:
#address-cells = <1>;
#size-cells = <0>;

- sensor_ltc2983: ltc2983@0 {
+ temp@0 {
compatible = "adi,ltc2983";
reg = <0>;

--
2.38.1

2022-11-07 18:25:14

by Rob Herring

Subject: Re: [PATCH v4 11/13] dt-bindings: iio: temperature: ltc2983: use generic node name in example

On Thu, Nov 03, 2022 at 03:00:39PM +0200, Cosmin Tanislav wrote:
> From: Cosmin Tanislav <[email protected]>
>
> Examples should use the generic IIO node name. Fix it.
>
> Signed-off-by: Cosmin Tanislav <[email protected]>
> ---
> .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
> index 467e165e9b0b..bd357ff28e65 100644
> --- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
> +++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
> @@ -420,7 +420,7 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> - sensor_ltc2983: ltc2983@0 {
> + temp@0 {

The DT spec defines 'temperature-sensor'.

> compatible = "adi,ltc2983";
> reg = <0>;
>
> --
> 2.38.1
>
>

2022-11-08 09:07:28

by Cosmin Tanislav

Subject: Re: [PATCH v4 11/13] dt-bindings: iio: temperature: ltc2983: use generic node name in example

On Mon, 2022-11-07 at 12:13 -0600, Rob Herring wrote:
> On Thu, Nov 03, 2022 at 03:00:39PM +0200, Cosmin Tanislav wrote:
> > From: Cosmin Tanislav <[email protected]>
> >
> > Examples should use the generic IIO node name. Fix it.
> >
> > Signed-off-by: Cosmin Tanislav <[email protected]>
> > ---
> >  .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml        |
> > 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > index 467e165e9b0b..bd357ff28e65 100644
> > ---
> > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > @@ -420,7 +420,7 @@ examples:
> >          #address-cells = <1>;
> >          #size-cells = <0>;
> >  
> > -        sensor_ltc2983: ltc2983@0 {
> > +        temp@0 {
>
> The DT spec defines 'temperature-sensor'.

Jonathan, could you maybe fix this (replace 'temp' with
'temperature-sensor') while picking it up? Thanks.

>
> >                  compatible = "adi,ltc2983";
> >                  reg = <0>;
> >  
> > --
> > 2.38.1
> >
> >

2022-11-12 16:06:54

by Jonathan Cameron

Subject: Re: [PATCH v4 11/13] dt-bindings: iio: temperature: ltc2983: use generic node name in example

On Tue, 08 Nov 2022 10:37:23 +0200
Cosmin Tanislav <[email protected]> wrote:

> On Mon, 2022-11-07 at 12:13 -0600, Rob Herring wrote:
> > On Thu, Nov 03, 2022 at 03:00:39PM +0200, Cosmin Tanislav wrote:
> > > From: Cosmin Tanislav <[email protected]>
> > >
> > > Examples should use the generic IIO node name. Fix it.
> > >
> > > Signed-off-by: Cosmin Tanislav <[email protected]>
> > > ---
> > >  .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml        |
> > > 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > index 467e165e9b0b..bd357ff28e65 100644
> > > ---
> > > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > @@ -420,7 +420,7 @@ examples:
> > >          #address-cells = <1>;
> > >          #size-cells = <0>;
> > >  
> > > -        sensor_ltc2983: ltc2983@0 {
> > > +        temp@0 {
> >
> > The DT spec defines 'temperature-sensor'.
>
> Jonathan, could you maybe fix this (replace 'temp' with
> 'temperature-sensor') while picking it up? Thanks.

Done.
>
> >
> > >                  compatible = "adi,ltc2983";
> > >                  reg = <0>;
> > >  
> > > --
> > > 2.38.1
> > >
> > >
>