2019-12-05 03:02:37

by Rahul Tanwar

Subject: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

Fix below linker error

ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
`pinconf_generic_dt_node_to_map_all':
pinctrl-equilibrium.c:(.text+0xb): undefined reference
to `pinconf_generic_dt_node_to_map'

Caused by below commit

1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")

by adding 'depends on OF' in Kconfig driver entry.

Reported-by: Randy Dunlap <[email protected]>>
Signed-off-by: Rahul Tanwar <[email protected]>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 3bfbf2ff6e2b..ba0cad4bd072 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -422,6 +422,7 @@ config PINCTRL_TB10X

config PINCTRL_EQUILIBRIUM
tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
+ depends on OF
select PINMUX
select PINCONF
select GPIOLIB
--
2.11.0

2019-12-05 03:43:19

by Randy Dunlap

Subject: Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

On 12/4/19 7:01 PM, Rahul Tanwar wrote:
> Fix below linker error
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
> `pinconf_generic_dt_node_to_map_all':
> pinctrl-equilibrium.c:(.text+0xb): undefined reference
> to `pinconf_generic_dt_node_to_map'
>
> Caused by below commit
>
> 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
>
> by adding 'depends on OF' in Kconfig driver entry.
>
> Reported-by: Randy Dunlap <[email protected]>>
> Signed-off-by: Rahul Tanwar <[email protected]>

Acked-by: Randy Dunlap <[email protected]> # build-tested


Thanks.

> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 3bfbf2ff6e2b..ba0cad4bd072 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -422,6 +422,7 @@ config PINCTRL_TB10X
>
> config PINCTRL_EQUILIBRIUM
> tristate "Generic pinctrl and GPIO driver for Intel Lightning Mountain SoC"
> + depends on OF
> select PINMUX
> select PINCONF
> select GPIOLIB
>


--
~Randy

2019-12-13 10:07:48

by Linus Walleij

Subject: Re: [PATCH 1/1] pinctrl: Modify Kconfig to fix linker error

On Thu, Dec 5, 2019 at 4:01 AM Rahul Tanwar
<[email protected]> wrote:

> Fix below linker error
>
> ld: drivers/pinctrl/pinctrl-equilibrium.o: in function
> `pinconf_generic_dt_node_to_map_all':
> pinctrl-equilibrium.c:(.text+0xb): undefined reference
> to `pinconf_generic_dt_node_to_map'
>
> Caused by below commit
>
> 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
>
> by adding 'depends on OF' in Kconfig driver entry.
>
> Reported-by: Randy Dunlap <[email protected]>>
> Signed-off-by: Rahul Tanwar <[email protected]>

Patch applied for fixes, thanks!

Linus Walleij