2023-07-14 15:14:27

by Sarah Walker

[permalink] [raw]
Subject: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

Add the Series AXE GPU node to the AM62 device tree.

Signed-off-by: Sarah Walker <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index b3e4857bbbe4..ad13414acf18 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -892,4 +892,17 @@ mcasp2: audio-controller@2b20000 {
power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
status = "disabled";
};
+
+ gpu: gpu@fd00000 {
+ compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
+ reg = <0 0x0fd00000 0 0x20000>;
+ power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 187 0>;
+ clock-names = "core";
+ interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "gpu";
+ #cooling-cells = <2>;
+ #cooling-min-level = <0>;
+ #cooling-max-level = <3>;
+ };
};
--
2.41.0



2023-07-17 09:01:06

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

Hi,

On Fri, Jul 14, 2023 at 03:30:33PM +0100, Sarah Walker wrote:
> Add the Series AXE GPU node to the AM62 device tree.
>
> Signed-off-by: Sarah Walker <[email protected]>

Checkpatch complains about that one because you indented the node with
spaces instead of tabs.

Once fixed:
Reviewed-by: Maxime Ripard <[email protected]>

Maxime

Attachments:
(No filename) (360.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-07-18 06:29:25

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

On 14/07/2023 16:30, Sarah Walker wrote:
> Add the Series AXE GPU node to the AM62 device tree.
>
> Signed-off-by: Sarah Walker <[email protected]>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index b3e4857bbbe4..ad13414acf18 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -892,4 +892,17 @@ mcasp2: audio-controller@2b20000 {
> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> status = "disabled";
> };
> +
> + gpu: gpu@fd00000 {
> + compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> + reg = <0 0x0fd00000 0 0x20000>;
> + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> + clocks = <&k3_clks 187 0>;
> + clock-names = "core";
> + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "gpu";
> + #cooling-cells = <2>;
> + #cooling-min-level = <0>;
> + #cooling-max-level = <3>;

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof


2023-07-18 12:08:15

by Frank Binns

[permalink] [raw]
Subject: Re: [PATCH v4 17/17] arm64: dts: ti: k3-am62-main: Add GPU device node [DO NOT MERGE]

Hi Krzysztof,

On Tue, 2023-07-18 at 08:19 +0200, Krzysztof Kozlowski wrote:
> On 14/07/2023 16:30, Sarah Walker wrote:
> > Add the Series AXE GPU node to the AM62 device tree.
> >
> > Signed-off-by: Sarah Walker <[email protected]>
> > ---
> > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index b3e4857bbbe4..ad13414acf18 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -892,4 +892,17 @@ mcasp2: audio-controller@2b20000 {
> > power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
> > status = "disabled";
> > };
> > +
> > + gpu: gpu@fd00000 {
> > + compatible = "ti,am62-gpu", "img,powervr-seriesaxe";
> > + reg = <0 0x0fd00000 0 0x20000>;
> > + power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > + clocks = <&k3_clks 187 0>;
> > + clock-names = "core";
> > + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-names = "gpu";
> > + #cooling-cells = <2>;
> > + #cooling-min-level = <0>;
> > + #cooling-max-level = <3>;
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).

Thank you for the tip. I'll have a read through.

Frank

>
> Best regards,
> Krzysztof
>