2018-01-13 10:49:07

by SF Markus Elfring

Subject: [PATCH] pinctrl: pinmux: Use seq_putc() in pinmux_pins_show()

From: Markus Elfring <[email protected]>
Date: Sat, 13 Jan 2018 11:33:47 +0100

A single character (line break) should be put into a sequence.
Thus use the corresponding function "seq_putc".

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/pinctrl/pinmux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index 55502fc4479c..139a004a5e71 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -619,7 +619,7 @@ static int pinmux_pins_show(struct seq_file *s, void *what)
pctlops->get_group_name(pctldev,
desc->mux_setting->group));
else
- seq_printf(s, "\n");
+ seq_putc(s, '\n');
}

mutex_unlock(&pctldev->mutex);
--
2.15.1

2018-01-16 10:07:44

by Linus Walleij

Subject: Re: [PATCH] pinctrl: pinmux: Use seq_putc() in pinmux_pins_show()

On Sat, Jan 13, 2018 at 11:49 AM, SF Markus Elfring
<[email protected]> wrote:

> From: Markus Elfring <[email protected]>
> Date: Sat, 13 Jan 2018 11:33:47 +0100
>
> A single character (line break) should be put into a sequence.
> Thus use the corresponding function "seq_putc".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>

Patch applied.

Yours,
Linus Walleij