2024-05-14 10:44:00

by Gautam Menghani

Subject: [PATCH] arch/powerpc: Remove the definition of unused cede function

Remove extended_cede_processor() definition as it has no callers since
commit 48f6e7f6d948("powerpc/pseries: remove cede offline state for CPUs")

Signed-off-by: Gautam Menghani <[email protected]>
---
arch/powerpc/include/asm/plpar_wrappers.h | 18 ------------------
1 file changed, 18 deletions(-)

diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h
index b3ee44a40c2f..6431fa1e1cb1 100644
--- a/arch/powerpc/include/asm/plpar_wrappers.h
+++ b/arch/powerpc/include/asm/plpar_wrappers.h
@@ -37,24 +37,6 @@ static inline long cede_processor(void)
return plpar_hcall_norets_notrace(H_CEDE);
}

-static inline long extended_cede_processor(unsigned long latency_hint)
-{
- long rc;
- u8 old_latency_hint = get_cede_latency_hint();
-
- set_cede_latency_hint(latency_hint);
-
- rc = cede_processor();
-
- /* Ensure that H_CEDE returns with IRQs on */
- if (WARN_ON(IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG) && !(mfmsr() & MSR_EE)))
- __hard_irq_enable();
-
- set_cede_latency_hint(old_latency_hint);
-
- return rc;
-}
-
static inline long vpa_call(unsigned long flags, unsigned long cpu,
unsigned long vpa)
{
--
2.45.0

2024-05-14 11:18:22

by Naveen N Rao

Subject: Re: [PATCH] arch/powerpc: Remove the definition of unused cede function

On Tue, May 14, 2024 at 03:35:03PM GMT, Gautam Menghani wrote:
> Remove extended_cede_processor() definition as it has no callers since
> commit 48f6e7f6d948("powerpc/pseries: remove cede offline state for CPUs")

extended_cede_processor() was added in commit 69ddb57cbea0
("powerpc/pseries: Add extended_cede_processor() helper function."),
which also added [get|set]_cede_latency_hint(). Those can also be
removed if extended_cede_processor() is no longer needed.

- Naveen

>
> Signed-off-by: Gautam Menghani <[email protected]>
> ---
> arch/powerpc/include/asm/plpar_wrappers.h | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/plpar_wrappers.h b/arch/powerpc/include/asm/plpar_wrappers.h
> index b3ee44a40c2f..6431fa1e1cb1 100644
> --- a/arch/powerpc/include/asm/plpar_wrappers.h
> +++ b/arch/powerpc/include/asm/plpar_wrappers.h
> @@ -37,24 +37,6 @@ static inline long cede_processor(void)
> return plpar_hcall_norets_notrace(H_CEDE);
> }
>
> -static inline long extended_cede_processor(unsigned long latency_hint)
> -{
> - long rc;
> - u8 old_latency_hint = get_cede_latency_hint();
> -
> - set_cede_latency_hint(latency_hint);
> -
> - rc = cede_processor();
> -
> - /* Ensure that H_CEDE returns with IRQs on */
> - if (WARN_ON(IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG) && !(mfmsr() & MSR_EE)))
> - __hard_irq_enable();
> -
> - set_cede_latency_hint(old_latency_hint);
> -
> - return rc;
> -}
> -
> static inline long vpa_call(unsigned long flags, unsigned long cpu,
> unsigned long vpa)
> {
> --
> 2.45.0
>

2024-05-14 11:56:50

by Gautam Menghani

Subject: Re: [PATCH] arch/powerpc: Remove the definition of unused cede function

On Tue, May 14, 2024 at 04:20:04PM GMT, Naveen N Rao wrote:
> On Tue, May 14, 2024 at 03:35:03PM GMT, Gautam Menghani wrote:
> > Remove extended_cede_processor() definition as it has no callers since
> > commit 48f6e7f6d948("powerpc/pseries: remove cede offline state for CPUs")
>
> extended_cede_processor() was added in commit 69ddb57cbea0
> ("powerpc/pseries: Add extended_cede_processor() helper function."),
> which also added [get|set]_cede_latency_hint(). Those can also be
> removed if extended_cede_processor() is no longer needed.

Yes thanks for pointing it out, will remove them as well.

Thanks,
Gautam